From: "Rebecca Cran" <rebecca@bsdio.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for *.makefile
Date: Fri, 24 Mar 2023 13:18:39 -0600 [thread overview]
Message-ID: <63e341b6-1b90-086b-8587-3617ac6340d6@bsdio.com> (raw)
In-Reply-To: <CO1PR11MB492975BC76937EF3FB4D4072D2849@CO1PR11MB4929.namprd11.prod.outlook.com>
On 3/24/23 12:46 PM, Kinney, Michael D wrote:
> Should is be ".makefile" or perhaps use os.path.splitext() instead?
Good point. I've updated the code to use os.path.splitext() instead, and
change the check for 'Makefile' to be case-insensitive since some are
which are missing the upper-case 'M':
./BaseTools/Source/C/VfrCompile/Pccts/support/genmk/makefile
./BaseTools/Source/C/VfrCompile/Pccts/support/rexpr/makefile
./BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
./BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile
I've sent out a v2 revision.
--
Rebecca Cran
prev parent reply other threads:[~2023-03-24 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 16:32 [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for *.makefile Rebecca Cran
2023-03-24 18:46 ` Michael D Kinney
2023-03-24 19:18 ` Rebecca Cran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63e341b6-1b90-086b-8587-3617ac6340d6@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox