From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mx.groups.io with SMTP id smtpd.web11.6123.1679685522828031427 for ; Fri, 24 Mar 2023 12:18:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=Fc+BOgvZ; spf=pass (domain: bsdio.com, ip: 64.147.123.21, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 99FEA320034E; Fri, 24 Mar 2023 15:18:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 24 Mar 2023 15:18:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1679685521; x=1679771921; bh=dNUQs+NCuefQxIeI3y60bXfIO4cnlj9VAU4 kV/PtzKU=; b=Fc+BOgvZVxtvNx1qoFeL7ql2W6nmfnIHRoiYbUtyORnY1PXiEMl xBrcmgNS/1FnITYLiRXlNcRv4RG4Wgkv6+BZg1b5n08EXOVP4Q8oqy29M1i2AERU FDNawyF5bdbgNOjhVp8NklCcKBHwUw+eGYusWr+O9UpIN4wYCjrpbtvyAzsKxHEt pn+HPjzAs80F5KNp5wAtUG+WPAM9XRV0GFMfWsEb+gNKGiutxRqvxJNfw23gNk/A tyP50BO3p60J0Ri1afMR/XMUFAoLSNycvyoIoIcuGH01CH3SwjLT+dlIsW/P6wne dGeUeoLJd0aGLJDkECx0uzsk6se3rFND6Fw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1679685521; x= 1679771921; bh=dNUQs+NCuefQxIeI3y60bXfIO4cnlj9VAU4kV/PtzKU=; b=a MQ/RcxKvFknyPFVfLnO3ArhsSKCcPBV5V20+Hb6g+MUmIjkoeT30JbWrWG+NEBVW faHMGJUXHoAAYNdGCUFT3lGHJRuLgssRUgDryYN8OyuYCbGtOInYANScWj7rt+6T NJLGSixsmVAauAHZt5csGJbE+5V/XhjAcaKUcH1K3R5LMFZMZZWaA6IDAojjRdTY WepJBd1TF+HyU/3/FiXh9seLZHo7hl5GS81POgVvIzDvdxI5v6iPgRf1wDN1VFFT vSwSc6UBwsw/T1KtI9ECl2hHUvWvoJrCWSlzUGEJD07CURTUDIF7o35k60da0dG+ M+CwPkR+Lbe56mM9dFTnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegiedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeeludevtdeltdevvdeuudegueduieeitdeuuddvffeukeefjeffuddvteej veffvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Mar 2023 15:18:40 -0400 (EDT) Message-ID: <63e341b6-1b90-086b-8587-3617ac6340d6@bsdio.com> Date: Fri, 24 Mar 2023 13:18:39 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for *.makefile To: "Kinney, Michael D" , "devel@edk2.groups.io" , "Feng, Bob C" , "Gao, Liming" , "Chen, Christine" References: <20230324163216.2123281-1-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/24/23 12:46 PM, Kinney, Michael D wrote: > Should is be ".makefile" or perhaps use os.path.splitext() instead? Good point. I've updated the code to use os.path.splitext() instead, and change the check for 'Makefile' to be case-insensitive since some are which are missing the upper-case 'M': ./BaseTools/Source/C/VfrCompile/Pccts/support/genmk/makefile ./BaseTools/Source/C/VfrCompile/Pccts/support/rexpr/makefile ./BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile ./BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile I've sent out a v2 revision. -- Rebecca Cran