From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2C1D3D81105 for ; Wed, 22 Nov 2023 07:54:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=B7v7Ch35ByrZgxHTtJlRX7qcmUycgYIXfkkcMv/spPE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700639693; v=1; b=GsYnlqciSX8JJ30z5HYZxLW0Hce3HXk78Oo4i+JOlGpFCNjOdaBR5+AuyMho9mClptzOXLvq Drj7peoJeV2gjKFXRVFjm9XV9Ac3xwA2a3QtCbPORlFZJDuTa0zaceLu4YOr1liGwysiAgKkG9H KFrbpNa3R5+G0nFt6XmfN4F0= X-Received: by 127.0.0.2 with SMTP id gzeDYY7687511xTGmqd6BwqL; Tue, 21 Nov 2023 23:54:53 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.14532.1700639692685191633 for ; Tue, 21 Nov 2023 23:54:52 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C2C3E1595; Tue, 21 Nov 2023 23:55:38 -0800 (PST) X-Received: from [10.57.83.106] (unknown [10.57.83.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 48A103F73F; Tue, 21 Nov 2023 23:54:50 -0800 (PST) Message-ID: <63ef20eb-ba59-47e7-9864-7e65bb5b6fad@arm.com> Date: Wed, 22 Nov 2023 08:54:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add _PSD/_CPC/State Coordination Types macros To: "Ni, Ray" , "devel@edk2.groups.io" Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , "Kinney, Michael D" , "Gao, Liming" References: <20231121165007.1546858-1-pierre.gondois@arm.com> <20231121165007.1546858-4-pierre.gondois@arm.com> From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jiZFU7WkJ8fupdHS1TiwNWjgx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GsYnlqci; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none) Hello Ray, On 11/22/23 01:03, Ni, Ray wrote: > These ACPI methods were there since long ago. > Why do you only add the related definitions to 65.h? I have only added the definitions to the latest ACPI definition file (i.e. 6.5) because: - as it was not defined before, I assumed it was not used previously in edk2 and definitions for older ACPI spec versions might not be necessary (i.e. no need to use EFI_ACPI_6_4_xxx definition if EFI_ACPI_6_5_xxx is available) - this present patch-set only requires the latest definitions Do you want to have definitions for all spec. versions ? >=20 >> Cf. s8.3 Power, Performance, and Throttling State Dependencies >=20 > What does "Cf. s8.3" mean? I used s8.3 for 'section 8.3' (in the ACPI 6.5 spec), >=20 > Thanks, > Ray >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of >> PierreGondois >> Sent: Wednesday, November 22, 2023 12:50 AM >> To: devel@edk2.groups.io >> Cc: Ard Biesheuvel ; Leif Lindholm >> ; Sami Mujawar ; >> Kinney, Michael D ; Gao, Liming >> >> Subject: [edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add >> _PSD/_CPC/State Coordination Types macros >> >> Add macros for: >> - _PSD version >> - _CPC version >> - C-state/T-state/P-state Coordination Types >> >> These objects were present in previous ACPI specification version, >> but are only added to the latest availbable version (6.5). >> >> Signed-off-by: Pierre Gondois >> --- >> MdePkg/Include/IndustryStandard/Acpi65.h | 23 >> +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h >> b/MdePkg/Include/IndustryStandard/Acpi65.h >> index d79d0b2b5f9c..ec7c34e8e190 100644 >> --- a/MdePkg/Include/IndustryStandard/Acpi65.h >> +++ b/MdePkg/Include/IndustryStandard/Acpi65.h >> @@ -18,6 +18,29 @@ >> // >> >> #pragma pack(1) >> >> >> >> +/// >> >> +/// C-state/T-state/P-state Coordination Types >> >> +/// Cf. s8.3 Power, Performance, and Throttling State Dependencies >> >> +/// >> >> +#define EFI_ACPI_6_5_AML_STATE_COORD_TYPE_SW_ALL 0xFC >> >> +#define EFI_ACPI_6_5_AML_STATE_COORD_TYPE_SW_ANY 0xFD >> >> +#define EFI_ACPI_6_5_AML_STATE_COORD_TYPE_HW_ALL 0xFE >> >> + >> >> +/// >> >> +/// _PSD Revision >> >> +/// Cf. s8.4.5.5 _PSD (P-State Dependency) >> >> +/// >> >> +#define EFI_ACPI_6_5_AML_PSD_REVISION_V0 0 >> >> + >> >> +/// >> >> +/// _CPC Revision >> >> +/// Cf. s8.4.6.1 _CPC (Continuous Performance Control) >> >> +/// >> >> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V0 0 >> >> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V1 1 >> >> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V2 2 >> >> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V3 3 Also a personal note, I realize this doesn't really make sense to define versions like this, as there is only one revision for ACPI 6.5. This should be instead: #define EFI_ACPI_6_5_AML_CPC_REVISION 3 (same comment for EFI_ACPI_6_5_AML_PSD_REVISION_V0 above) Regards, Pierre -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111598): https://edk2.groups.io/g/devel/message/111598 Mute This Topic: https://groups.io/mt/102732018/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-