From: Laszlo Ersek <lersek@redhat.com>
To: KarunakarPoosapalli@Dell.com, liming.gao@intel.com,
edk2-devel@lists.01.org
Cc: Sumanth.Vidyadhara@dell.com, Sriramkumar.Raju@dell.com
Subject: Re: Conditional Compilation support in INF file
Date: Thu, 10 Jan 2019 13:54:25 +0100 [thread overview]
Message-ID: <63fd7d96-31f9-9a8d-6191-20c851ad54c3@redhat.com> (raw)
In-Reply-To: <3cd149b2ee7942dda2ebef04bd0f6977@BLRX13MDC432.AMER.DELL.COM>
On 01/10/19 07:03, KarunakarPoosapalli@Dell.com wrote:
> Hi All,
>
> I agree with providing the support like "FixedAtBuild PCD in INF". And we need to modify or provide support in BaseTools to support this feature.
>
> There are more use cases or flexibility to developer if we support Conditional compilation support in INF.
> As we're providing support in BaseTools for FixedAtBuild PCD support in INF, Is there any challenges or drawbacks in providing conditional compilation support in INF?
This is not for me to say authoritatively, but I'm unaware of any
specific use case that cannot be solved without this feature addition,
and any further complexity to BaseTools should be strongly justified.
"More convenient" is too vague for me, and the BaseTools code is already
hard to read and debug.
That's just my opinion, again.
Thanks
Laszlo
next prev parent reply other threads:[~2019-01-10 12:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 6:55 Conditional Compilation support in INF file KarunakarPoosapalli
2019-01-09 11:00 ` Laszlo Ersek
2019-01-09 12:42 ` Gao, Liming
2019-01-09 14:37 ` Laszlo Ersek
2019-01-10 6:03 ` KarunakarPoosapalli
2019-01-10 12:54 ` Laszlo Ersek [this message]
2019-01-10 15:48 ` Gao, Liming
2019-01-10 16:53 ` Kinney, Michael D
2019-01-11 6:33 ` KarunakarPoosapalli
2019-01-11 18:54 ` Kinney, Michael D
2019-01-15 15:10 ` Gao, Liming
2019-01-28 7:50 ` KarunakarPoosapalli
2019-01-28 8:36 ` KarunakarPoosapalli
2019-01-31 6:56 ` Gao, Liming
2019-01-31 16:26 ` stephano
2019-02-01 10:52 ` KarunakarPoosapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63fd7d96-31f9-9a8d-6191-20c851ad54c3@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox