From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 162DE2194D3AE for ; Thu, 10 Jan 2019 04:54:29 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8504FBB04; Thu, 10 Jan 2019 12:54:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-17.rdu2.redhat.com [10.10.121.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8ED001019632; Thu, 10 Jan 2019 12:54:26 +0000 (UTC) To: KarunakarPoosapalli@Dell.com, liming.gao@intel.com, edk2-devel@lists.01.org Cc: Sumanth.Vidyadhara@dell.com, Sriramkumar.Raju@dell.com References: <1a62f519f4b2466fb97c0dd7a81057e6@BLRX13MDC432.AMER.DELL.COM> <03c8ee0d-dca5-a7ca-b941-f45bd0fd6c38@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AE69B@SHSMSX152.ccr.corp.intel.com> <3cd149b2ee7942dda2ebef04bd0f6977@BLRX13MDC432.AMER.DELL.COM> From: Laszlo Ersek Message-ID: <63fd7d96-31f9-9a8d-6191-20c851ad54c3@redhat.com> Date: Thu, 10 Jan 2019 13:54:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3cd149b2ee7942dda2ebef04bd0f6977@BLRX13MDC432.AMER.DELL.COM> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 10 Jan 2019 12:54:28 +0000 (UTC) Subject: Re: Conditional Compilation support in INF file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 12:54:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/10/19 07:03, KarunakarPoosapalli@Dell.com wrote: > Hi All, > > I agree with providing the support like "FixedAtBuild PCD in INF". And we need to modify or provide support in BaseTools to support this feature. > > There are more use cases or flexibility to developer if we support Conditional compilation support in INF. > As we're providing support in BaseTools for FixedAtBuild PCD support in INF, Is there any challenges or drawbacks in providing conditional compilation support in INF? This is not for me to say authoritatively, but I'm unaware of any specific use case that cannot be solved without this feature addition, and any further complexity to BaseTools should be strongly justified. "More convenient" is too vague for me, and the BaseTools code is already hard to read and debug. That's just my opinion, again. Thanks Laszlo