From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, sami.mujawar@arm.com
Cc: ard.biesheuvel@arm.com, jiewen.yao@intel.com,
thomas.abraham@arm.com, Sughosh.Ganu@arm.com,
Matteo.Carlini@arm.com, Ben.Adderson@arm.com, nd@arm.com
Subject: Re: [edk2-devel] [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg
Date: Thu, 10 Dec 2020 10:27:41 +0100 [thread overview]
Message-ID: <642554ed-d19c-8565-2d80-fc347a4098fa@redhat.com> (raw)
In-Reply-To: <20201209184710.20912-1-sami.mujawar@arm.com>
Hi Sami,
On 12/09/20 19:46, Sami Mujawar wrote:
> The EDKII Core CI runs the ECC tool that checks for good coding
> practices and the coding standard. This patch series fixes the
> ECC errors reported in the StandaloneMmPkg and enables support
> for EDKII Core CI.
thanks for the CC. I totally don't have brain capacity for reviewing
this series. I'm really sorry. (I just thought it's better to be honest
about it.)
Thanks
Laszlo
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v1
>
> Sami Mujawar (25):
> StandaloneMmPkg: Add library header files to DEC
> StandaloneMmPkg: Add library files to DSC
> StandaloneMmPkg: Fix spell check reported errors
> StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher
> StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management
> StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 4002 in FwVol helper
> StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint
> StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore
> StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore
> StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint
> StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib
> StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint
> StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint
> StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core
> StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib
> StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint
> StandaloneMmPkg: Add EDK2 Core CI support
> .azurepipelines: Add StandaloneMmPkg to CI matrix
> .pytool: CI Settings to support StandaloneMmPkg
>
> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> .pytool/CISettings.py | 1 +
> .pytool/Readme.md | 2 +-
> StandaloneMmPkg/Core/Dependency.c | 6 +-
> StandaloneMmPkg/Core/Dispatcher.c | 49 ++++++-----
> StandaloneMmPkg/Core/FwVol.c | 36 +++++----
> StandaloneMmPkg/Core/Locate.c | 6 +-
> StandaloneMmPkg/Core/Mmi.c | 4 +-
> StandaloneMmPkg/Core/Pool.c | 6 +-
> StandaloneMmPkg/Core/StandaloneMmCore.c | 37 ++++++---
> StandaloneMmPkg/Core/StandaloneMmCore.h | 12 +--
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c | 56 ++++++++++---
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c | 34 ++++++--
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h | 31 ++++++-
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 9 +--
> StandaloneMmPkg/Include/Guid/MmCoreData.h | 6 +-
> StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h | 47 ++++++-----
> StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h | 4 +-
> StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h | 6 +-
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c | 6 +-
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c | 53 +++++++++++-
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 32 +++++---
> StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c | 6 +-
> StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf | 4 +-
> StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c | 10 +--
> StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c | 4 +-
> StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf | 4 +-
> StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 85 ++++++++++++++++++++
> StandaloneMmPkg/StandaloneMmPkg.dec | 20 ++++-
> StandaloneMmPkg/StandaloneMmPkg.dsc | 15 +++-
> 30 files changed, 439 insertions(+), 154 deletions(-)
> create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>
prev parent reply other threads:[~2020-12-10 9:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 18:46 [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 01/25] StandaloneMmPkg: Add library header files to DEC Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 02/25] StandaloneMmPkg: Add library files to DSC Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 03/25] StandaloneMmPkg: Fix spell check reported errors Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 04/25] StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 05/25] StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 06/25] StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 07/25] StandaloneMmPkg: Fix ECC error 4002 in FwVol helper Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 08/25] StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 09/25] StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 10/25] StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 11/25] StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 12/25] StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 13/25] StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint Sami Mujawar
2020-12-09 18:46 ` [PATCH v1 14/25] StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib Sami Mujawar
2020-12-09 18:47 ` [PATCH v1 15/25] StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint Sami Mujawar
2020-12-09 18:47 ` [PATCH v1 16/25] StandaloneMmPkg: Fix ECC error 9003 " Sami Mujawar
2020-12-09 18:47 ` [PATCH v1 17/25] StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu Sami Mujawar
2020-12-09 18:47 ` [PATCH v1 18/25] StandaloneMmPkg: Fix ECC error 9001 " Sami Mujawar
2020-12-09 18:47 ` [PATCH v1 19/25] StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core Sami Mujawar
2020-12-09 18:47 ` [PATCH v1 20/25] StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib Sami Mujawar
2020-12-09 18:47 ` [PATCH v1 21/25] StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu Sami Mujawar
2020-12-09 18:47 ` [PATCH v1 22/25] StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint Sami Mujawar
2020-12-09 18:47 ` [PATCH v1 23/25] StandaloneMmPkg: Add EDK2 Core CI support Sami Mujawar
2020-12-09 20:09 ` [EXTERNAL] [edk2-devel] " Bret Barkelew
2020-12-09 20:42 ` Sami Mujawar
2020-12-09 22:37 ` Yao, Jiewen
2020-12-09 18:47 ` [PATCH v1 24/25] .azurepipelines: Add StandaloneMmPkg to CI matrix Sami Mujawar
2020-12-09 20:10 ` [EXTERNAL] [edk2-devel] " Bret Barkelew
2020-12-09 20:42 ` Sami Mujawar
2020-12-09 18:47 ` [PATCH v1 25/25] .pytool: CI Settings to support StandaloneMmPkg Sami Mujawar
2020-12-09 20:10 ` [EXTERNAL] [edk2-devel] " Bret Barkelew
2020-12-09 22:31 ` [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg Yao, Jiewen
2020-12-10 9:27 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642554ed-d19c-8565-2d80-fc347a4098fa@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox