From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.10622.1607592487915319364 for ; Thu, 10 Dec 2020 01:28:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MTJ6S3oi; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607592487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CnJN5ElHqDXeqvllkPk7dzHP8+PrI6LSW7P34zPBARg=; b=MTJ6S3oi+G6gTUUflIM7KCaLj6S0TuvdzSvaN1ifXwu0A+aVkjw5NkHz+J4nHCHxBdo/XJ hAw2brgZa/zuoelL8jOz8uj6nzJ/qZARFQj0Mwq73TvZzwE2JXEC1JtRZ3FNpi1C82U15H X2tr5UyKuka/+54Nw4XSFiPmceDObB8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-589-ezkskyS-OMy-_S3bdRCfdw-1; Thu, 10 Dec 2020 04:28:03 -0500 X-MC-Unique: ezkskyS-OMy-_S3bdRCfdw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 41CA18D9856; Thu, 10 Dec 2020 09:27:45 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-52.ams2.redhat.com [10.36.113.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC56819746; Thu, 10 Dec 2020 09:27:42 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: ard.biesheuvel@arm.com, jiewen.yao@intel.com, thomas.abraham@arm.com, Sughosh.Ganu@arm.com, Matteo.Carlini@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20201209184710.20912-1-sami.mujawar@arm.com> From: "Laszlo Ersek" Message-ID: <642554ed-d19c-8565-2d80-fc347a4098fa@redhat.com> Date: Thu, 10 Dec 2020 10:27:41 +0100 MIME-Version: 1.0 In-Reply-To: <20201209184710.20912-1-sami.mujawar@arm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Sami, On 12/09/20 19:46, Sami Mujawar wrote: > The EDKII Core CI runs the ECC tool that checks for good coding > practices and the coding standard. This patch series fixes the > ECC errors reported in the StandaloneMmPkg and enables support > for EDKII Core CI. thanks for the CC. I totally don't have brain capacity for reviewing this series. I'm really sorry. (I just thought it's better to be honest about it.) Thanks Laszlo > > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v1 > > Sami Mujawar (25): > StandaloneMmPkg: Add library header files to DEC > StandaloneMmPkg: Add library files to DSC > StandaloneMmPkg: Fix spell check reported errors > StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher > StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management > StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 4002 in FwVol helper > StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint > StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore > StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore > StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint > StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib > StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint > StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint > StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core > StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib > StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint > StandaloneMmPkg: Add EDK2 Core CI support > .azurepipelines: Add StandaloneMmPkg to CI matrix > .pytool: CI Settings to support StandaloneMmPkg > > .azurepipelines/templates/pr-gate-build-job.yml | 2 +- > .pytool/CISettings.py | 1 + > .pytool/Readme.md | 2 +- > StandaloneMmPkg/Core/Dependency.c | 6 +- > StandaloneMmPkg/Core/Dispatcher.c | 49 ++++++----- > StandaloneMmPkg/Core/FwVol.c | 36 +++++---- > StandaloneMmPkg/Core/Locate.c | 6 +- > StandaloneMmPkg/Core/Mmi.c | 4 +- > StandaloneMmPkg/Core/Pool.c | 6 +- > StandaloneMmPkg/Core/StandaloneMmCore.c | 37 ++++++--- > StandaloneMmPkg/Core/StandaloneMmCore.h | 12 +-- > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c | 56 ++++++++++--- > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c | 34 ++++++-- > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h | 31 ++++++- > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 9 +-- > StandaloneMmPkg/Include/Guid/MmCoreData.h | 6 +- > StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h | 47 ++++++----- > StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h | 4 +- > StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h | 6 +- > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c | 6 +- > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c | 53 +++++++++++- > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 32 +++++--- > StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c | 6 +- > StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf | 4 +- > StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c | 10 +-- > StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c | 4 +- > StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf | 4 +- > StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 85 ++++++++++++++++++++ > StandaloneMmPkg/StandaloneMmPkg.dec | 20 ++++- > StandaloneMmPkg/StandaloneMmPkg.dsc | 15 +++- > 30 files changed, 439 insertions(+), 154 deletions(-) > create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml >