From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.44]) by mx.groups.io with SMTP id smtpd.web09.117.1634241547389118121 for ; Thu, 14 Oct 2021 12:59:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=bpKLHhhc; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.44, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GRXD0BnhtadjzH3v0GNvcn9cUKnj/bbySC+FLViKKZqEhAav6ZTvkzkz7hFqBmXuNh49QAn/DT9qK3K75WshYgBjAUvm/OWuie8RhbCCUsKf39rYGtYIaHShj3tqvD1OmGrdY5uPhjgis9Mp/zZn1sB2Q+UhNW5hUzgywwG/c2BtcrTCuwhRk1o7GZgfg4sXXXrAIS8fzke/+4BopF44S+2lWqg5N1V0XZGuYpy3uO34XNiYlQUZm6ZffI0ymecFujo+dE0aB2BOubBEAX8RGB0LrG7rTIFwmOXfA+5rlLq0C3FUWOd1NAdYWBbU6O66LkAMKWK7VRcubb7onrb9gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UgIV6GH0Rz10TPnT0I3oP7ZHUsubsNkjqNFRVXQTego=; b=h1a+vF6HOK8Jitwoj0yDU1DE0mbgF1J7K3TFfVyzOCUn8phvYv/EhpPMIxQintJRjnnxYK9YIuDiKpQv7pcu94daDNpJBrG0+PzxBBIMWfD37ynxwwD0HeiVMmjiknGgbMg8B40l6gJOLISdDc3oZP+PyaN/vg2u7QymYreceCcvyb4rwD/B5GMd4ekwJdnfsM4MqKOhfCnqyUFQA7y8E7utTUJuoPI02mfzjOtIbx69FgeX+eHZCVLjpOa1NEk0ZOuBexwHcA0rML/gFvT7g3OCVqCiMjmzExL2OsHo25FqGe0IxKVvt+iVkpAAL2u5kIPr2pGCY6Z6I/ns+bM9AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UgIV6GH0Rz10TPnT0I3oP7ZHUsubsNkjqNFRVXQTego=; b=bpKLHhhcIG8kXQ2eo7/1FC+pW8VBFCjnfc072FHRYn/3vlzdDWDOxqUsfNdk51TFngz+GNeAAXzACTGeki8KpwVPFTfxjSR2rFl4h60INAeIk/jcSjmDejh/x3Q6Ac8hbU0Rq/ntIt2z+koE3CpylfNprIjKTFvKtG0tgVijn8c= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2365.namprd12.prod.outlook.com (2603:10b6:802:2e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 19:59:05 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4587.026; Thu, 14 Oct 2021 19:59:05 +0000 Cc: brijesh.singh@amd.com, devel@edk2.groups.io, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael Roth Subject: Re: [PATCH v9 17/32] OvmfPkg/MemEncryptSevLib: add support to validate > 4GB memory in PEI phase To: Gerd Hoffmann References: <20211013165713.727815-1-brijesh.singh@amd.com> <20211013165713.727815-18-brijesh.singh@amd.com> <20211014083130.4h4iwupcwonclglv@sirius.home.kraxel.org> From: "Brijesh Singh" Message-ID: <643ac369-9d46-34e8-0993-612246f8d942@amd.com> Date: Thu, 14 Oct 2021 14:59:02 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20211014083130.4h4iwupcwonclglv@sirius.home.kraxel.org> X-ClientProxiedBy: SN7PR04CA0192.namprd04.prod.outlook.com (2603:10b6:806:126::17) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from Brijeshs-MacBook-Pro.local (165.204.78.25) by SN7PR04CA0192.namprd04.prod.outlook.com (2603:10b6:806:126::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Thu, 14 Oct 2021 19:59:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1ff6ae0-888b-45d8-938d-08d98f4d1373 X-MS-TrafficTypeDiagnostic: SN1PR12MB2365: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dxlnjph/AXHEMkPPtiVHl2f0NYLhKppmIbvcJFgNCrbH6Zbi/kFEeIO6R9/qtclDbPh1mc0z511Givq/EIBykc35+3NPkHbCzeQMp0GhzQ0yOHQ5wCatMgjVRuAcCadIms1dbVhrPR3Io59Airzu9B1KvMXgeGvAdf1ckHyeZshsb539IaKkRrNDAHiGQqo7445tpAh2lb9f61Isy4IhB8JTflR71aP3xgSjApJLxRWg6HZbb/Ee/7K2nJw1deW/9N7MT7zO+Hbl1YD4KGDJ9RWleyLqFuLAshpgo5G/vGOAaaVAcJ9bszIF90H+V6yDXi9K3WtFExdQLzE3Wy1LNZJmhvuZhHIPi4i2ZKYe8QMtf+ks+lxRe/izROGpyPikH0xLsjWPO1EkPL9FePqIrKAu4S0xKoMcCqo5b4Cph3PYfcj0c3VT+BxEgmt7HjvPpxKyLjzonxVu1oXv7w1y00+4zsirjQjGmEqXedJPsRUJ1yfVN2fxQ4altgnDLtNS3AGy8zt9s0zebzOm1IuQIcOrTQmMOMQrcQZXD6yL78QzfYSngjKJ9Hj6e1lRDff4hB+t5K/8avUcpzQ4GIYsAyzTL2oEHGxCCGxjmjwSJQNBKRyMLzDk7ViFUclb8eyvK9b4SrFl467EAg4QBBlACaqDi3GA4eGJKAs61k3Y4Hq0CHdHhaTQVqhElTz9biYx0N6JIswh9g4OZtvE/gLZXkVCLyTFNb1x3NeMhXBsuXVH7vpYVJIayUW2s2kbjogXsVfUKf8A3gMcvn+OsbJyWapf0LapN7MhLtxLFM5F0TzMj55D/Wy+BItmB/ozFvsSNrOrJkWKDYE0+8TlVKGBqQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(44832011)(36756003)(956004)(83380400001)(31696002)(2616005)(2906002)(4326008)(31686004)(6512007)(38100700002)(8936002)(508600001)(316002)(86362001)(66476007)(66946007)(66556008)(8676002)(966005)(6486002)(15650500001)(5660300002)(26005)(186003)(45080400002)(6506007)(53546011)(6916009)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWlxc2VmSW9lZXhJcDVZdGhQS1Z4aW1ISGVDRnNIcUlpVFVOdWxLUjh2RjFj?= =?utf-8?B?bWpVcFZCQUVnNlBROVYxWVZFT0h4UVhBR2ZxUy8vUkI0RVYyVmQ4c2UvMTk1?= =?utf-8?B?dk1JK0x2bysxa2JYYUZIYXMvQjVaMEw1OXM4Vkd5Y201S090MTYxWk5lSXZI?= =?utf-8?B?aWQ5NXcyT3J0ZDN0S1hhbGJJMjhVekp5UFhuK0VzTVdTZGtmbUp1cXZQaEZk?= =?utf-8?B?ak91VlpSYVlON1hIdFpISFFVTDV4SGJrbm9VYmVDUzBMa0JRZ1kydkJNWWpF?= =?utf-8?B?bWZ0dXk5dmR1UHlFbE5MMFhHa1REQzdKNTgzaTZTcWdyenBsRWwzd1JPQUgx?= =?utf-8?B?Yk51UkJZNEh2UUNuN3M5YzQwTGIvUEdFUStvb1oySHNFR1VGclZwY25RQTRD?= =?utf-8?B?ZG5GRktGRXlScEIwaEt4dUJaQlRrb21nM20wY09RUXdBbm1jcmR3OVNPVmVs?= =?utf-8?B?cEpFY05wcnlpNUNaZ3EySklsOGZ2WDVXTysyZzloZmhzcmlTdmduNEFkbWFj?= =?utf-8?B?Tk1EUDhkOEo1MVlueFJHemFDTEFJYmdOVFkvN0ZSenlmS3VWQUNMUUY5ZEdj?= =?utf-8?B?T1hvc2dSa3JrZDY2VUQrbWQ2SHdPU3dMWUpqdG9IUitUNHhrR1l3MXg3eTQr?= =?utf-8?B?TDByZlJSVVZHNENkcjVFeStrNXhHZjVWZkpqRDJOdVFMNXNxc0FIbmhncHJz?= =?utf-8?B?NEZ5NzlOTndUNzJEbUZvQ0svOVc0RW9aRTZsbW50cGxNSmdCT09wY0hvNHlw?= =?utf-8?B?NHY0MkMvQVFRSmJnMG4vZkRZZ3lJZ2VaSWFGdWpHTkp5V0JKUGhQYzR6RkRF?= =?utf-8?B?SGJveE5TOXRsbWVDZWx0ays3cFZWS0tjUWJHbCtRdlhkZlptZFBMYVdieG16?= =?utf-8?B?eTFzand5Y09yVENOdEt6UGVjdmk4OXowQmVxU1k3eHpQZlBVOFpROFhxWFN2?= =?utf-8?B?N0VwTlQxSXJWT2tiNkVtWmpra1JjT3krZlowdFVjSnF2Tmsxejk0WklIWDR6?= =?utf-8?B?eTlHTjNpdnFXM2lrczdIUVY5Vm5ub2hWclQ2elZ0Wk1NZW43VkMvZCt6TjFp?= =?utf-8?B?MmszNmFHY242NDJHcmlhWWk5VlpRSEZocUNlYkV6akluSEpQY3FVNyttQjJl?= =?utf-8?B?bVA1YjNPTklXR1F0ZmlmNnQzL01menBwaTNPeWlIaElJSVBFeHRZd0RQNDlT?= =?utf-8?B?UXJrL0srNWJmakpJWXF1MFJ3QVRKM1NXV3dmYzZMbU1QR1NnWENWeWxLd1lx?= =?utf-8?B?ajRMelNOVFptM3ZkYW5WbStDQVhsT3ZkWk5jQzV4WXBsUWJxaFVPbUxpMnNt?= =?utf-8?B?bGRrVTNhZDg2S3NnaEVNMTJQYzVPSlRsQ2wxdlZGUVIzcHBJTjFSazl2TzZU?= =?utf-8?B?clZBeEY2eUp1KzNZampsTDNuTnhoRVNxdEVjejlUb2s1VXZMS24vZEtGaTg5?= =?utf-8?B?ekY0MXlGSGJvK3djZmZ4ZDZ6ZG9IaDhhNVFZdkx5TjZneE93Ti9IVjJpTEhC?= =?utf-8?B?N0NseVM4T2E2N1RWeTFRQUJSNGZXejhiYnFNUFdVNEFQUmhIa3Axd1hxL1ZF?= =?utf-8?B?eExLNG9KVEkxaHNpTnZCVXI2SHZDZUxBaUhybllDVGZDYmdKbGIxblIwSFo2?= =?utf-8?B?RmhqVmo4dUZ2MHlUQ3kzb1dsWXZFVzFSVDBlc3hlYTFrZSt0Qk9XdDNmRlUw?= =?utf-8?B?eFQyajdITDA3WkdrQlVibnlFQjBsR2VFNzlvNWRGUzhwRjFyVGFaZFFOL0FJ?= =?utf-8?Q?6RpG5pdwqw+laOL7EiyFb1+kLcVXylaJAqohOIA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1ff6ae0-888b-45d8-938d-08d98f4d1373 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 19:59:05.2600 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YRMEBuiBC0A4lfW+0zQ3fEM06Wh1XmD6dl8gQTjlVdre48dAGGKI/WWMupGRxgE12w+HjIedhsdC6fyZVAkiUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2365 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 10/14/21 1:31 AM, Gerd Hoffmann wrote: > On Wed, Oct 13, 2021 at 11:56:58AM -0500, Brijesh Singh wrote: >> BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C82e310da29774221b2e908d98eed0a57%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637697971033546009%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=bWQoR678mAGBOGXn2UO9NdyeQocUZjj7TnpmzWp9m5U%3D&reserved=0 >> >> The initial page built during the SEC phase is used by the >> MemEncryptSevSnpValidateSystemRam() for the system RAM validation. The >> page validation process requires using the PVALIDATE instruction; the >> instruction accepts a virtual address of the memory region that needs >> to be validated. If hardware encounters a page table walk failure (due >> to page-not-present) then it raises #GP. >> >> The initial page table built in SEC phase address up to 4GB. Add an >> internal function to extend the page table to cover > 4GB. The function >> builds 1GB entries in the page table for access > 4GB. This will provide >> the support to call PVALIDATE instruction for the virtual address > >> 4GB in PEI phase. > I think I asked this before: This is likewise temporary until the > memory core can track page state and ovmf can handle lazy > acceptance/validation of memory > 4G in DXE phase, correct? Yes, this should go away with Lazy validation. Ah, my bad I missed your request to document it. I will add the comment. > Can you add a comment for that? > > The code looks good. > > take care, > Gerd >