[edk2-devel] [PATCH v2 0/4] TCG2 protocol clean up

[edk2-devel] [PATCH v2 0/4] TCG2 protocol clean up

[Stuart Yoder]

This patch series cleans up some issues found when building edk2-test with
a non-GCC compiler:
  -TPMT_HA struct had an error due to incorrect use of C flexible array member
  -compute struct member offsets using OFFSET_OF, which is not GCC specific
  -clean up of #pragma pack in one file
  -resolve type conversion warnings

Patches are in github here:
https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup

Version 2
  -add SM3 hash type to TPM2.h
  -resolve type conversion warnings

Stuart Yoder (4):
  uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
  uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
  uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
  uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings

 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h            |  3 +--
 uefi-sct/SctPkg/UEFI/Protocol/TCG2.h                                                         | 17 +++++++++++--
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c | 25 +++++++++-----------
 3 files changed, 27 insertions(+), 18 deletions(-)

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117882): https://edk2.groups.io/g/devel/message/117882
Mute This Topic: https://groups.io/mt/105558005/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 1/4] uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct

[Stuart Yoder]

The TPMT_HA struct defining event log hash algorithms was cut/pasted
from the TCG EFI Protocol specification which used a C struct
with a flexible array member as the last element.  This is incorrect
because TPMT_HA itself is used as an array element, and thus can't
be variable size.

Because the size of hash algorithms varies, this should have been
defined as a union of the sizes of supported hash algorithms.  This is
how is it done in the TPM Library specfication and in EDK2.

In addition, added the SM3 hash type to align with the TPM Library
spec.

Signed-off-by: Stuart Yoder <stuart.yoder@arm.com>
---
 uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/UEFI/Protocol/TCG2.h b/uefi-sct/SctPkg/UEFI/Protocol/TCG2.h
index a83a84c33134..01ef81be8793 100644
--- a/uefi-sct/SctPkg/UEFI/Protocol/TCG2.h
+++ b/uefi-sct/SctPkg/UEFI/Protocol/TCG2.h
@@ -50,7 +50,12 @@ Abstract:
 
 #define EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 0x00000002
 
-#define HASH_NUMBER 0x04
+#define HASH_NUMBER 0x05
+#define SHA1_DIGEST_SIZE    20
+#define SHA256_DIGEST_SIZE  32
+#define SHA384_DIGEST_SIZE  48
+#define SHA512_DIGEST_SIZE  64
+#define SM3_256_DIGEST_SIZE 32
 
 typedef struct _EFI_TCG2_PROTOCOL EFI_TCG2_PROTOCOL;
 
@@ -117,9 +122,17 @@ typedef struct tdEFI_TCG2_EVENT {
   UINT8 Event[];
 } EFI_TCG2_EVENT;
 
+typedef union {
+  UINT8 sha1[SHA1_DIGEST_SIZE];
+  UINT8 sha256[SHA256_DIGEST_SIZE];
+  UINT8 sm3_256[SM3_256_DIGEST_SIZE];
+  UINT8 sha384[SHA384_DIGEST_SIZE];
+  UINT8 sha512[SHA512_DIGEST_SIZE];
+} TPMU_HA;
+
 typedef struct {
   UINT16     hashAlg;
-  UINT8      digest[];
+  TPMU_HA    digest;
 } TPMT_HA;
 
 typedef struct tdTPML_DIGEST_VALUES {
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117883): https://edk2.groups.io/g/devel/message/117883
Mute This Topic: https://groups.io/mt/105558006/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 2/4] uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets

[Stuart Yoder]

Use compiler-independent OFFSET_OF macro defined from Base.h instead
of the GCC specific __builtin_offsetof

Signed-off-by: Stuart Yoder <stuart.yoder@arm.com>
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
index 0122458a89fe..cba1ec1b9e2c 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
@@ -25,8 +25,7 @@ Abstract:
 --*/
 
 #include "TCG2ProtocolBBTest.h"
-
-#define offsetof(st, m) __builtin_offsetof(st, m)
+#include <Base.h>
 
 /**
  *  @brief Entrypoint for GetCapability() Function Test.
@@ -475,7 +474,7 @@ BBTestGetCapabilityConformanceTestCheckpoint4 (
 
   // set size of struct to be up to and including the ManufacturerID
   // (this acts like a client with a 1.0 version of the struct)
-  BootServiceCap.Size = offsetof(EFI_TCG2_BOOT_SERVICE_CAPABILITY, NumberOfPcrBanks);
+  BootServiceCap.Size = OFFSET_OF(EFI_TCG2_BOOT_SERVICE_CAPABILITY, NumberOfPcrBanks);
 
   Status = TCG2->GetCapability (
                            TCG2,
@@ -494,7 +493,7 @@ BBTestGetCapabilityConformanceTestCheckpoint4 (
   }
 
   // Verify returned Size equals the size of EFI_TCG2_BOOT_SERVICE_CAPABILITY up to and including the ManufacturerID field.
-  if (BootServiceCap.Size != offsetof(EFI_TCG2_BOOT_SERVICE_CAPABILITY, NumberOfPcrBanks)) {
+  if (BootServiceCap.Size != OFFSET_OF(EFI_TCG2_BOOT_SERVICE_CAPABILITY, NumberOfPcrBanks)) {
     StandardLib->RecordMessage (
                      StandardLib,
                      EFI_VERBOSE_LEVEL_DEFAULT,
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117884): https://edk2.groups.io/g/devel/message/117884
Mute This Topic: https://groups.io/mt/105558007/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 3/4] uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup

[Stuart Yoder]

Fix compiler warning by adding #pragma pack() to close a pragma
section.  Also delete extraneous #pragma pack(1).

Signed-off-by: Stuart Yoder <stuart.yoder@arm.com>
Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
index deba13f21804..95307b7fa50f 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
@@ -79,7 +79,6 @@ typedef struct {
   UINT8  buffer[TEST_STRING_LEN];
 } TPM2B_MAX_BUFFER;
 
-#pragma pack(1)
 // TPM2B_DIGEST as defined in Table 73 of TPM Library Spec Part 2: Structures
 typedef struct {
   UINT16 size;
@@ -110,7 +109,7 @@ typedef struct {
   TPM2B_DIGEST data;
   TPMT_TK_HASHCHECK validation;
 } TPM2_HASH_RESPONSE;
-#pragma
+#pragma pack()
 
 EFI_STATUS
 EFIAPI
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117885): https://edk2.groups.io/g/devel/message/117885
Mute This Topic: https://groups.io/mt/105558008/7686176
Mute #pragma:https://edk2.groups.io/g/devel/mutehashtag/pragma
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 4/4] uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings

[Stuart Yoder]

The VS2015x86 build encountered errors due to type conversion
warnings.  Resolve these by adding casts and refactoring.

Signed-off-by: Stuart Yoder <stuart.yoder@arm.com>
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
index cba1ec1b9e2c..2a3cd6aa4f23 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
@@ -639,7 +639,7 @@ BBTestHashLogExtendEventConformanceTestCheckpoint1 (
   EFI_TCG2_EVENT                        *EfiTcgEvent;
   const CHAR8                           *EventData = "TCG2 Protocol Test";
   const CHAR8                           *Str = "The quick brown fox jumps over the lazy dog";
-  UINT32                                EfiTcgEventSize = sizeof(EFI_TCG2_EVENT) + SctAsciiStrLen(EventData);
+  UINT32                                EfiTcgEventSize = (UINT32)(sizeof(EFI_TCG2_EVENT) + SctAsciiStrLen(EventData));
 
   DataToHash =  (EFI_PHYSICAL_ADDRESS)Str;
   DataToHashLen = SctAsciiStrLen(Str);
@@ -654,7 +654,7 @@ BBTestHashLogExtendEventConformanceTestCheckpoint1 (
   EfiTcgEvent->Header.HeaderVersion = 1;
   EfiTcgEvent->Header.EventType = EV_POST_CODE;
   EfiTcgEvent->Header.PCRIndex = 16;
-  EfiTcgEvent->Size = EfiTcgEvent->Header.HeaderSize + SctAsciiStrLen(EventData);
+  EfiTcgEvent->Size = EfiTcgEvent->Header.HeaderSize + (UINT32)SctAsciiStrLen(EventData);
 
   // Ensure HashLogExtendEvent returns Invalid Parameter when passing in NULL DataToHash pointer
   // EFI Protocol Spec Section 6.6.5 #1
@@ -710,7 +710,7 @@ BBTestHashLogExtendEventConformanceTestCheckpoint1 (
 
   // Ensure HashLogExtendEvent returns Invalid Parameter when passed in EventSize < HeaderSize + sizeof(UINT32)
   // EFI Protocol Spec Section 6.6.5 #2
-  EfiTcgEvent->Size = EfiTcgEvent->Header.HeaderSize + sizeof(UINT32) - 1;
+  EfiTcgEvent->Size = EfiTcgEvent->Header.HeaderSize + (UINT32)sizeof(UINT32) - 1;
 
   Status = TCG2->HashLogExtendEvent (
                            TCG2,
@@ -739,7 +739,7 @@ BBTestHashLogExtendEventConformanceTestCheckpoint1 (
   // Ensure HashLogExtendEvent returns Invalid Parameter when passing in PCR Index > 23
   // EFI Protocol Spec Section 6.6.5 #3
   EfiTcgEvent->Header.PCRIndex = 24;
-  EfiTcgEvent->Size = EfiTcgEvent->Header.HeaderSize + SctAsciiStrLen(EventData);
+  EfiTcgEvent->Size = EfiTcgEvent->Header.HeaderSize + (UINT32)SctAsciiStrLen(EventData);
 
   Status = TCG2->HashLogExtendEvent (
                            TCG2,
@@ -782,7 +782,7 @@ BBTestHashLogExtendEventConformanceTestCheckpoint2 (
   UINT64                                DataToHashLen;
   const CHAR8                           *Str = "The quick brown fox jumps over the lazy dog";
   const CHAR8                           *EventData = "TCG2 Protocol Test";
-  UINT32 EfiTcgEventSize = sizeof(EFI_TCG2_EVENT) + SctAsciiStrLen(EventData);
+  UINT32 EfiTcgEventSize = (UINT32)(sizeof(EFI_TCG2_EVENT) + SctAsciiStrLen(EventData));
 
   DataToHash = (EFI_PHYSICAL_ADDRESS)Str;
   DataToHashLen = SctAsciiStrLen(Str);
@@ -797,7 +797,7 @@ BBTestHashLogExtendEventConformanceTestCheckpoint2 (
   EfiTcgEvent->Header.HeaderVersion = 1;
   EfiTcgEvent->Header.EventType = EV_POST_CODE;
   EfiTcgEvent->Header.PCRIndex = 16;
-  EfiTcgEvent->Size = EfiTcgEvent->Header.HeaderSize + SctAsciiStrLen(EventData);
+  EfiTcgEvent->Size = EfiTcgEvent->Header.HeaderSize + (UINT32)SctAsciiStrLen(EventData);
 
   // Perform HashLogExtendEvent over test buffer to PCR 16
   Status = TCG2->HashLogExtendEvent (
@@ -991,9 +991,7 @@ BBTestGetEventLogConformanceTestCheckpoint2 (
   }
 
   // Verify EventLog Signature
-  Status = SctCompareMem(EventLogHeaderSpecEvent->signature, signature, sizeof(signature));
-
-  if (Status != EFI_SUCCESS) {
+  if (SctCompareMem(EventLogHeaderSpecEvent->signature, signature, sizeof(signature) != 0)) {
     StandardLib->RecordMessage (
                      StandardLib,
                      EFI_VERBOSE_LEVEL_DEFAULT,
@@ -1076,7 +1074,7 @@ BBTestSubmitCommandConformanceTestCheckpoint1 (
   CommandInput.Tag = SctSwapBytes16(ST_NO_SESSIONS);
   CommandInput.CommandSize = SctSwapBytes32(sizeof(TPM2_HASH_COMMAND));
   CommandInput.CommandCode = SctSwapBytes32(TPM_CC_Hash);
-  CommandInput.data.size = SctSwapBytes16(SctAsciiStrLen(Str));
+  CommandInput.data.size = SctSwapBytes16((UINT16)SctAsciiStrLen(Str));
   SctAsciiStrCpy((CHAR8 *)CommandInput.data.buffer, Str);
   CommandInput.hashAlg = SctSwapBytes16(TPM_ALG_SHA256);
   CommandInput.hierarchy = SctSwapBytes32(TPM_RH_NULL);
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117886): https://edk2.groups.io/g/devel/message/117886
Mute This Topic: https://groups.io/mt/105558010/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] TCG2 protocol clean up

[Heinrich Schuchardt]

On 4/16/24 16:53, Stuart Yoder wrote:
> This patch series cleans up some issues found when building edk2-test with
> a non-GCC compiler:
>    -TPMT_HA struct had an error due to incorrect use of C flexible array member
>    -compute struct member offsets using OFFSET_OF, which is not GCC specific
>    -clean up of #pragma pack in one file
>    -resolve type conversion warnings
> 
> Patches are in github here:
> https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
> 
> Version 2
>    -add SM3 hash type to TPM2.h
>    -resolve type conversion warnings
> 
> Stuart Yoder (4):
>    uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
>    uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
>    uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
>    uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
> 
>   uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h            |  3 +--
>   uefi-sct/SctPkg/UEFI/Protocol/TCG2.h                                                         | 17 +++++++++++--
>   uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c | 25 +++++++++-----------
>   3 files changed, 27 insertions(+), 18 deletions(-)
> 

Hello Edhaya,

Will we have another release candidate with these patches included?

Best regards

Heinrich



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118101): https://edk2.groups.io/g/devel/message/118101
Mute This Topic: https://groups.io/mt/105558005/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] TCG2 protocol clean up

[G Edhaya Chandran]

Hi Heinrich,

   Yes. A new release candidate shall be published after review and upstream of the patches.
Will further send an update.

With Warm Regards,
Edhay


> -----Original Message-----
> From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Sent: Tuesday, April 23, 2024 12:46 AM
> To: G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Alex_Fox@phoenix.com; David_Wright@phoenix.com; lichao@loongson.cn;
> Stuart Yoder <Stuart.Yoder@arm.com>; devel@edk2.groups.io;
> gaojie@byosoft.com.cn
> Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
>
> On 4/16/24 16:53, Stuart Yoder wrote:
> > This patch series cleans up some issues found when building edk2-test
> > with a non-GCC compiler:
> >    -TPMT_HA struct had an error due to incorrect use of C flexible array
> member
> >    -compute struct member offsets using OFFSET_OF, which is not GCC specific
> >    -clean up of #pragma pack in one file
> >    -resolve type conversion warnings
> >
> > Patches are in github here:
> > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
> >
> > Version 2
> >    -add SM3 hash type to TPM2.h
> >    -resolve type conversion warnings
> >
> > Stuart Yoder (4):
> >    uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
> >    uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
> >    uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
> >    uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
> >
> >   uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
> st.h            |  3 +--
> >   uefi-sct/SctPkg/UEFI/Protocol/TCG2.h                                                         | 17
> +++++++++++--
> >   uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
> stConformance.c | 25 +++++++++-----------
> >   3 files changed, 27 insertions(+), 18 deletions(-)
> >
>
> Hello Edhaya,
>
> Will we have another release candidate with these patches included?
>
> Best regards
>
> Heinrich

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118133): https://edk2.groups.io/g/devel/message/118133
Mute This Topic: https://groups.io/mt/105558005/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 1/4] uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118199): https://edk2.groups.io/g/devel/message/118199
Mute This Topic: https://groups.io/mt/105558006/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 842 bytes --]

Re: [edk2-devel] [PATCH v2 2/4] uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118200): https://edk2.groups.io/g/devel/message/118200
Mute This Topic: https://groups.io/mt/105558007/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 842 bytes --]

Re: [edk2-devel] [PATCH v2 3/4] uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118201): https://edk2.groups.io/g/devel/message/118201
Mute This Topic: https://groups.io/mt/105558008/7686176
Mute #pragma:https://edk2.groups.io/g/devel/mutehashtag/pragma
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 956 bytes --]

Re: [edk2-devel] [PATCH v2 4/4] uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118202): https://edk2.groups.io/g/devel/message/118202
Mute This Topic: https://groups.io/mt/105558010/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 842 bytes --]

Re: [edk2-devel] [PATCH v2 1/4] uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

Hi Stuart,

The below values are
+#define SHA1_DIGEST_SIZE 20
+#define SHA256_DIGEST_SIZE 32
+#define SHA384_DIGEST_SIZE 48
+#define SHA512_DIGEST_SIZE 64
+#define SM3_256_DIGEST_SIZE 32

already defined here:
edk2-master\MdePkg\Include\IndustryStandard\Tpm20.h
Can this file be included.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118208): https://edk2.groups.io/g/devel/message/118208
Mute This Topic: https://groups.io/mt/105558006/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1579 bytes --]

Re: [edk2-devel] [PATCH v2 1/4] uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Update: We have the struct itself define here:
https://github.com/tianocore/edk2/blob/master/MdePkg/Include/IndustryStandard/Tpm20.h#L904


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118209): https://edk2.groups.io/g/devel/message/118209
Mute This Topic: https://groups.io/mt/105558006/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 922 bytes --]

Re: [edk2-devel] [PATCH v2 1/4] uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct

[Stuart Yoder]

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

Hi Edhaya,

Yes, we could get rid of the TPM 2.0 definitions and include the MdePkg 
definition, but it will require rework of TCG2.h to remove duplicate 
definitions.

But, what is the general of philosophy of what source code edk2-test 
should include from edk2?  Since the purpose of edk2-test is to test the 
firmware, for some things it seems better for edk2-test to have it's own 
private  definitions.  Otherwise, if there was an edk2 bug in something 
like a protocol definition, and if edk2-test included the same .h file, 
then the bug may never be discovered.  It's better if edk2-test defines 
it's own structs based on the specifications.  That way it is 
independent of the firmware and it's a better test.

In the case of Tpm20.h, that is probably not the case as those are TPM 
definitions, not protocol definitions.

Do you want me to try to get rid of the TPM definitions and use Tpm20.h 
for this patch series?  Or, as a separate patch?

Thanks,

Stuart

On 4/24/24 6:36 AM, G Edhaya Chandran via groups.io wrote:
> Update: We have the struct itself define here:
> https://github.com/tianocore/edk2/blob/master/MdePkg/Include/IndustryStandard/Tpm20.h#L904 
>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118214): https://edk2.groups.io/g/devel/message/118214
Mute This Topic: https://groups.io/mt/105558006/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 2673 bytes --]

Re: [edk2-devel] [PATCH v2 1/4] uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

Hi Stuart,
Thank you for the update. I understand the rationale.
It is also in-line with the independent protocol interface definition in edk2-test.
Will approve the patch.

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118265): https://edk2.groups.io/g/devel/message/118265
Mute This Topic: https://groups.io/mt/105558006/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1048 bytes --]

[edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 4054 bytes --]

Hi All,

   A new release candidate is published after upstreaming Stuart's commits on build cleanup.
https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405

The updates since the old tag are the following commits in the patch series:
[PATCH v2 0/4] TCG2 protocol clean up (groups.io)<https://edk2.groups.io/g/devel/message/117882?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Cstuart+yoder%2C20%2C2%2C0%2C105558005>

The release candidate may be used for any further testing.

With Warm Regards,
Edhay



> -----Original Message-----
> From: G Edhaya Chandran
> Sent: Tuesday, April 23, 2024 4:52 AM
> To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Cc: Alex_Fox@phoenix.com; David_Wright@phoenix.com;
> lichao@loongson.cn; Stuart Yoder <Stuart.Yoder@arm.com>;
> devel@edk2.groups.io; gaojie@byosoft.com.cn
> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi Heinrich,
>
>    Yes. A new release candidate shall be published after review and upstream
> of the patches.
> Will further send an update.
>
> With Warm Regards,
> Edhay
>
>
> > -----Original Message-----
> > From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
> > Sent: Tuesday, April 23, 2024 12:46 AM
> > To: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>>
> > Cc: Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>; David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>;
> > lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>;
> > devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
> > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
> >
> > On 4/16/24 16:53, Stuart Yoder wrote:
> > > This patch series cleans up some issues found when building
> > > edk2-test with a non-GCC compiler:
> > >    -TPMT_HA struct had an error due to incorrect use of C flexible
> > > array
> > member
> > >    -compute struct member offsets using OFFSET_OF, which is not GCC
> specific
> > >    -clean up of #pragma pack in one file
> > >    -resolve type conversion warnings
> > >
> > > Patches are in github here:
> > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
> > >
> > > Version 2
> > >    -add SM3 hash type to TPM2.h
> > >    -resolve type conversion warnings
> > >
> > > Stuart Yoder (4):
> > >    uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
> > >    uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
> > >    uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
> > >    uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
> > >
> > >   uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
> > st.h            |  3 +--
> > >   uefi-sct/SctPkg/UEFI/Protocol/TCG2.h                                                         | 17
> > +++++++++++--
> > >   uefi-
> > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
> > Te stConformance.c | 25 +++++++++-----------
> > >   3 files changed, 27 insertions(+), 18 deletions(-)
> > >
> >
> > Hello Edhaya,
> >
> > Will we have another release candidate with these patches included?
> >
> > Best regards
> >
> > Heinrich

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118565): https://edk2.groups.io/g/devel/message/118565
Mute This Topic: https://groups.io/mt/105898910/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 7285 bytes --]

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

[Heinrich Schuchardt]

On 5/4/24 01:47, G Edhaya Chandran wrote:
> Hi All,
>     A new release candidate is published after upstreaming Stuart's 
> commits on build cleanup.
> _https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405_ 
> <https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405>
> The updates since the old tag are the following commits in the patch 
> series:
> _[PATCH v2 0/4] TCG2 protocol clean up (groups.io)_ 
> <https://edk2.groups.io/g/devel/message/117882?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Cstuart+yoder%2C20%2C2%2C0%2C105558005>
> The release candidate may be used for any further testing.
> With Warm Regards,
> Edhay

Hello Edhaya,

I am not allowed to create the folder structure for uploading the test 
results.

Could you, please, create it and inform us.

Best regards

Heinrich


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118576): https://edk2.groups.io/g/devel/message/118576
Mute This Topic: https://groups.io/mt/105929926/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

[G Edhaya Chandran]

Hi Heinrich,

   The folder structure for edk2-test-rc2_202405 is created:
https://members.uefi.org/wg/utwg/document/folder/128

With Warm Regards,
Edhay


> -----Original Message-----
> From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Sent: Sunday, May 5, 2024 5:22 PM
> To: G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Alex_Fox@phoenix.com; David_Wright@phoenix.com;
> lichao@loongson.cn; Stuart Yoder <Stuart.Yoder@arm.com>;
> devel@edk2.groups.io; gaojie@byosoft.com.cn
> Subject: Re: edk2-test Release candidate 2: edk2-test-rc2_202405
>
> On 5/4/24 01:47, G Edhaya Chandran wrote:
> > Hi All,
> >     A new release candidate is published after upstreaming Stuart's
> > commits on build cleanup.
> > _https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405_
> > <https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405>
> > The updates since the old tag are the following commits in the patch
> > series:
> > _[PATCH v2 0/4] TCG2 protocol clean up (groups.io)_
> >
> <https://edk2.groups.io/g/devel/message/117882?p=%2C%2C%2C20%2C0%2
> C0%2
> >
> C0%3A%3Arecentpostdate%2Fsticky%2C%2Cstuart+yoder%2C20%2C2%2C0%
> 2C10555
> > 8005> The release candidate may be used for any further testing.
> > With Warm Regards,
> > Edhay
>
> Hello Edhaya,
>
> I am not allowed to create the folder structure for uploading the test results.
>
> Could you, please, create it and inform us.
>
> Best regards
>
> Heinrich
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118608): https://edk2.groups.io/g/devel/message/118608
Mute This Topic: https://groups.io/mt/105929926/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

[David Wright]

[-- Attachment #1.1: Type: text/plain, Size: 5462 bytes --]

Hi all,

Phoenix has completed testing on edk2-test-rc2_202405

Results have been uploaded to their respective folders.

[cid:image001.png@01DAA213.C980F100]


Thanks,
David Wright
QA Team Leader
David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>
503-730-4537 Tel
[cid:image002.jpg@01DAA213.C980F100]
www.phoenix.com<http://www.phoenix.com/>
THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN ERROR, PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE OR REPLY EMAIL, AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.




From: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Sent: Friday, May 3, 2024 4:47 PM
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Alex Fox <Alex_Fox@phoenix.com>; David Wright <David_Wright@phoenix.com>; lichao@loongson.cn; Stuart Yoder <Stuart.Yoder@arm.com>; devel@edk2.groups.io; gaojie@byosoft.com.cn
Subject: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up


[Caution, this message was sent from an external sender.]

Hi All,

   A new release candidate is published after upstreaming Stuart's commits on build cleanup.
https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405

The updates since the old tag are the following commits in the patch series:
[PATCH v2 0/4] TCG2 protocol clean up (groups.io)<https://edk2.groups.io/g/devel/message/117882?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Cstuart+yoder%2C20%2C2%2C0%2C105558005>

The release candidate may be used for any further testing.

With Warm Regards,
Edhay



> -----Original Message-----
> From: G Edhaya Chandran
> Sent: Tuesday, April 23, 2024 4:52 AM
> To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
> Cc: Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>; David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>;
> lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>;
> devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi Heinrich,
>
>    Yes. A new release candidate shall be published after review and upstream
> of the patches.
> Will further send an update.
>
> With Warm Regards,
> Edhay
>
>
> > -----Original Message-----
> > From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
> > Sent: Tuesday, April 23, 2024 12:46 AM
> > To: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>>
> > Cc: Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>; David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>;
> > lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>;
> > devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
> > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
> >
> > On 4/16/24 16:53, Stuart Yoder wrote:
> > > This patch series cleans up some issues found when building
> > > edk2-test with a non-GCC compiler:
> > >    -TPMT_HA struct had an error due to incorrect use of C flexible
> > > array
> > member
> > >    -compute struct member offsets using OFFSET_OF, which is not GCC
> specific
> > >    -clean up of #pragma pack in one file
> > >    -resolve type conversion warnings
> > >
> > > Patches are in github here:
> > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
> > >
> > > Version 2
> > >    -add SM3 hash type to TPM2.h
> > >    -resolve type conversion warnings
> > >
> > > Stuart Yoder (4):
> > >    uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
> > >    uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
> > >    uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
> > >    uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
> > >
> > >   uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
> > st.h            |  3 +--
> > >   uefi-sct/SctPkg/UEFI/Protocol/TCG2.h                                                         | 17
> > +++++++++++--
> > >   uefi-
> > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
> > Te stConformance.c | 25 +++++++++-----------
> > >   3 files changed, 27 insertions(+), 18 deletions(-)
> > >
> >
> > Hello Edhaya,
> >
> > Will we have another release candidate with these patches included?
> >
> > Best regards
> >
> > Heinrich

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118776): https://edk2.groups.io/g/devel/message/118776
Mute This Topic: https://groups.io/mt/105898910/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #1.2: Type: text/html, Size: 15777 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 5129 bytes --]

[-- Attachment #3: image002.jpg --]
[-- Type: image/jpeg, Size: 2777 bytes --]

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

[G Edhaya Chandran]

[-- Attachment #1.1: Type: text/plain, Size: 6563 bytes --]

Thank you, David.
The results are well received.

With Warm Regards,
Edhay


From: David Wright <David_Wright@phoenix.com>
Sent: Thursday, May 9, 2024 3:23 PM
To: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Alex Fox <Alex_Fox@phoenix.com>; lichao@loongson.cn; Stuart Yoder <Stuart.Yoder@arm.com>; devel@edk2.groups.io; gaojie@byosoft.com.cn
Subject: RE: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

Hi all,

Phoenix has completed testing on edk2-test-rc2_202405

Results have been uploaded to their respective folders.

[cid:image001.png@01DAA259.ED4F57C0]


Thanks,
David Wright
QA Team Leader
David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>
503-730-4537 Tel
[cid:image002.jpg@01DAA259.ED4F57C0]
www.phoenix.com<http://www.phoenix.com/>
THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN ERROR, PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE OR REPLY EMAIL, AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.




From: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>>
Sent: Friday, May 3, 2024 4:47 PM
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
Cc: Alex Fox <Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>>; David Wright <David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>>; lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
Subject: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up


[Caution, this message was sent from an external sender.]

Hi All,

   A new release candidate is published after upstreaming Stuart's commits on build cleanup.
https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405

The updates since the old tag are the following commits in the patch series:
[PATCH v2 0/4] TCG2 protocol clean up (groups.io)<https://edk2.groups.io/g/devel/message/117882?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Cstuart+yoder%2C20%2C2%2C0%2C105558005>

The release candidate may be used for any further testing.

With Warm Regards,
Edhay



> -----Original Message-----
> From: G Edhaya Chandran
> Sent: Tuesday, April 23, 2024 4:52 AM
> To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
> Cc: Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>; David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>;
> lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>;
> devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi Heinrich,
>
>    Yes. A new release candidate shall be published after review and upstream
> of the patches.
> Will further send an update.
>
> With Warm Regards,
> Edhay
>
>
> > -----Original Message-----
> > From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
> > Sent: Tuesday, April 23, 2024 12:46 AM
> > To: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>>
> > Cc: Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>; David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>;
> > lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>;
> > devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
> > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
> >
> > On 4/16/24 16:53, Stuart Yoder wrote:
> > > This patch series cleans up some issues found when building
> > > edk2-test with a non-GCC compiler:
> > >    -TPMT_HA struct had an error due to incorrect use of C flexible
> > > array
> > member
> > >    -compute struct member offsets using OFFSET_OF, which is not GCC
> specific
> > >    -clean up of #pragma pack in one file
> > >    -resolve type conversion warnings
> > >
> > > Patches are in github here:
> > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
> > >
> > > Version 2
> > >    -add SM3 hash type to TPM2.h
> > >    -resolve type conversion warnings
> > >
> > > Stuart Yoder (4):
> > >    uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
> > >    uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
> > >    uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
> > >    uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
> > >
> > >   uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
> > st.h            |  3 +--
> > >   uefi-sct/SctPkg/UEFI/Protocol/TCG2.h                                                         | 17
> > +++++++++++--
> > >   uefi-
> > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
> > Te stConformance.c | 25 +++++++++-----------
> > >   3 files changed, 27 insertions(+), 18 deletions(-)
> > >
> >
> > Hello Edhaya,
> >
> > Will we have another release candidate with these patches included?
> >
> > Best regards
> >
> > Heinrich

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118783): https://edk2.groups.io/g/devel/message/118783
Mute This Topic: https://groups.io/mt/105898910/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #1.2: Type: text/html, Size: 20472 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 5129 bytes --]

[-- Attachment #3: image002.jpg --]
[-- Type: image/jpeg, Size: 2777 bytes --]

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

[Chao Li]

[-- Attachment #1: Type: text/plain, Size: 6533 bytes --]

Hi Edhay,

Do I need to retest based on the edk2-test-rc2_202405 tag?


Thanks,
Chao
On 2024/5/10 10:43, G Edhaya Chandran wrote:
>
> Thank you, David.
>
> The results are well received.
>
> With Warm Regards,
> Edhay
>
> *From:*David Wright <David_Wright@phoenix.com>
> *Sent:* Thursday, May 9, 2024 3:23 PM
> *To:* G Edhaya Chandran <Edhaya.Chandran@arm.com>; Heinrich Schuchardt 
> <heinrich.schuchardt@canonical.com>
> *Cc:* Alex Fox <Alex_Fox@phoenix.com>; lichao@loongson.cn; Stuart 
> Yoder <Stuart.Yoder@arm.com>; devel@edk2.groups.io; gaojie@byosoft.com.cn
> *Subject:* RE: edk2-test Release candidate 2: edk2-test-rc2_202405 // 
> RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi all,
>
> Phoenix has completed testing on *edk2-test-rc2_202405*
>
> Results have been uploaded to their respective folders.
>
> Thanks,
>
> David Wright
> QA Team Leader
>
> David_Wright@phoenix.com
>
> 503-730-4537 Tel
>
> www.phoenix.com 
> <https://mailgw.loongson.cn/linkserver?dest=http%3A%2F%2Fwww.phoenix.com%2F&tid=_____8Dx2enliT1mLVoKAA--.14549S3&rcpt=lichao@loongson.cn&ifnotice=1&rindex=0>
>
>
> THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE 
> INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS 
> STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN ERROR, 
> PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE OR REPLY EMAIL, AND 
> IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.
>
> *From:*G Edhaya Chandran <Edhaya.Chandran@arm.com>
> *Sent:* Friday, May 3, 2024 4:47 PM
> *To:* Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> *Cc:* Alex Fox <Alex_Fox@phoenix.com>; David Wright 
> <David_Wright@phoenix.com>; lichao@loongson.cn; Stuart Yoder 
> <Stuart.Yoder@arm.com>; devel@edk2.groups.io; gaojie@byosoft.com.cn
> *Subject:* edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: 
> [PATCH v2 0/4] TCG2 protocol clean up
>
> [Caution, this message was sent from an external sender.]
>
> Hi All,
>
>    A new release candidate is published after upstreaming Stuart's 
> commits on build cleanup.
>
> https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405 
> <https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405>
>
> The updates since the old tag are the following commits in the patch 
> series:
>
> [PATCH v2 0/4] TCG2 protocol clean up (groups.io) 
> <https://mailgw.loongson.cn/linkserver?dest=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F117882%3Fp%3D%252C%252C%252C20%252C0%252C0%252C0%253A%253Arecentpostdate%252Fsticky%252C%252Cstuart%2Byoder%252C20%252C2%252C0%252C105558005&tid=_____8Dx2enliT1mLVoKAA--.14549S3&rcpt=lichao@loongson.cn&ifnotice=1&rindex=1>
>
> The release candidate may be used for any further testing.
>
> With Warm Regards,
> Edhay
>
> > -----Original Message-----
>
> > From: G Edhaya Chandran
>
> > Sent: Tuesday, April 23, 2024 4:52 AM
>
> > To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>
> > Cc: Alex_Fox@phoenix.com; David_Wright@phoenix.com;
>
> > lichao@loongson.cn; Stuart Yoder <Stuart.Yoder@arm.com>;
>
> > devel@edk2.groups.io; gaojie@byosoft.com.cn
>
> > Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> > 
>
> > Hi Heinrich,
>
> > 
>
> >    Yes. A new release candidate shall be published after review and upstream
>
> > of the patches.
>
> > Will further send an update.
>
> > 
>
> > With Warm Regards,
>
> > Edhay
>
> > 
>
> > 
>
> > > -----Original Message-----
>
> > > From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>
> > > Sent: Tuesday, April 23, 2024 12:46 AM
>
> > > To: G Edhaya Chandran <Edhaya.Chandran@arm.com>
>
> > > Cc: Alex_Fox@phoenix.com; David_Wright@phoenix.com;
>
> > > lichao@loongson.cn; Stuart Yoder <Stuart.Yoder@arm.com>;
>
> > > devel@edk2.groups.io; gaojie@byosoft.com.cn
>
> > > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
>
> > >
>
> > > On 4/16/24 16:53, Stuart Yoder wrote:
>
> > > > This patch series cleans up some issues found when building
>
> > > > edk2-test with a non-GCC compiler:
>
> > > >   -TPMT_HA struct had an error due to incorrect use of C flexible
>
> > > > array
>
> > > member
>
> > > >   -compute struct member offsets using OFFSET_OF, which is not GCC
>
> > specific
>
> > > >   -clean up of #pragma pack in one file
>
> > > >   -resolve type conversion warnings
>
> > > >
>
> > > > Patches are in github here:
>
> > > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
>
> > > >
>
> > > > Version 2
>
> > > >   -add SM3 hash type to TPM2.h
>
> > > >   -resolve type conversion warnings
>
> > > >
>
> > > > Stuart Yoder (4):
>
> > > >   uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
>
> > > >   uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
>
> > > >   uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
>
> > > >   uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
>
> > > >
>
> > > >  uefi-
>
> > >
>
> > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
>
> > > st.h            |  3 +--
>
> > > >  uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 17
>
> > > +++++++++++--
>
> > > >  uefi-
>
> > > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
>
> > > Te stConformance.c | 25 +++++++++-----------
>
> > > >   3 files changed, 27 insertions(+), 18 deletions(-)
>
> > > >
>
> > >
>
> > > Hello Edhaya,
>
> > >
>
> > > Will we have another release candidate with these patches included?
>
> > >
>
> > > Best regards
>
> > >
>
> > > Heinrich
>
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose 
> the contents to any other person, use it for any purpose, or store or 
> copy the information in any medium. Thank you.
>
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose 
> the contents to any other person, use it for any purpose, or store or 
> copy the information in any medium. Thank you.
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118785): https://edk2.groups.io/g/devel/message/118785
Mute This Topic: https://groups.io/mt/105898910/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2.1: Type: text/html, Size: 29667 bytes --]

[-- Attachment #2.2: image001.png --]
[-- Type: image/png, Size: 5129 bytes --]

[-- Attachment #2.3: image002.jpg --]
[-- Type: image/jpeg, Size: 2777 bytes --]

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

[G Edhaya Chandran]

[-- Attachment #1.1: Type: text/plain, Size: 8300 bytes --]

Hi Chao,

   Yes, it is best to test based on the new tag at-least on one environment.

Note: The difference between old and new tag is mainly resolving build related issues.
There is no change in test coverage.

With WarM Regards,
Edhay


From: Chao Li <lichao@loongson.cn>
Sent: Thursday, May 9, 2024 9:56 PM
To: devel@edk2.groups.io; G Edhaya Chandran <Edhaya.Chandran@arm.com>; David Wright <David_Wright@phoenix.com>; Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Alex Fox <Alex_Fox@phoenix.com>; Stuart Yoder <Stuart.Yoder@arm.com>; gaojie@byosoft.com.cn
Subject: Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up


Hi Edhay,

Do I need to retest based on the edk2-test-rc2_202405 tag?

Thanks,
Chao
On 2024/5/10 10:43, G Edhaya Chandran wrote:
Thank you, David.
The results are well received.

With Warm Regards,
Edhay


From: David Wright <David_Wright@phoenix.com><mailto:David_Wright@phoenix.com>
Sent: Thursday, May 9, 2024 3:23 PM
To: G Edhaya Chandran <Edhaya.Chandran@arm.com><mailto:Edhaya.Chandran@arm.com>; Heinrich Schuchardt <heinrich.schuchardt@canonical.com><mailto:heinrich.schuchardt@canonical.com>
Cc: Alex Fox <Alex_Fox@phoenix.com><mailto:Alex_Fox@phoenix.com>; lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com><mailto:Stuart.Yoder@arm.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
Subject: RE: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

Hi all,

Phoenix has completed testing on edk2-test-rc2_202405

Results have been uploaded to their respective folders.

[cid:image001.png@01DAA2BF.53E23D80]


Thanks,
David Wright
QA Team Leader
David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>
503-730-4537 Tel
[cid:image002.jpg@01DAA2BF.53E23D80]
www.phoenix.com<https://mailgw.loongson.cn/linkserver?dest=http%3A%2F%2Fwww.phoenix.com%2F&tid=_____8Dx2enliT1mLVoKAA--.14549S3&rcpt=lichao@loongson.cn&ifnotice=1&rindex=0>
THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN ERROR, PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE OR REPLY EMAIL, AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.




From: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>>
Sent: Friday, May 3, 2024 4:47 PM
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
Cc: Alex Fox <Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>>; David Wright <David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>>; lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
Subject: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up


[Caution, this message was sent from an external sender.]

Hi All,

   A new release candidate is published after upstreaming Stuart's commits on build cleanup.
https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405

The updates since the old tag are the following commits in the patch series:
[PATCH v2 0/4] TCG2 protocol clean up (groups.io)<https://mailgw.loongson.cn/linkserver?dest=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F117882%3Fp%3D%252C%252C%252C20%252C0%252C0%252C0%253A%253Arecentpostdate%252Fsticky%252C%252Cstuart%2Byoder%252C20%252C2%252C0%252C105558005&tid=_____8Dx2enliT1mLVoKAA--.14549S3&rcpt=lichao@loongson.cn&ifnotice=1&rindex=1>

The release candidate may be used for any further testing.

With Warm Regards,
Edhay



> -----Original Message-----
> From: G Edhaya Chandran
> Sent: Tuesday, April 23, 2024 4:52 AM
> To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
> Cc: Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>; David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>;
> lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>;
> devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi Heinrich,
>
>    Yes. A new release candidate shall be published after review and upstream
> of the patches.
> Will further send an update.
>
> With Warm Regards,
> Edhay
>
>
> > -----Original Message-----
> > From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
> > Sent: Tuesday, April 23, 2024 12:46 AM
> > To: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>>
> > Cc: Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>; David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>;
> > lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>;
> > devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
> > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
> >
> > On 4/16/24 16:53, Stuart Yoder wrote:
> > > This patch series cleans up some issues found when building
> > > edk2-test with a non-GCC compiler:
> > >    -TPMT_HA struct had an error due to incorrect use of C flexible
> > > array
> > member
> > >    -compute struct member offsets using OFFSET_OF, which is not GCC
> specific
> > >    -clean up of #pragma pack in one file
> > >    -resolve type conversion warnings
> > >
> > > Patches are in github here:
> > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
> > >
> > > Version 2
> > >    -add SM3 hash type to TPM2.h
> > >    -resolve type conversion warnings
> > >
> > > Stuart Yoder (4):
> > >    uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
> > >    uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
> > >    uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
> > >    uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
> > >
> > >   uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
> > st.h            |  3 +--
> > >   uefi-sct/SctPkg/UEFI/Protocol/TCG2.h                                                         | 17
> > +++++++++++--
> > >   uefi-
> > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
> > Te stConformance.c | 25 +++++++++-----------
> > >   3 files changed, 27 insertions(+), 18 deletions(-)
> > >
> >
> > Hello Edhaya,
> >
> > Will we have another release candidate with these patches included?
> >
> > Best regards
> >
> > Heinrich

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118821): https://edk2.groups.io/g/devel/message/118821
Mute This Topic: https://groups.io/mt/105898910/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #1.2: Type: text/html, Size: 24060 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 5129 bytes --]

[-- Attachment #3: image002.jpg --]
[-- Type: image/jpeg, Size: 2777 bytes --]

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

[Chao Li]

[-- Attachment #1: Type: text/plain, Size: 8584 bytes --]

Hi Edhay,

Okay, I will retest using the rc2 today and expect to upload the logs 
tonight or next Monday under edk2-test-rc2-202405.


Thanks,
Chao
On 2024/5/10 22:56, G Edhaya Chandran wrote:
>
> Hi Chao,
>
> Yes, it is best to test based on the new tag at-least on one environment.
>
> Note: The difference between old and new tag is mainly resolving build 
> related issues.
>
> There is no change in test coverage.
>
> With WarM Regards,
> Edhay
>
> *From:*Chao Li <lichao@loongson.cn>
> *Sent:* Thursday, May 9, 2024 9:56 PM
> *To:* devel@edk2.groups.io; G Edhaya Chandran 
> <Edhaya.Chandran@arm.com>; David Wright <David_Wright@phoenix.com>; 
> Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> *Cc:* Alex Fox <Alex_Fox@phoenix.com>; Stuart Yoder 
> <Stuart.Yoder@arm.com>; gaojie@byosoft.com.cn
> *Subject:* Re: [edk2-devel] edk2-test Release candidate 2: 
> edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi Edhay,
>
> Do I need to retest based on the edk2-test-rc2_202405 tag?
>
> Thanks,
> Chao
>
> On 2024/5/10 10:43, G Edhaya Chandran wrote:
>
>     Thank you, David.
>
>     The results are well received.
>
>     With Warm Regards,
>     Edhay
>
>     *From:*David Wright <David_Wright@phoenix.com>
>     <mailto:David_Wright@phoenix.com>
>     *Sent:* Thursday, May 9, 2024 3:23 PM
>     *To:* G Edhaya Chandran <Edhaya.Chandran@arm.com>
>     <mailto:Edhaya.Chandran@arm.com>; Heinrich Schuchardt
>     <heinrich.schuchardt@canonical.com>
>     <mailto:heinrich.schuchardt@canonical.com>
>     *Cc:* Alex Fox <Alex_Fox@phoenix.com>
>     <mailto:Alex_Fox@phoenix.com>; lichao@loongson.cn; Stuart Yoder
>     <Stuart.Yoder@arm.com> <mailto:Stuart.Yoder@arm.com>;
>     devel@edk2.groups.io; gaojie@byosoft.com.cn
>     *Subject:* RE: edk2-test Release candidate 2: edk2-test-rc2_202405
>     // RE: [PATCH v2 0/4] TCG2 protocol clean up
>
>     Hi all,
>
>     Phoenix has completed testing on *edk2-test-rc2_202405*
>
>     Results have been uploaded to their respective folders.
>
>     Thanks,
>
>     David Wright
>     QA Team Leader
>
>     David_Wright@phoenix.com
>
>     503-730-4537 Tel
>
>     www.phoenix.com
>     <https://mailgw.loongson.cn/linkserver?dest=http%3A%2F%2Fwww.phoenix.com%2F&tid=_____8Dx2enliT1mLVoKAA--.14549S3&rcpt=lichao@loongson.cn&ifnotice=1&rindex=0>
>
>
>     THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE
>     THE INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS
>     STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN ERROR,
>     PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE OR REPLY EMAIL,
>     AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.
>
>     *From:*G Edhaya Chandran <Edhaya.Chandran@arm.com>
>     *Sent:* Friday, May 3, 2024 4:47 PM
>     *To:* Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>     *Cc:* Alex Fox <Alex_Fox@phoenix.com>; David Wright
>     <David_Wright@phoenix.com>; lichao@loongson.cn; Stuart Yoder
>     <Stuart.Yoder@arm.com>; devel@edk2.groups.io; gaojie@byosoft.com.cn
>     *Subject:* edk2-test Release candidate 2: edk2-test-rc2_202405 //
>     RE: [PATCH v2 0/4] TCG2 protocol clean up
>
>     [Caution, this message was sent from an external sender.]
>
>     Hi All,
>
>        A new release candidate is published after upstreaming Stuart's
>     commits on build cleanup.
>
>     https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405
>     <https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405>
>
>     The updates since the old tag are the following commits in the
>     patch series:
>
>     [PATCH v2 0/4] TCG2 protocol clean up (groups.io)
>     <https://mailgw.loongson.cn/linkserver?dest=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F117882%3Fp%3D%252C%252C%252C20%252C0%252C0%252C0%253A%253Arecentpostdate%252Fsticky%252C%252Cstuart%2Byoder%252C20%252C2%252C0%252C105558005&tid=_____8Dx2enliT1mLVoKAA--.14549S3&rcpt=lichao@loongson.cn&ifnotice=1&rindex=1>
>
>     The release candidate may be used for any further testing.
>
>     With Warm Regards,
>     Edhay
>
>     > -----Original Message-----
>
>     > From: G Edhaya Chandran
>
>     > Sent: Tuesday, April 23, 2024 4:52 AM
>
>     > To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>
>     > Cc: Alex_Fox@phoenix.com; David_Wright@phoenix.com;
>
>     > lichao@loongson.cn; Stuart Yoder <Stuart.Yoder@arm.com>;
>
>     > devel@edk2.groups.io; gaojie@byosoft.com.cn
>
>     > Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
>     > 
>
>     > Hi Heinrich,
>
>     > 
>
>     >    Yes. A new release candidate shall be published after review and upstream
>
>     > of the patches.
>
>     > Will further send an update.
>
>     > 
>
>     > With Warm Regards,
>
>     > Edhay
>
>     > 
>
>     > 
>
>     > > -----Original Message-----
>
>     > > From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>
>     > > Sent: Tuesday, April 23, 2024 12:46 AM
>
>     > > To: G Edhaya Chandran <Edhaya.Chandran@arm.com>
>
>     > > Cc: Alex_Fox@phoenix.com; David_Wright@phoenix.com;
>
>     > > lichao@loongson.cn; Stuart Yoder <Stuart.Yoder@arm.com>;
>
>     > > devel@edk2.groups.io; gaojie@byosoft.com.cn
>
>     > > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
>
>     > >
>
>     > > On 4/16/24 16:53, Stuart Yoder wrote:
>
>     > > > This patch series cleans up some issues found when building
>
>     > > > edk2-test with a non-GCC compiler:
>
>     > > >    -TPMT_HA struct had an error due to incorrect use of C flexible
>
>     > > > array
>
>     > > member
>
>     > > >    -compute struct member offsets using OFFSET_OF, which is not GCC
>
>     > specific
>
>     > > >    -clean up of #pragma pack in one file
>
>     > > >    -resolve type conversion warnings
>
>     > > >
>
>     > > > Patches are in github here:
>
>     > > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
>
>     > > >
>
>     > > > Version 2
>
>     > > >    -add SM3 hash type to TPM2.h
>
>     > > >    -resolve type conversion warnings
>
>     > > >
>
>     > > > Stuart Yoder (4):
>
>     > > >    uefi-sct/SctPkg: TCG2 Protocol: correct definition of
>     TPMT_HA struct
>
>     > > >    uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing
>     offsets
>
>     > > >    uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
>
>     > > >    uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion
>     warnings
>
>     > > >
>
>     > > >   uefi-
>
>     > >
>
>     > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
>
>     > > st.h            |  3 +--
>
>     > > > uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 17
>
>     > > +++++++++++--
>
>     > > >   uefi-
>
>     > > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
>
>     > > Te stConformance.c | 25 +++++++++-----------
>
>     > > >   3 files changed, 27 insertions(+), 18 deletions(-)
>
>     > > >
>
>     > >
>
>     > > Hello Edhaya,
>
>     > >
>
>     > > Will we have another release candidate with these patches included?
>
>     > >
>
>     > > Best regards
>
>     > >
>
>     > > Heinrich
>
>     IMPORTANT NOTICE: The contents of this email and any attachments
>     are confidential and may also be privileged. If you are not the
>     intended recipient, please notify the sender immediately and do
>     not disclose the contents to any other person, use it for any
>     purpose, or store or copy the information in any medium. Thank you.
>
>     IMPORTANT NOTICE: The contents of this email and any attachments
>     are confidential and may also be privileged. If you are not the
>     intended recipient, please notify the sender immediately and do
>     not disclose the contents to any other person, use it for any
>     purpose, or store or copy the information in any medium. Thank you.
>
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose 
> the contents to any other person, use it for any purpose, or store or 
> copy the information in any medium. Thank you.
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118829): https://edk2.groups.io/g/devel/message/118829
Mute This Topic: https://groups.io/mt/105898910/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2.1: Type: text/html, Size: 37345 bytes --]

[-- Attachment #2.2: image001.png --]
[-- Type: image/png, Size: 5129 bytes --]

[-- Attachment #2.3: image002.jpg --]
[-- Type: image/jpeg, Size: 2777 bytes --]

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

[Chao Li]

[-- Attachment #1: Type: text/plain, Size: 9023 bytes --]

Hi all,

The test results of LoongArch64 platform and the binaries of the 
LoongArch64 SCT have been uploaded:




Thanks,
Chao
On 2024/5/11 10:47, Chao Li wrote:
>
> Hi Edhay,
>
> Okay, I will retest using the rc2 today and expect to upload the logs 
> tonight or next Monday under edk2-test-rc2-202405.
>
> On 2024/5/10 22:56, G Edhaya Chandran wrote:
>>
>> Hi Chao,
>>
>> Yes, it is best to test based on the new tag at-least on one environment.
>>
>> Note: The difference between old and new tag is mainly resolving 
>> build related issues.
>>
>> There is no change in test coverage.
>>
>> With WarM Regards,
>> Edhay
>>
>> *From:*Chao Li <lichao@loongson.cn>
>> *Sent:* Thursday, May 9, 2024 9:56 PM
>> *To:* devel@edk2.groups.io; G Edhaya Chandran 
>> <Edhaya.Chandran@arm.com>; David Wright <David_Wright@phoenix.com>; 
>> Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> *Cc:* Alex Fox <Alex_Fox@phoenix.com>; Stuart Yoder 
>> <Stuart.Yoder@arm.com>; gaojie@byosoft.com.cn
>> *Subject:* Re: [edk2-devel] edk2-test Release candidate 2: 
>> edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up
>>
>> Hi Edhay,
>>
>> Do I need to retest based on the edk2-test-rc2_202405 tag?
>>
>> Thanks,
>> Chao
>>
>> On 2024/5/10 10:43, G Edhaya Chandran wrote:
>>
>>     Thank you, David.
>>
>>     The results are well received.
>>
>>     With Warm Regards,
>>     Edhay
>>
>>     *From:*David Wright <David_Wright@phoenix.com>
>>     <mailto:David_Wright@phoenix.com>
>>     *Sent:* Thursday, May 9, 2024 3:23 PM
>>     *To:* G Edhaya Chandran <Edhaya.Chandran@arm.com>
>>     <mailto:Edhaya.Chandran@arm.com>; Heinrich Schuchardt
>>     <heinrich.schuchardt@canonical.com>
>>     <mailto:heinrich.schuchardt@canonical.com>
>>     *Cc:* Alex Fox <Alex_Fox@phoenix.com>
>>     <mailto:Alex_Fox@phoenix.com>; lichao@loongson.cn; Stuart Yoder
>>     <Stuart.Yoder@arm.com> <mailto:Stuart.Yoder@arm.com>;
>>     devel@edk2.groups.io; gaojie@byosoft.com.cn
>>     *Subject:* RE: edk2-test Release candidate 2:
>>     edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up
>>
>>     Hi all,
>>
>>     Phoenix has completed testing on *edk2-test-rc2_202405*
>>
>>     Results have been uploaded to their respective folders.
>>
>>     Thanks,
>>
>>     David Wright
>>     QA Team Leader
>>
>>     David_Wright@phoenix.com
>>
>>     503-730-4537 Tel
>>
>>     www.phoenix.com
>>     <https://mailgw.loongson.cn/linkserver?dest=http%3A%2F%2Fwww.phoenix.com%2F&tid=_____8Dx2enliT1mLVoKAA--.14549S3&rcpt=lichao@loongson.cn&ifnotice=1&rindex=0>
>>
>>
>>     THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE
>>     THE INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE
>>     IS STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN
>>     ERROR, PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE OR REPLY
>>     EMAIL, AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.
>>
>>     *From:*G Edhaya Chandran <Edhaya.Chandran@arm.com>
>>     *Sent:* Friday, May 3, 2024 4:47 PM
>>     *To:* Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>>     *Cc:* Alex Fox <Alex_Fox@phoenix.com>; David Wright
>>     <David_Wright@phoenix.com>; lichao@loongson.cn; Stuart Yoder
>>     <Stuart.Yoder@arm.com>; devel@edk2.groups.io; gaojie@byosoft.com.cn
>>     *Subject:* edk2-test Release candidate 2: edk2-test-rc2_202405 //
>>     RE: [PATCH v2 0/4] TCG2 protocol clean up
>>
>>     [Caution, this message was sent from an external sender.]
>>
>>     Hi All,
>>
>>        A new release candidate is published after upstreaming
>>     Stuart's commits on build cleanup.
>>
>>     https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405
>>     <https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405>
>>
>>     The updates since the old tag are the following commits in the
>>     patch series:
>>
>>     [PATCH v2 0/4] TCG2 protocol clean up (groups.io)
>>     <https://mailgw.loongson.cn/linkserver?dest=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F117882%3Fp%3D%252C%252C%252C20%252C0%252C0%252C0%253A%253Arecentpostdate%252Fsticky%252C%252Cstuart%2Byoder%252C20%252C2%252C0%252C105558005&tid=_____8Dx2enliT1mLVoKAA--.14549S3&rcpt=lichao@loongson.cn&ifnotice=1&rindex=1>
>>
>>     The release candidate may be used for any further testing.
>>
>>     With Warm Regards,
>>     Edhay
>>
>>     > -----Original Message-----
>>
>>     > From: G Edhaya Chandran
>>
>>     > Sent: Tuesday, April 23, 2024 4:52 AM
>>
>>     > To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>>
>>     > Cc: Alex_Fox@phoenix.com; David_Wright@phoenix.com;
>>
>>     > lichao@loongson.cn; Stuart Yoder <Stuart.Yoder@arm.com>;
>>
>>     > devel@edk2.groups.io; gaojie@byosoft.com.cn
>>
>>     > Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>>
>>     > 
>>
>>     > Hi Heinrich,
>>
>>     > 
>>
>>     >    Yes. A new release candidate shall be published after review and upstream
>>
>>     > of the patches.
>>
>>     > Will further send an update.
>>
>>     > 
>>
>>     > With Warm Regards,
>>
>>     > Edhay
>>
>>     > 
>>
>>     > 
>>
>>     > > -----Original Message-----
>>
>>     > > From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>>
>>     > > Sent: Tuesday, April 23, 2024 12:46 AM
>>
>>     > > To: G Edhaya Chandran <Edhaya.Chandran@arm.com>
>>
>>     > > Cc: Alex_Fox@phoenix.com; David_Wright@phoenix.com;
>>
>>     > > lichao@loongson.cn; Stuart Yoder <Stuart.Yoder@arm.com>;
>>
>>     > > devel@edk2.groups.io; gaojie@byosoft.com.cn
>>
>>     > > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
>>
>>     > >
>>
>>     > > On 4/16/24 16:53, Stuart Yoder wrote:
>>
>>     > > > This patch series cleans up some issues found when building
>>
>>     > > > edk2-test with a non-GCC compiler:
>>
>>     > > >    -TPMT_HA struct had an error due to incorrect use of C flexible
>>
>>     > > > array
>>
>>     > > member
>>
>>     > > >    -compute struct member offsets using OFFSET_OF, which is
>>     not GCC
>>
>>     > specific
>>
>>     > > >    -clean up of #pragma pack in one file
>>
>>     > > >    -resolve type conversion warnings
>>
>>     > > >
>>
>>     > > > Patches are in github here:
>>
>>     > > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
>>
>>     > > >
>>
>>     > > > Version 2
>>
>>     > > >    -add SM3 hash type to TPM2.h
>>
>>     > > >    -resolve type conversion warnings
>>
>>     > > >
>>
>>     > > > Stuart Yoder (4):
>>
>>     > > >    uefi-sct/SctPkg: TCG2 Protocol: correct definition of
>>     TPMT_HA struct
>>
>>     > > >    uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing
>>     offsets
>>
>>     > > >    uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
>>
>>     > > >    uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion
>>     warnings
>>
>>     > > >
>>
>>     > > >   uefi-
>>
>>     > >
>>
>>     > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
>>
>>     > > st.h            |  3 +--
>>
>>     > > > uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 17
>>
>>     > > +++++++++++--
>>
>>     > > >   uefi-
>>
>>     > > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
>>
>>     > > Te stConformance.c | 25 +++++++++-----------
>>
>>     > > >   3 files changed, 27 insertions(+), 18 deletions(-)
>>
>>     > > >
>>
>>     > >
>>
>>     > > Hello Edhaya,
>>
>>     > >
>>
>>     > > Will we have another release candidate with these patches included?
>>
>>     > >
>>
>>     > > Best regards
>>
>>     > >
>>
>>     > > Heinrich
>>
>>     IMPORTANT NOTICE: The contents of this email and any attachments
>>     are confidential and may also be privileged. If you are not the
>>     intended recipient, please notify the sender immediately and do
>>     not disclose the contents to any other person, use it for any
>>     purpose, or store or copy the information in any medium. Thank you.
>>
>>     IMPORTANT NOTICE: The contents of this email and any attachments
>>     are confidential and may also be privileged. If you are not the
>>     intended recipient, please notify the sender immediately and do
>>     not disclose the contents to any other person, use it for any
>>     purpose, or store or copy the information in any medium. Thank you.
>>
>> IMPORTANT NOTICE: The contents of this email and any attachments are 
>> confidential and may also be privileged. If you are not the intended 
>> recipient, please notify the sender immediately and do not disclose 
>> the contents to any other person, use it for any purpose, or store or 
>> copy the information in any medium. Thank you. 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118857): https://edk2.groups.io/g/devel/message/118857
Mute This Topic: https://groups.io/mt/105898910/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2.1: Type: text/html, Size: 39926 bytes --]

[-- Attachment #2.2: jpd1bLDwQZoLoV35.png --]
[-- Type: image/png, Size: 50108 bytes --]

[-- Attachment #2.3: Oe50HWCWrjozrS1v.png --]
[-- Type: image/png, Size: 55485 bytes --]

[-- Attachment #2.4: VM9S23qQaKOK8PgA.png --]
[-- Type: image/png, Size: 38234 bytes --]

[-- Attachment #2.5: image001.png --]
[-- Type: image/png, Size: 5129 bytes --]

[-- Attachment #2.6: image002.jpg --]
[-- Type: image/jpeg, Size: 2777 bytes --]

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

[G Edhaya Chandran]

[-- Attachment #1.1: Type: text/plain, Size: 9894 bytes --]

Hi Chao,

   Thank you so much for the results.

With Warm Regards,
Edhay


From: Chao Li <lichao@loongson.cn>
Sent: Monday, May 13, 2024 1:21 AM
To: devel@edk2.groups.io; G Edhaya Chandran <Edhaya.Chandran@arm.com>; David Wright <David_Wright@phoenix.com>; Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Alex Fox <Alex_Fox@phoenix.com>; Stuart Yoder <Stuart.Yoder@arm.com>; gaojie@byosoft.com.cn
Subject: Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up


Hi all,

The test results of LoongArch64 platform and the binaries of the LoongArch64 SCT have been uploaded:

[cid:image001.png@01DAA51F.410DBEC0]

[cid:image002.png@01DAA51F.410DBEC0]

[cid:image003.png@01DAA51F.410DBEC0]

Thanks,
Chao
On 2024/5/11 10:47, Chao Li wrote:

Hi Edhay,

Okay, I will retest using the rc2 today and expect to upload the logs tonight or next Monday under edk2-test-rc2-202405.
On 2024/5/10 22:56, G Edhaya Chandran wrote:
Hi Chao,

   Yes, it is best to test based on the new tag at-least on one environment.

Note: The difference between old and new tag is mainly resolving build related issues.
There is no change in test coverage.

With WarM Regards,
Edhay


From: Chao Li <lichao@loongson.cn><mailto:lichao@loongson.cn>
Sent: Thursday, May 9, 2024 9:56 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; G Edhaya Chandran <Edhaya.Chandran@arm.com><mailto:Edhaya.Chandran@arm.com>; David Wright <David_Wright@phoenix.com><mailto:David_Wright@phoenix.com>; Heinrich Schuchardt <heinrich.schuchardt@canonical.com><mailto:heinrich.schuchardt@canonical.com>
Cc: Alex Fox <Alex_Fox@phoenix.com><mailto:Alex_Fox@phoenix.com>; Stuart Yoder <Stuart.Yoder@arm.com><mailto:Stuart.Yoder@arm.com>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
Subject: Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up


Hi Edhay,

Do I need to retest based on the edk2-test-rc2_202405 tag?

Thanks,
Chao
On 2024/5/10 10:43, G Edhaya Chandran wrote:
Thank you, David.
The results are well received.

With Warm Regards,
Edhay


From: David Wright <David_Wright@phoenix.com><mailto:David_Wright@phoenix.com>
Sent: Thursday, May 9, 2024 3:23 PM
To: G Edhaya Chandran <Edhaya.Chandran@arm.com><mailto:Edhaya.Chandran@arm.com>; Heinrich Schuchardt <heinrich.schuchardt@canonical.com><mailto:heinrich.schuchardt@canonical.com>
Cc: Alex Fox <Alex_Fox@phoenix.com><mailto:Alex_Fox@phoenix.com>; lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com><mailto:Stuart.Yoder@arm.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
Subject: RE: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

Hi all,

Phoenix has completed testing on edk2-test-rc2_202405

Results have been uploaded to their respective folders.

[cid:image004.png@01DAA51F.410DBEC0]


Thanks,
David Wright
QA Team Leader
David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>
503-730-4537 Tel
[cid:image005.jpg@01DAA51F.410DBEC0]
www.phoenix.com<https://mailgw.loongson.cn/linkserver?dest=http%3A%2F%2Fwww.phoenix.com%2F&tid=_____8Dx2enliT1mLVoKAA--.14549S3&rcpt=lichao@loongson.cn&ifnotice=1&rindex=0>
THIS MESSAGE MAY CONTAIN CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN ERROR, PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE OR REPLY EMAIL, AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES.




From: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>>
Sent: Friday, May 3, 2024 4:47 PM
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
Cc: Alex Fox <Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>>; David Wright <David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>>; lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
Subject: edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up


[Caution, this message was sent from an external sender.]

Hi All,

   A new release candidate is published after upstreaming Stuart's commits on build cleanup.
https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405

The updates since the old tag are the following commits in the patch series:
[PATCH v2 0/4] TCG2 protocol clean up (groups.io)<https://mailgw.loongson.cn/linkserver?dest=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F117882%3Fp%3D%252C%252C%252C20%252C0%252C0%252C0%253A%253Arecentpostdate%252Fsticky%252C%252Cstuart%2Byoder%252C20%252C2%252C0%252C105558005&tid=_____8Dx2enliT1mLVoKAA--.14549S3&rcpt=lichao@loongson.cn&ifnotice=1&rindex=1>

The release candidate may be used for any further testing.

With Warm Regards,
Edhay



> -----Original Message-----
> From: G Edhaya Chandran
> Sent: Tuesday, April 23, 2024 4:52 AM
> To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
> Cc: Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>; David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>;
> lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>;
> devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
> Subject: RE: [PATCH v2 0/4] TCG2 protocol clean up
>
> Hi Heinrich,
>
>    Yes. A new release candidate shall be published after review and upstream
> of the patches.
> Will further send an update.
>
> With Warm Regards,
> Edhay
>
>
> > -----Original Message-----
> > From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com<mailto:heinrich.schuchardt@canonical.com>>
> > Sent: Tuesday, April 23, 2024 12:46 AM
> > To: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>>
> > Cc: Alex_Fox@phoenix.com<mailto:Alex_Fox@phoenix.com>; David_Wright@phoenix.com<mailto:David_Wright@phoenix.com>;
> > lichao@loongson.cn<mailto:lichao@loongson.cn>; Stuart Yoder <Stuart.Yoder@arm.com<mailto:Stuart.Yoder@arm.com>>;
> > devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaojie@byosoft.com.cn<mailto:gaojie@byosoft.com.cn>
> > Subject: Re: [PATCH v2 0/4] TCG2 protocol clean up
> >
> > On 4/16/24 16:53, Stuart Yoder wrote:
> > > This patch series cleans up some issues found when building
> > > edk2-test with a non-GCC compiler:
> > >    -TPMT_HA struct had an error due to incorrect use of C flexible
> > > array
> > member
> > >    -compute struct member offsets using OFFSET_OF, which is not GCC
> specific
> > >    -clean up of #pragma pack in one file
> > >    -resolve type conversion warnings
> > >
> > > Patches are in github here:
> > > https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
> > >
> > > Version 2
> > >    -add SM3 hash type to TPM2.h
> > >    -resolve type conversion warnings
> > >
> > > Stuart Yoder (4):
> > >    uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
> > >    uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
> > >    uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
> > >    uefi-sct/SctPkg: TCG2 Protocol: clean up type conversion warnings
> > >
> > >   uefi-
> >
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTe
> > st.h            |  3 +--
> > >   uefi-sct/SctPkg/UEFI/Protocol/TCG2.h                                                         | 17
> > +++++++++++--
> > >   uefi-
> > sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBB
> > Te stConformance.c | 25 +++++++++-----------
> > >   3 files changed, 27 insertions(+), 18 deletions(-)
> > >
> >
> > Hello Edhaya,
> >
> > Will we have another release candidate with these patches included?
> >
> > Best regards
> >
> > Heinrich

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118866): https://edk2.groups.io/g/devel/message/118866
Mute This Topic: https://groups.io/mt/105898910/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #1.2: Type: text/html, Size: 27900 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 50108 bytes --]

[-- Attachment #3: image002.png --]
[-- Type: image/png, Size: 55485 bytes --]

[-- Attachment #4: image003.png --]
[-- Type: image/png, Size: 38234 bytes --]

[-- Attachment #5: image004.png --]
[-- Type: image/png, Size: 5129 bytes --]

[-- Attachment #6: image005.jpg --]
[-- Type: image/jpeg, Size: 2777 bytes --]