From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.51]) by mx.groups.io with SMTP id smtpd.web12.18603.1665568884460912621 for ; Wed, 12 Oct 2022 03:01:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=0cisvdzu; spf=pass (domain: arm.com, ip: 40.107.14.51, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BtF/KqSQbvU5cZNa4A/SWe54iERxM8yS5oSw+tyKJOIABkb1htLMMdHSk+TfLLbJM4uW2MZsrFFSHg2NVa/vKHieMjuPZXjCPwSaaKCglxprJSZlzoOhXeEv2w3Vk0KkTD9XmvVecimrmdrFgrxOXMsbtfHa2EvzTVENnUhKJe5tDtibhY2U/pV/4hdRMjRrBaG2tIJ+vz1khIX+MckTBVZGjQ3khycybEbe8syPjTA9FQSouMyauE7AYvEFotoQzZx6/lyA/OqPva2akFP5Ym7RY5I1WFDHBJMpH4U2nqpF2s8uZUzi0sxXFhY+IDTnOzBq3ZNd/WMZf5pGSKH9oQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aTMt3T389yzt81EA/keTbrqdEdirUDXB6cVnxinJMNA=; b=bvwmHOJESTuxRqarOIPyGYduxO55hZSUVvuyWhNTgJIJjTj4NIbGkDFve845SrEgZljYduv3nRW7UDc9Aut2tdGdu2OjklA1oIZFGHq0APT+HEEuhQU/GywV8qaYLhpVA/Xm3vZKXMSe+y0YPjEsZ6AXWw9HO7lEnJGIpvesoP1et1+Pfdgo7lDRF0Y4Ef/6VXdbPS0ZwlNS/sYU9p5ZnUh2U70XL98s4n7g0N3GMjVLfPqAIEENCTH8zzNHcidNmIVxd5LZ6MXLo5EzARy14va/Py9fQk86Nm/vBclkZ9O+pAb8H7Y7MAOgAtmQaMSnGSQlb3vy2JD0Rl8FvvNwig== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aTMt3T389yzt81EA/keTbrqdEdirUDXB6cVnxinJMNA=; b=0cisvdzuZvHqs+5xVG8GOuwGik8GozEpAnoxj/p+/aHE9p/bb6rWJZsfzm1VUZtRHviI9E4h9m8mdYsthIfpkop7W9jT8aGnFY7N0v7sAjwqA/8qS2Vqvx8ScouvwiBg4kuquVla76efAzHFAEShJ3QmziCQIegJDVufaTwq7xE= Received: from FR3P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::14) by DB8PR08MB5388.eurprd08.prod.outlook.com (2603:10a6:10:11c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct 2022 10:01:20 +0000 Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a3:cafe::1f) by FR3P281CA0111.outlook.office365.com (2603:10a6:d10:a3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend Transport; Wed, 12 Oct 2022 10:01:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 10:01:19 +0000 Received: ("Tessian outbound 7761be2ecf00:v128"); Wed, 12 Oct 2022 10:01:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2760a28fa8fc2ca0 X-CR-MTA-TID: 64aa7808 Received: from b47c535519f7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B777838-A635-4D37-A432-76F4188B1A3E.1; Wed, 12 Oct 2022 10:01:12 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b47c535519f7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 12 Oct 2022 10:01:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O93uawYOvA4cpJdkjkvvGXWNZNcUgkyNTQht7Q4/ipe7mCIs+sDx5g2q4kIUuel07e0pLnzY5SZPdZvrGhIaDXEOJc2bVEhLoXNmDVLsOHq/hKU+J57ib5Kgc3IHqzkk381KCOQu/gJVqIx5XZC8c2PVNfoNLBL38sAAd0Z3ZTlb/8PuLS5cQ+QSAFz9i9yc5wEAK9d06t7lYkJvCLAfgnyhOHxO0vh0tpRzWK6wfUzTh7dmXTqkXlAxKMRT24qA3d0VmDrOYiTxr80SMGe9M5ElVhDFiA0FU3MPq2Xt8QyPimEWbczElkIKH+YbTea3ZfHK/7nIgzV2H8GQ6H04wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aTMt3T389yzt81EA/keTbrqdEdirUDXB6cVnxinJMNA=; b=Cbx7Pvj16OI9HkBZApLPT9YufN3u54Ea6+5tiEdDmXP8eSNiCTLTwTGRbZ5NrFaVIfNyOBziYuH2+L5NTcdRQ8XoI2Rdr9n1Tvn0ppuXbR/E6djeAK6dDy7t0E/OwXRKttMGc4qwtahy6jAO0J7BSH9euBFE48U8zIz9cDd0qq/+jQf3DSMdueyqARqMBrvyu+r/mSHXpOIbLrwmFM0h15euoEA562vhf7+XPXH/nUnOmqbT6TJLeeEbrZbiyrMKUMdzap3b+lP6rzFVJsOofxL4v9fJo+sKZqgPt1HpvXZWgq5KhNyNlurTDT9xF5oK7e+iEpr45Q6HJ2xd+z+ZBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aTMt3T389yzt81EA/keTbrqdEdirUDXB6cVnxinJMNA=; b=0cisvdzuZvHqs+5xVG8GOuwGik8GozEpAnoxj/p+/aHE9p/bb6rWJZsfzm1VUZtRHviI9E4h9m8mdYsthIfpkop7W9jT8aGnFY7N0v7sAjwqA/8qS2Vqvx8ScouvwiBg4kuquVla76efAzHFAEShJ3QmziCQIegJDVufaTwq7xE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB7323.eurprd08.prod.outlook.com (2603:10a6:20b:442::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 10:01:08 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%4]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022 10:01:07 +0000 Message-ID: <64412d1d-2608-1f3e-bcd4-173034db4f24@arm.com> Date: Wed, 12 Oct 2022 11:01:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 2/2] ArmVirtPkg: allow setting Firmware Version from build command line To: Oliver Steffen , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Gerd Hoffmann , Jian J Wang , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Liming Gao , Ray Ni , Zhichao Gao , Pawel Polawski , "nd@arm.com" References: <20221012073504.511854-1-osteffen@redhat.com> From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO4P123CA0456.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::11) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AS8PR08MB7323:EE_|VE1EUR03FT005:EE_|DB8PR08MB5388:EE_ X-MS-Office365-Filtering-Correlation-Id: a2b0ce93-0af9-4b84-f5b1-08daac38b5f0 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YcusXKGhXzXyYXHvS516xVVsRgMl9GStHFm8stgWUreNF0usW9Gh0lo3glVt5RYY+a4wJhql1HuleOonMlbKRxO8TTe0VXtvNJPndVt8FxdtUgmomm/jWqFg+7StZcglNf6VX2N6HZfeznZ9fP/H9W5fDqgadYWHf70LwnplKZtTqW3n7Kldj1+h57I/p+AZyYCaW+1SLPNR52e1pxQ9LIuWypTxRF/AlqWvZiCXWgD+416u7lGo3wRfngrcjN36azp+I31ca/ObniwWtO/LgyuhHHGq5sdowcMLS+fYR7w9QCGAyDP1gzMnAHnAkpYTxWztvYKL10LDDI6nrlla4Y10pSLxgcEsU/1lu2N6B2abJ3bGPme70YDhTt7ikU3sx7QOmZQ4DVPVTz8/mob4rQE2AwVUi4s0G2QqsAQXoq70c3JP03gA+T2lJ4WvsvTpAVohJdV8IUtHZFFNtwQHjDquKM0lzs3QxpyuIcoAtIaOP8p0DXiXb31uecNetIDVNKblLCYJxK3Y6LJx/jc6jbr+ZZvQ9902dHxiVeSofFZfUMOS3r4RPeN1d1zPyUhdX064EslhV9bnlv6xUrBdAM+QVhwqg5K+h2RKEmcZFQIkG0fYgiCcFQ5GL5LIq6KLapju/RM0zEjf11bWNRHxObFVOYJzQ3h/KhE/ozo7unWBCPqBUzCm4X0TdUn2t+OU5/9iYWdiyFhubLD1Av/lm0UYvg98d07KRDIeLCdfxRCAZPxgyuXUUB5vK8PLZeBoN4ZfTsRKd6lFBtVKqAK2HAu02dpejh0k/Q67/QP+v7U= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(376002)(346002)(39860400002)(396003)(451199015)(36756003)(86362001)(31696002)(38100700002)(478600001)(6512007)(186003)(6506007)(26005)(31686004)(6486002)(2616005)(4326008)(41300700001)(54906003)(53546011)(316002)(44832011)(8676002)(8936002)(66946007)(66556008)(66476007)(5660300002)(2906002)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7323 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 71a6fb13-a843-49e4-d54c-08daac38aeb3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F+pyDubjEdGuy2c06DWZ28tEEFdiAapNYGzZagY1Kjvii+klPPGpjnn4AAwb/rqudVVJUigLQLnomSn6Tgn6x6cY1TUQxpWPcQZ1GhTVbvnNd6uw1F9RNewvvGnrhIZ6n2OhNgY5a2qbufrsBzVTQiTLOGg3IYrqHQS3Z/cpwAyMiP9m+DC2SPcAIcA1jlErqAgt+hhHEB24zA0SRosjs7Il2S6dIeuvyMTmYtuDLhhRqIuwIE6kIlU1vLZyn2Vtybki9BfkeoiR16tKRf1FCSB0dInK8DF+/G5LTARonhElgYMuX19r28McE5tIlp/syrnU3kH3FeE5toyTpeHId4N7s4iGLkyjnOBn6lO6FMXFfxHPiW9ykBO5cff2NffG/NPMXNb6aXwUTSnbk7amlb93yubfS6KsDfYd8KkkypMUVhiEIcHfV/fsNemGLqAWjti6yO2hJYkEiQ1fmU6obJDQZzjaC8vWIVnawSweClszFpK1ItgV9tEijMMh5Nkg3lv5N0H4OmhpC62zLAbqQzCR0vG40ZT2jMS/+NU/aAN5R48+3NOJi6LUapDR4aoX1FM8tEkPHpqOpz7zi3F2fdEk5EMDsgllTt2zSuWupMSxtsdmTn43m6mDGVF7+ao0Cn/JA7rtKz8/dN3yO+UJBkDsKW+Xm2OzTRqU8eIQLxulT4/sDeTg6HUF4nhlqI5Ty6dRTKb57fi17+McwXqeTPHxzL+Ww7+JP3RUvqGs7W05WzUxwTxKTcyNSrOaJkzO9fdmwDDsgTIpAWaUiEoaevHhJZcR/kmFzTligkzUXq3PAxUpNl757JK24M7bUcuY X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(26005)(6506007)(53546011)(31686004)(36860700001)(82740400003)(31696002)(316002)(8676002)(70206006)(70586007)(4326008)(81166007)(356005)(86362001)(40460700003)(36756003)(40480700001)(186003)(6486002)(2616005)(478600001)(2906002)(54906003)(47076005)(336012)(5660300002)(41300700001)(82310400005)(8936002)(6512007)(44832011)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 10:01:19.5710 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a2b0ce93-0af9-4b84-f5b1-08daac38b5f0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5388 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Oliver, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 12/10/2022 08:35 am, Oliver Steffen wrote: > Initialize > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > with with the value of the variable "FIRMWARE_VER" > in all flavors of ArmVirtPkg. > > This behavior is already implemented in ArmVirtXen.dsc. > It allows specifying the firmware version string on the > build command line with -D FIRMARE_VER=... > > > Signed-off-by: Oliver Steffen > --- > ArmVirtPkg/ArmVirtCloudHv.dsc | 1 + > ArmVirtPkg/ArmVirtKvmTool.dsc | 1 + > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.dsc > index 7ca7a391d9cf..7e3aa84cd321 100644 > --- a/ArmVirtPkg/ArmVirtCloudHv.dsc > +++ b/ArmVirtPkg/ArmVirtCloudHv.dsc > @@ -86,6 +86,7 @@ [PcdsFeatureFlag.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE > > [PcdsFixedAtBuild.common] > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > !if $(ARCH) == AARCH64 > gArmTokenSpaceGuid.PcdVFPEnabled|1 > !endif > diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc > index 3bd3ebd6e0b3..e07ed6fc4ca8 100644 > --- a/ArmVirtPkg/ArmVirtKvmTool.dsc > +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc > @@ -113,6 +113,7 @@ [PcdsFeatureFlag.common] > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcUseMmio|TRUE > > [PcdsFixedAtBuild.common] > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F > > gArmPlatformTokenSpaceGuid.PcdCoreCount|1 > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 9369a88858fd..4963b2006165 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -135,6 +135,7 @@ [PcdsFeatureFlag.common] > gArmVirtTokenSpaceGuid.PcdTpm2SupportEnabled|$(TPM2_ENABLE) > > [PcdsFixedAtBuild.common] > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > !if $(ARCH) == AARCH64 > gArmTokenSpaceGuid.PcdVFPEnabled|1 > !endif > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index 7f7d15d6eee3..8454be6c2bfd 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -115,6 +115,7 @@ [PcdsFeatureFlag.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE > > [PcdsFixedAtBuild.common] > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > !if $(ARCH) == AARCH64 > gArmTokenSpaceGuid.PcdVFPEnabled|1 > !endif