From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: =?UTF-8?B?UmU6IFtlZGsyLWRldmVsXSDlm57lpI06IFtlZGsyLWRldmVsXSBbUEFUQ0ggdjEgMS8xXSBCYXNlVG9vbHMvRWNjOiBNYWtlIEVjYyBvbmx5IGNoZWNrIGZpcnN0IGluY2x1ZGUgZ3VhcmQ=?=
To: gaoliming <gaoliming@byosoft.com.cn>,devel@edk2.groups.io
From: "PierreGondois" <pierre.gondois@arm.com>
X-Originating-Location: Cambridge, England, GB (86.151.121.10)
X-Originating-Platform: Linux Firefox 85
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Thu, 11 Mar 2021 01:25:55 -0800
References: <00d001d71615$7e9ad6c0$7bd08440$@byosoft.com.cn>
In-Reply-To: <00d001d71615$7e9ad6c0$7bd08440$@byosoft.com.cn>
Message-ID: <6476.1615454755583866377@groups.io>
Content-Type: multipart/alternative; boundary="KqkrMjfjzDaT8J7cZjKZ"

--KqkrMjfjzDaT8J7cZjKZ
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Liming,
Yes this check is only done for '.h' files. Cf the bit of code from the sa=
me file:

if os.path.splitext(F)[1] in ('.h'):
self.NamingConventionCheckIfndefStatement(FileTable)

I think this is normal, the format of the initial 'ifndef' needs to be for=
matted as 'Name_', but not necessarilly all the other 'ifndef' in the file.
I added the arm copyright two times, I will submit a v2 if the patch goes =
forward.

Regards,
Pierre

--KqkrMjfjzDaT8J7cZjKZ
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Liming,<br />Yes this check is only done for '.h' files. Cf the bit o=
f code from the same file:<br /><br />if os.path.splitext(F)[1] in ('.h'):<=
br />&nbsp; self.NamingConventionCheckIfndefStatement(FileTable)<br /><br /=
>I think this is normal, the format of the initial 'ifndef' needs to be for=
matted as 'Name_', but not necessarilly all the other 'ifndef' in the file.=
<br />I added the arm copyright two times, I will submit a v2 if the patch =
goes forward.<br /><br />Regards,<br />Pierre

--KqkrMjfjzDaT8J7cZjKZ--