public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>, Dandan Bi <dandan.bi@intel.com>
Cc: edk2-devel@lists.01.org, "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [Patch 0/3] BaseTools: Implement splitquoted function
Date: Tue, 12 Feb 2019 13:23:52 +0100	[thread overview]
Message-ID: <64947d2b-9a8a-f7ff-5221-e40416f39531@redhat.com> (raw)
In-Reply-To: <31516193-5bd7-8c97-9a18-03e569f57d94@redhat.com>

On 02/04/19 20:12, Laszlo Ersek wrote:
> On 02/03/19 06:55, Feng, Bob C wrote:
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509
>> On some Linux environment, there may be no distutils.util
>> library for python3 that will cause build tool crash.
>> This patch implement distutils.util.split_quoted
>> in BaseTools so that the Basetools will be independent with
>> distutils.util library.
>>
>> Feng, Bob C (3):
>>   BaseTools: Implement splitquoted function in Build tool
>>   BaseTools: Implement splitquoted function in UPT
>>   BaseTools: unit test for splitquoted function
>>
>>  BaseTools/Source/Python/AutoGen/UniClassObject.py     | 50 ++++++++++++++++++++++++++++++++++++++++++++++----
>>  BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 ++++++++++++++++++++++++++++++++++++++++++++---
>>  BaseTools/Tests/TestStringSplit.py                    | 38 ++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 128 insertions(+), 7 deletions(-)
>>  create mode 100644 BaseTools/Tests/TestStringSplit.py
>>
> 
> Is this really necessary? BZ#1509 references Ubuntu18; however it looks
> like the issue can be resolved by a simple package installation on
> Ubuntu 18:
> 
> https://superuser.com/questions/1319047/cant-install-virtual-interpreter-in-pycharm-in-linux
> 
> """
> sudo apt-get install python3-distutils
> """
> 
> I'm not a Ubuntu user myself; so all I can do here (without installing a
> Ubuntu18 VM) is check the Ubuntu package directory:
> 
> https://packages.ubuntu.com/search?keywords=python3-distutils&searchon=names&suite=all&section=all
> 
> python3-distutils appears available for both "bionic (18.04LTS)" and
> "cosmic (18.10)".
> 
> Dandan, if you install python3-distutils, does that solve the issue for you?

I'd still like to get an answer to my question, before the series is pushed.

Thanks,
Laszlo


  reply	other threads:[~2019-02-12 12:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-03  5:55 [Patch 0/3] BaseTools: Implement splitquoted function Feng, Bob C
2019-02-03  5:55 ` [Patch 1/3] BaseTools: Implement splitquoted function in Build tool Feng, Bob C
2019-02-04 15:38   ` Carsey, Jaben
2019-02-03  5:55 ` [Patch 2/3] BaseTools: Implement splitquoted function in UPT Feng, Bob C
2019-02-03  5:55 ` [Patch 3/3] BaseTools: unit test for splitquoted function Feng, Bob C
2019-02-04 19:12 ` [Patch 0/3] BaseTools: Implement " Laszlo Ersek
2019-02-12 12:23   ` Laszlo Ersek [this message]
2019-02-12 13:33     ` Gao, Liming
2019-02-12 14:02       ` Laszlo Ersek
2019-02-12 17:16         ` Philippe Mathieu-Daudé
2019-02-12 17:24           ` Laszlo Ersek
2019-02-14  2:51         ` Feng, Bob C
2019-02-14  3:23           ` Gao, Liming
2019-02-14 15:35             ` Laszlo Ersek
2019-02-15 14:35               ` Gao, Liming
2019-02-15 21:54                 ` Laszlo Ersek
2019-02-14 15:32           ` Laszlo Ersek
2019-02-15  3:19             ` Feng, Bob C
2019-02-12 10:44 ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64947d2b-9a8a-f7ff-5221-e40416f39531@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox