From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web10.29205.1628806752119287615 for ; Thu, 12 Aug 2021 15:19:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=pYvh07SD; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: stefanb@linux.ibm.com) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17CM88gF085537; Thu, 12 Aug 2021 18:19:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=Cln2s8m2MN+4xOpkuthjYZZzIyllpXR5Zt046BSYP3Y=; b=pYvh07SD0tQUFtA9vTxw7yi5q7V9Fk4gRqKKiOsDFkdc2DnQX/wBLNKDjySoaiCLfebA y2bOnhLLXeg0vplcPQW7eDAvgbFuzJOBbxuStbe+rDHXXWOJ3N3dHGqDpfJlnoTyVxTD /dk3sPD334k5O+9vpYlruYOHeG1T3d5qxCOO4v7tFvfV+bvsOMTGsRGKJ5gucC2jdF2R waDiOBhV/X7vft81nbteKPu3uLydKdSIlj6fVd+PstBcff11e2MCMMf2/RckKBhlVimw S2cFeFX4z6Zt+Q8/JsEDLuuafQPMR5KiqCsul71IMDFHoBKrLq7Mg7qZjgHW1LvT3iSR Kw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3ad56q40cq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Aug 2021 18:19:10 -0400 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 17CM81R9084818; Thu, 12 Aug 2021 18:19:10 -0400 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 3ad56q40cf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Aug 2021 18:19:10 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 17CMHfJJ017338; Thu, 12 Aug 2021 22:19:09 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma03wdc.us.ibm.com with ESMTP id 3a9htf3bdr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Aug 2021 22:19:09 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 17CMJ8TW20251116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Aug 2021 22:19:08 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ADD6F28065; Thu, 12 Aug 2021 22:19:08 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ACFAB28060; Thu, 12 Aug 2021 22:19:07 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 12 Aug 2021 22:19:07 +0000 (GMT) Subject: Re: [edk2-devel] [PATCH v4 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms To: Sean Brogan , devel@edk2.groups.io, stefanb@linux.vnet.ibm.com, jiewen.yao@intel.com Cc: marcandre.lureau@redhat.com, lersek@redhat.com, dick_wilkins@phoenix.com, James.Bottomley@HansenPartnership.com References: <20210812165931.3071083-1-stefanb@linux.vnet.ibm.com> <20210812165931.3071083-2-stefanb@linux.vnet.ibm.com> From: "Stefan Berger" Message-ID: <649733db-0d37-326e-5f83-f6f8ad500cdd@linux.ibm.com> Date: Thu, 12 Aug 2021 18:19:07 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: EAzrKNCzZdnCHcJn0vlDRMFfRyQZHi_p X-Proofpoint-GUID: fgscoeBCfJytw52a2f51jA-B1reflpaG X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-12_06:2021-08-12,2021-08-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108120140 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-001b2d01.pphosted.com id 17CM88gF085537 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/12/21 4:59 PM, Sean Brogan wrote: > This seems like a bad place for a general purpose lib that many other=20 > platforms may take a dependency on. > > In v1 this was SecurityPkg.=C2=A0 OvmfPkg is a platform package and=20 > therefore not a good place to define broad interfaces. > > What caused this to move here? Option 2 from this message:=20 https://listman.redhat.com/archives/edk2-devel-archive/2021-August/msg003= 98.html =C2=A0 Stefan > > Thanks > Sean > >