From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.11202.1582114384613288820 for ; Wed, 19 Feb 2020 04:13:04 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: kathappan.esakkithevar@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2020 04:13:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,459,1574150400"; d="scan'208";a="434459499" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 19 Feb 2020 04:13:04 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Feb 2020 04:13:04 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 19 Feb 2020 04:13:03 -0800 Received: from bgsmsx153.gar.corp.intel.com (10.224.23.4) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 19 Feb 2020 04:13:03 -0800 Received: from bgsmsx102.gar.corp.intel.com ([169.254.2.129]) by BGSMSX153.gar.corp.intel.com ([169.254.2.95]) with mapi id 14.03.0439.000; Wed, 19 Feb 2020 17:41:13 +0530 From: "Kathappan Esakkithevar" To: "Chaganty, Rangasai V" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Kethi Reddy, Deepika" , "Agyeman, Prince" Subject: Re: [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg Thread-Topic: [edk2-platforms] [PATCH V1 2/2] Enable build for CometlakeOpenBoardPkg Thread-Index: AQHV5mtfFl1aQ2AZZ0qEkhyttlVa0KgiJIGggABIoLA= Date: Wed, 19 Feb 2020 12:11:12 +0000 Message-ID: <64BE5F5EBA45054E91852F30711921D219E2989B@BGSMSX102.gar.corp.intel.com> References: <20200218145343.11820-1-kathappan.esakkithevar@intel.com> <20200218145343.11820-3-kathappan.esakkithevar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Return-Path: kathappan.esakkithevar@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sai,=20 I have updated the feedback comments and please help to review at [edk2-dev= el] [edk2-platforms] [PATCH V2 2/2] Enable build for CometlakeOpenBoardPkg For comment : > [Sai]: typo - it should be "following"=20 I saw the Readme.md , below statement is correct as below at line 45.=20 "A UEFI firmware implementation using MinPlatformPkg is constructed using t= he following pieces." Not sure why we are seeing below trimmed lines at patches.=20 "@@ -53,9 +53,10 @@ A UEFI firmware implementation using MinPlatformPkg is = constructed using the fol" "@@ -237,6 +239,11 @@ return back to the minimum platform caller." > -----Original Message----- > From: Chaganty, Rangasai V > Sent: Wednesday, February 19, 2020 1:20 PM > To: Esakkithevar, Kathappan ; > devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Kethi Reddy, Deepika > ; Agyeman, Prince > > Subject: RE: [edk2-platforms] [PATCH V1 2/2] Enable build for > CometlakeOpenBoardPkg >=20 > Minor comments - Please see inline >=20 > Thanks, > Sai >=20 > -----Original Message----- > From: Esakkithevar, Kathappan > Sent: Tuesday, February 18, 2020 6:54 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Kethi Reddy, Deepika > ; Agyeman, Prince > > Subject: [edk2-platforms] [PATCH V1 2/2] Enable build for > CometlakeOpenBoardPkg >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2280 >=20 > This change adds the configuration to enable build for CometlakeURvp. > Also it updates Cometlake U Rvp details to the Readme.md. >=20 > Signed-off-by: Kathappan Esakkithevar > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Deepika Kethi Reddy > Cc: Prince Agyeman > --- > Platform/Intel/Readme.md | 11 +++++++++++ Platform/Intel/build.cfg | 3= ++- > 2 files changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index > 02d9517d19..b5ad8ed5fe 100644 > --- a/Platform/Intel/Readme.md > +++ b/Platform/Intel/Readme.md > @@ -56,6 +56,7 @@ A UEFI firmware implementation using MinPlatformPkg is > constructed using the fol > [Sai]: typo - it should be "following" > * The `KabylakeOpenBoardPkg` contains board implementations for Kaby Lak= e > systems. > * The `SimicsOpenBoardPkg` contains board implementations for the Simics > hardware simulator. > * The `WhiskeylakeOpenBoardPkg` contains board implementations for > Whiskey Lake systems. > +* The `CometlakeOpenBoardPkg` contains board implementations for Comet > Lake systems. > [Sai]: The systems names should be one word - e.g. CometLake ### > **Supported Hardware** >=20 > @@ -67,6 +68,7 @@ A UEFI firmware implementation using MinPlatformPkg is > constructed using the fol ----------------------------------------|-----= ------------------------ > ---------------|------------------------------|--------------------| > | RVP 3 | Sky Lake, Kaby Lake, Kaby Lake= Refresh | > KabylakeOpenBoardPkg | KabylakeRvp3 | > | WHL-U DDR4 RVP | Whiskey Lake = | > WhiskeylakeOpenBoardPkg | WhiskeylakeURvp | > +| CML-U LPDDR3 RVP | COmet Lake V1 = | > CometlakeOpenBoardPkg | CometlakeURvp | >=20 > *Note: RVP =3D Reference and Validation Platform* >=20 > @@ -237,6 +239,11 @@ return back to the minimum platform caller. > | | | |---build_config.cfg: Whiskey= lakeURvp specific build > | | | setting= s environment variables. > | | | > + | | |------CometlakeOpenBoardPkg > + | | | |------CometlakeURvp > + | | | |---build_config.cfg: Cometla= keURvp specific build > + | | | setting= s environment variables. > + | | | > |------FSP > >=20 > @@ -257,6 +264,10 @@ return back to the minimum platform caller. > 1. This firmware project has only been tested booting to Microsoft Windo= ws > 10 x64 with AHCI mode and Integrated Graphic > Device. >=20 > +**CometlakeOpenBoardPkg** > +1. This firmware project has been tested booting to Microsoft Windows 10 > x64 with AHCI mode and External Graphic Device. > +2. This firmware project has been also tested booting to Ubuntu 17.10 wi= th > AHCI mode and Integrated Graphic Device. > + > ### **Package Builds** >=20 > In some cases, such as BoardModulePkg, a package may provide a set of > functionality that is included in other diff --git a/Platform/Intel/build= .cfg > b/Platform/Intel/build.cfg index 86a9115021..5bc1dea43c 100644 > --- a/Platform/Intel/build.cfg > +++ b/Platform/Intel/build.cfg > @@ -1,7 +1,7 @@ > # @ build.cfg > # This is the main/default build configuration file # -# Copyright (c) = 2019, Intel > Corporation. All rights reserved.
> +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent # >=20 > @@ -58,3 +58,4 @@ BoardX58Ich10 =3D > SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg > GalagoPro3 =3D KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > KabylakeRvp3 =3D KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > WhiskeylakeURvp =3D > WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg > +CometlakeURvp =3D CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg > -- > 2.16.2.windows.1 >=20