From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.1152.1587712175997656598 for ; Fri, 24 Apr 2020 00:09:36 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: kathappan.esakkithevar@intel.com) IronPort-SDR: yAC3+zW025cwHdAIDINuuoe7SO8lz2gWe/v9ny2P3Xb8BM3/FUYVRLw1kPIqQyU/JbTBVqt29v BVu9pBGiAYjw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2020 00:09:34 -0700 IronPort-SDR: CUGFc5EsmSGJVY6/61lunN89trBPxSOIBgBUSRgJqbyAcOJ7wofpqK/vbfVkDFUy16blSAT2pz a7RFa2oBrVtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,310,1583222400"; d="scan'208";a="366261413" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 24 Apr 2020 00:09:23 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Apr 2020 00:09:22 -0700 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Apr 2020 00:09:22 -0700 Received: from bgsmsx102.gar.corp.intel.com ([169.254.2.58]) by BGSMSX107.gar.corp.intel.com ([169.254.9.214]) with mapi id 14.03.0439.000; Fri, 24 Apr 2020 12:39:15 +0530 From: "Kathappan Esakkithevar" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" , "Kethi Reddy, Deepika" , "Agyeman, Prince" , Michael Kubacki Subject: Re: [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver Thread-Topic: [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver Thread-Index: AQHWGB0lrYefM56rgUuPQ+12t9AuyqiH3gWg Date: Fri, 24 Apr 2020 07:09:15 +0000 Message-ID: <64BE5F5EBA45054E91852F30711921D219EDC9CD@BGSMSX102.gar.corp.intel.com> References: <20200421204028.10410-1-nathaniel.l.desimone@intel.com> <20200421204028.10410-2-nathaniel.l.desimone@intel.com> In-Reply-To: <20200421204028.10410-2-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Return-Path: kathappan.esakkithevar@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Kathappan Esakkithevar =20 > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, April 22, 2020 2:10 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > ; Agyeman, Prince > ; Michael Kubacki > > Subject: [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS > Hook Dxe Driver >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 >=20 > Added a DXE driver that registers the minimum platform BDS hook points, t= o > WhiskeylakeURvp board. > These hooks are triggered on the BDS hook events >=20 > What was done: >=20 > * Included an instance of BdsHookLib and BoardBootManagerLib from > BoardModulePkg >=20 > * Included BdsHookDxe to register the callbacks implemented in BdsHookLib >=20 > Signed-off-by: Nate DeSimone > Cc: Chasel Chiu > Cc: Rangasai V Chaganty > Cc: Deepika Kethi Reddy > Cc: Kathappan Esakkithevar > Cc: Prince Agyeman > Cc: Michael Kubacki > --- > .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 4 ++++ > .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf | 1 + > 2 files changed, 5 insertions(+) >=20 > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > dsc > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > dsc > index 14e82ba34d..958a2d0c50 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > dsc > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > ds > +++ c > @@ -224,6 +224,8 @@ > ####################################### >=20 > DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePoli > cyUpdateLib/DxePolicyUpdateLib.inf >=20 > DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeT > btPolicyLib/DxeTbtPolicyLib.inf > + > + > BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHo > okLib > + .inf > + > BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/Boa > rdBo > + otManagerLib.inf >=20 > ####################################### > # Board-specific > @@ -452,3 +454,5 @@ > $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf > !endif > BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > + > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.f > df > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.f > df > index e2d40bcbb6..31f4d22311 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.f > df > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.f > d > +++ f > @@ -346,6 +346,7 @@ INF > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe. > inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf >=20 > INF ShellPkg/Application/Shell/Shell.inf >=20 > -- > 2.26.0.windows.1