From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.5859.1589426216961270441 for ; Wed, 13 May 2020 20:16:57 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: kathappan.esakkithevar@intel.com) IronPort-SDR: 4shp2jUllfklCIgjFisVduIXMW3qd2dVzokWoqe81u1p9BtkAyTLha1+QhqYQzGxRsQcw82eoB rvLcz4M2cB8A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 20:16:48 -0700 IronPort-SDR: u2cjY1uLTuzK+zziWoF3akm0QRWS1tw8lqrkPB9vdjYe++GTJn8BC8L+Q2Piv2KRbrprMuYu62 rqot9ggJVrkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="251957184" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 13 May 2020 20:16:48 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 20:16:48 -0700 Received: from BGSMSX108.gar.corp.intel.com (10.223.4.192) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 20:16:47 -0700 Received: from bgsmsx102.gar.corp.intel.com ([169.254.2.58]) by BGSMSX108.gar.corp.intel.com ([169.254.8.215]) with mapi id 14.03.0439.000; Thu, 14 May 2020 08:46:44 +0530 From: "Kathappan Esakkithevar" To: "Dong, Eric" , "devel@edk2.groups.io" , "Chaganty, Rangasai V" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Kethi Reddy, Deepika" Subject: Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit Thread-Topic: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit Thread-Index: AQHWKIJ3Ol6hEFc2xE2WnLuqtWSRB6ilJNTQgAFKtICAAHuXQA== Date: Thu, 14 May 2020 03:16:43 +0000 Message-ID: <64BE5F5EBA45054E91852F30711921D219EFF49A@BGSMSX102.gar.corp.intel.com> References: <20200512172555.56680-1-kathappan.esakkithevar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Return-Path: kathappan.esakkithevar@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Eric!! > -----Original Message----- > From: Dong, Eric > Sent: Thursday, May 14, 2020 6:54 AM > To: devel@edk2.groups.io; Chaganty, Rangasai V > ; Esakkithevar, Kathappan > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Kethi Reddy, Deepika > > Subject: RE: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix buil= d > error due to Ddr4MixedUDimm2DpcLimit >=20 > Hi all, >=20 > Seems this patch has passed code review. > Also, it used to fix a platform build failure, and other patches will be= blocked > if this platform build failure, so I help to push the code change. >=20 > Pushed: SHA-1: c2cb5a4d1b54e8fe79fe1c1132034989597fee10 >=20 >=20 > Thanks, > Eric >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > Chaganty, Rangasai V > > Sent: Wednesday, May 13, 2020 8:11 AM > > To: Esakkithevar, Kathappan ; > > devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > ; Kethi Reddy, Deepika > > > > Subject: Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix > > build error due to Ddr4MixedUDimm2DpcLimit > > > > Reviewed-by: Sai Chaganty > > > > -----Original Message----- > > From: Esakkithevar, Kathappan > > Sent: Tuesday, May 12, 2020 10:26 AM > > To: devel@edk2.groups.io > > Cc: Chaganty, Rangasai V ; Chiu, Chasel > > ; Desimone, Nathaniel L > > ; Kethi Reddy, Deepika > > > > Subject: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to > > Ddr4MixedUDimm2DpcLimit > > > > The Ddr4MixedUDimm2DpcLimit FSP-M Upd has been renamed as > > Ddr4Mixed2DpcLimit at CometLakeFspBinPkg\CometLake1. > > FSP wrapper driver need to use FSP-M Upd name Ddr4Mixed2DpcLimit > from > > CometLake1 FSP at CometlakeOpenBoardPkg. > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2714 > > > > Signed-off-by: Kathappan Esakkithevar > > > > Cc: Sai Chaganty > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Deepika Kethi Reddy > > --- > > .../FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c = | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > > a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic > > yInitLib/PeiFspSaPolicyInitLib.c > > > b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic > > yInitLib/PeiFspSaPolicyInitLib.c > > index 45d76ad5e4..53f26d824f 100644 > > --- > > > a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic > > yInitLib/PeiFspSaPolicyInitLib.c > > +++ > > b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPoli > > +++ cyInitLib/PeiFspSaPolicyInitLib.c > > @@ -344,7 +344,7 @@ PeiFspSaPolicyInitPreMem ( > > FspmUpd->FspmConfig.GdxcIotSize =3D MemConfig->GdxcIotS= ize; > > FspmUpd->FspmConfig.GdxcMotSize =3D MemConfig->GdxcMotS= ize; > > FspmUpd->FspmConfig.DualDimmPerChannelBoardType =3D(UINT8) > > MemConfig->DualDimmPerChannelBoardType; > > - FspmUpd->FspmConfig.Ddr4MixedUDimm2DpcLimit =3D(UINT8) > > MemConfig->Ddr4MixedUDimm2DpcLimit; > > + FspmUpd->FspmConfig.Ddr4Mixed2DpcLimit =3D(UINT8) MemConfig- > > >Ddr4MixedUDimm2DpcLimit; > > // > > // Update UPD:CaVrefConfig > > // > > -- > > 2.16.2.windows.1 > > > > > >=20 >=20