From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Laszlo Ersek <lersek@redhat.com>,
devel@edk2.groups.io, bret.barkelew@microsoft.com,
Bret Barkelew <bret@corthon.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
Dandan Bi <dandan.bi@intel.com>,
Chao Zhang <chao.b.zhang@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Hao A Wu <hao.a.wu@intel.com>,
"liming.gao" <liming.gao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Andrew Fish <afish@apple.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature
Date: Wed, 23 Sep 2020 12:17:08 +0200 [thread overview]
Message-ID: <64b7b95c-0a8b-9ab1-8e85-ccc0610d6bad@arm.com> (raw)
In-Reply-To: <d4ac463f-7581-6300-421a-4113a9e8c5f7@redhat.com>
On 9/23/20 12:04 PM, Laszlo Ersek wrote:
> On 09/23/20 11:43, Laszlo Ersek wrote:
>> On 09/23/20 11:22, Ard Biesheuvel wrote:
>>> On 9/23/20 10:45 AM, Laszlo Ersek wrote:
>>>> On 09/23/20 08:12, Bret Barkelew via groups.io wrote:
>>>>> To whom it may concern,
>>>>> This is as done as it’s going to get.
>>>>>
>>>>> Thank you all for your help!
>>>>
>>>> Seems like it's been fully reviewed. If that's the case -- do you want
>>>> me to merge it?
>>>>
>>>> (Asking because the series modifies multiple packages, so there isn't a
>>>> maintainer that's uniquely responsible for merging the series.)
>>>>
>>>
>>> Yes, please. This has been going on long enough.
>>>
>>> Only question I have is breakage in edk2-platforms - it seems that most
>>> platforms there are broken atm anyway due to the RngLib change having
>>> been merged, but it would be good to have an idea what the status is there.
>>>
>>
>> Judged from patches 05 through 08, the platforms in edk2-platforms are
>> going to need some new lib class resolutions. Therefore I think we might
>> have to merge this in two parts:
>>
>> - patches 01-08 in the first go,
>> - [update edk2-platforms to mimick patches 05-08],
>> - patches 09-14 in the second round.
>>
>> If Bret is OK with that, I can start merging 01-08 soon.
>>
>> (In theory, we could merge patches 05-08 as a part of the second round,
>> because technically, edk2-platforms only need 01-04. However, if some
>> commit messages in edk2-platforms would like to reference *example
>> platform code* from edk2, then having stable commit hashes for patches
>> 05-08 in edk2 would be useful. Hence my suggestion to include 05-08 in
>> the first round of edk2 merging.)
>
> ... on a second thought, we could merge this series in a single PR as
> well; only edk2-platforms would have to advance its edk2 submodule
> reference in two stages:
>
> - first advance the submodule to patch#8,
> - then update its own platform DSC files with the new lib instances,
> - then advance the edk2 submodule again, to patch#14.
>
> If that works for you, I think we should merge this edk2 set in one go
> -- less work for me, and much more intuitive when viewed from the edk2
> side. (The series would not be stuck in some half-merged state for any
> time at all.)
>
We don't actually use git submodules there, so this does not work.
But I am fine with just merging this, as edk2-platforms has been
reported to be in broken state anyway.
next prev parent reply other threads:[~2020-09-23 10:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 6:07 [PATCH v8 00/14] Add the VariablePolicy feature Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 01/14] MdeModulePkg: Define the VariablePolicy protocol interface Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 02/14] MdeModulePkg: Define the VariablePolicyLib Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 03/14] MdeModulePkg: Define the VariablePolicyHelperLib Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 04/14] MdeModulePkg: Define the VarCheckPolicyLib and SMM interface Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 05/14] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 06/14] EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 07/14] ArmVirtPkg: Add VariablePolicy engine to ArmVirtPkg platform Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 09/14] MdeModulePkg: Connect VariablePolicy business logic to VariableServices Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 10/14] MdeModulePkg: Allow VariablePolicy state to delete protected variables Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 11/14] SecurityPkg: Allow VariablePolicy state to delete authenticated variables Bret Barkelew
2020-09-23 6:11 ` Yao, Jiewen
2020-09-23 6:07 ` [PATCH v8 12/14] MdeModulePkg: Change TCG MOR variables to use VariablePolicy Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 13/14] MdeModulePkg: Drop VarLock from RuntimeDxe variable driver Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 14/14] MdeModulePkg: Add a shell-based functional test for VariablePolicy Bret Barkelew
2020-09-23 6:12 ` [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature Bret Barkelew
2020-09-23 8:45 ` [edk2-devel] " Laszlo Ersek
2020-09-23 9:22 ` Ard Biesheuvel
2020-09-23 9:43 ` Laszlo Ersek
2020-09-23 10:04 ` Laszlo Ersek
2020-09-23 10:17 ` Ard Biesheuvel [this message]
2020-09-23 19:46 ` Sean
2020-09-23 13:02 ` Laszlo Ersek
2020-09-23 21:14 ` Bret Barkelew
2020-09-23 21:32 ` Andrew Fish
2020-09-23 21:34 ` Bret Barkelew
2020-09-24 21:37 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64b7b95c-0a8b-9ab1-8e85-ccc0610d6bad@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox