From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 74332211BA45C for ; Fri, 25 Jan 2019 00:56:38 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3CA899DE0E; Fri, 25 Jan 2019 08:56:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-91.rdu2.redhat.com [10.10.120.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6652E17C3C; Fri, 25 Jan 2019 08:56:37 +0000 (UTC) To: "Feng, Bob C" References: <20190125045626.14700-1-bob.c.feng@intel.com> Cc: edk2-devel@lists.01.org, "Gao, Liming" From: Laszlo Ersek Message-ID: <64c49419-fe14-1be4-bfaf-1d601aedb294@redhat.com> Date: Fri, 25 Jan 2019 09:56:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190125045626.14700-1-bob.c.feng@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 25 Jan 2019 08:56:38 +0000 (UTC) Subject: Re: [Patch 00/33] BaseTools python3 migration patch set X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 08:56:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Bob, On 01/25/19 05:55, Feng, Bob C wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=55 > > This patch set is to enable python3 on BaseTools. Basetools code will be > compatible with both python3 and python2. > > We will have two envs PYTHON3_ENABLE and PYTHON_COMMAND. The behavior can be > combined as the below to support this usage. > If user wants the specific python interpreter, he only needs to set PYTHON_COMMAND env. > If PYTHON3_ENABLE is set, PYTHON_COMMAND will be set to the found one by edk2 scripts based on PYTHON3_ENABLE value. > If PYTHON3_ENABLE is not set, but PYTHON_COMMAND is set, then PYTHON_COMMAND will be used to run python script. No version check here. > If PYTHON3_ENABLE is not set, but PYTHON_COMMAND is not set, PYTHON_COMMAND will be set to the high version python installed in OS. > > This patch set is verified by basic testing on Ovmf, MinKabylake and MinPurley platform with Python3.7.1 and > minimal testing on Ovmf, MinKabylake and MinPurley with Python2.7.15. > > After this change, we will focus on the Python3 validation. > > You can also review and try the patch set at https://github.com/BobCF/edk2.git branch py3basetools (1) Have there been any fixes since my last testing at http://mid.mail-archive.com/dfc4af35-53e9-ab11-6582-1d0d8e9f2cde@redhat.com ? (2) My other question would have been about PYTHON3_ENABLE / PYTHON_COMMAND, since we discussed those in the same thread as well. But, your blurb explains them. So the test cases I plan to do are: - Test on RHEL7 (python2 only) without setting any variables. This would be used both for interactive builds and for package builds. - Test on RHEL8 without setting any variables. Expect python3 to be picked automatically. Used for interactive builds. - Test on RHEL8 with just PYTHON_COMMAND set, namely to "/usr/libexec/platform-python". Expect the python3 logic to be active. Would be used for package builds. Thanks! Laszlo