From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web08.44284.1606174345762243319 for ; Mon, 23 Nov 2020 15:32:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XUM7oK8E; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606174344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OyLVXPpwvfeP6J8dA08lI5wDKQ0yAQZdLGLNivXrtAU=; b=XUM7oK8EqwujWItgnEnWchz3WXZTCJuU80gmSWycvMJIFGPSJW4jzQ4YGznrNHKVky8OUB SJbYMvge1IiAivN/fX5Xf5WVC7ddlxgaaxCTc0nOgALazM7hjDalaQeDgXKt3AX7YyYC6h 89X1DI3RgK84YIg33x8l3ZRTGfcBpL8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-teTUn20RPSCvX8XPRn2grQ-1; Mon, 23 Nov 2020 18:32:21 -0500 X-MC-Unique: teTUn20RPSCvX8XPRn2grQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 83819184217B; Mon, 23 Nov 2020 23:32:19 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-230.ams2.redhat.com [10.36.112.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5D3360864; Mon, 23 Nov 2020 23:32:17 +0000 (UTC) Subject: Re: [PATCH 1/3] edk2: jansson submodule of JSON library To: Abner Chang , devel@edk2.groups.io Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Nickle Wang , Peter O'Hanley References: <20201123134722.15980-1-abner.chang@hpe.com> <20201123134722.15980-2-abner.chang@hpe.com> From: "Laszlo Ersek" Message-ID: <64c5fd1d-75f8-1e97-0207-c12e6276ca7c@redhat.com> Date: Tue, 24 Nov 2020 00:32:16 +0100 MIME-Version: 1.0 In-Reply-To: <20201123134722.15980-2-abner.chang@hpe.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/23/20 14:47, Abner Chang wrote: > Add jansson git submodule > > Signed-off-by: Abner Chang > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Nickle Wang > Cc: Peter O'Hanley > --- > .gitmodules | 3 +++ > MdeModulePkg/Library/JsonLib/jansson | 1 + > ReadMe.rst | 1 + > 3 files changed, 5 insertions(+) > create mode 160000 MdeModulePkg/Library/JsonLib/jansson > > diff --git a/.gitmodules b/.gitmodules > index c3a4e4aeca..77037b07b2 100644 > --- a/.gitmodules > +++ b/.gitmodules > @@ -17,3 +17,6 @@ > path = BaseTools/Source/C/BrotliCompress/brotli > url = https://github.com/google/brotli > ignore = untracked > +[submodule "MdeModulePkg/Library/JsonLib/jansson"] > + path = MdeModulePkg/Library/JsonLib/jansson > + url = https://github.com/akheron/jansson > diff --git a/MdeModulePkg/Library/JsonLib/jansson b/MdeModulePkg/Library/JsonLib/jansson > new file mode 160000 > index 0000000000..e9ebfa7e77 > --- /dev/null > +++ b/MdeModulePkg/Library/JsonLib/jansson > @@ -0,0 +1 @@ > +Subproject commit e9ebfa7e77a6bee77df44e096b100e7131044059 > diff --git a/ReadMe.rst b/ReadMe.rst > index c3c8178373..259739b5a3 100644 > --- a/ReadMe.rst > +++ b/ReadMe.rst > @@ -93,6 +93,7 @@ that are covered by additional licenses. > - `MdeModulePkg/Library/BrotliCustomDecompressLib/brotli `__ > - `MdeModulePkg/Universal/RegularExpressionDxe/oniguruma `__ > - `UnitTestFrameworkPkg/Library/CmockaLib/cmocka `__ > +- `MdeModulePkg/Library/JsonLib/jansson `__ (1) The link to the license file should not include a branch reference, such as "master", given that "master" is a moving target, and if the license of the subproject changes, we shouldn't silently advance to that, even with a documentation link like the one above. Instead, the link should point into the specific tree that our submodule actually references (namely the tree at commit e9ebfa7e77a6bee77df44e096b100e7131044059). The right link for that seems to be: https://github.com/akheron/jansson/blob/e9ebfa7e77a6bee77df44e096b100e7131044059/LICENSE (2) The commit message is nearly useless. It should state what we need the library for, and it should also highlight its license (MIT). The rest is for the MdeModulePkg reviewers to check. You forgot to CC them -- please use "BaseTools/Scripts/GetMaintainer.py". Thanks Laszlo > > The EDK II Project is composed of packages. The maintainers for each package > are listed in `Maintainers.txt `__. >