From: "Laszlo Ersek" <lersek@redhat.com>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io, Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Peter Grehan <grehan@freebsd.org>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH] OvmfPkg/Bhyve: Update Bhyve following changes to OVMF
Date: Fri, 13 Nov 2020 20:39:06 +0100 [thread overview]
Message-ID: <64f33e72-e334-8223-fabb-acd6d2a057b3@redhat.com> (raw)
In-Reply-To: <bbc47e97-7df8-649f-f45d-c29b60817146@bsdio.com>
On 11/12/20 06:41, Rebecca Cran wrote:
> On 11/11/20 12:57 PM, Laszlo Ersek wrote:
>
>>
>> Optimally, these changes should have been part of the SEV-ES feature
>> series, but we didn't realize. Sorry about the regression!
>
> I didn't expect people to take on the work of updating Bhyve when making
> incompatible changes to OvmfPkg, but that would be nice if they could!
>
> It's why I have a task to set up a Jenkins CI server, so I can catch
> regressions earlier. Being a lower priority platform, I suspect it's not
> something that should go into the existing Azure/Github based CI system.
Well, I'm torn. I'd really like the Bhyve platform to be covered with
the other OVMF DSC files, in the same CI system. On the other hand, I'm
aware that keeping OvmfPkg in the main edk2 repository is not
universally welcomed. If Bhyve required additional work (beyond the
usual OVMF DSC files) for merging a core package series (such as for
MdeModulePkg), *I* personally wouldn't be annoyed in the least ("just do
it"), but other contributors -- not as convinced about the benefits of
having Bhyve in-tree -- could be.
If you don't mind catching Bhyve build issues "slightly after the fact",
then I suggest sticking with the status quo. If you have more time to
spend, you can still catch regressions early -- watch out for OvmfPkg
patches, and whenever something is posted for OvmfPkg, push it through
your own CI, and report back *on the list at once* if your build breaks.
I guess you could even script this somehow.
Thanks!
Laszlo
prev parent reply other threads:[~2020-11-13 19:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 3:10 [PATCH] OvmfPkg/Bhyve: Update Bhyve following changes to OVMF Rebecca Cran
2020-11-11 19:57 ` Laszlo Ersek
2020-11-11 20:51 ` Lendacky, Thomas
2020-11-12 5:41 ` Rebecca Cran
2020-11-13 19:39 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64f33e72-e334-8223-fabb-acd6d2a057b3@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox