From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.506.1605296366699351963 for ; Fri, 13 Nov 2020 11:39:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ef6zjdZf; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605296365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eWxQYc7/7t+/wJJ5sV8SqiqkBJ8vz1NOAxrGOWEI7VA=; b=Ef6zjdZfdzAPxu1ON+VuZY+H1DXhL8/eKK2hKau87mxaGXJsDY8ikomYEYUPLp0wpL4Q6f Z61KSTQKLc2x5DJAm2VBM6YqRsLrncj/gfB6BybMOj6WlkZvYvdWRqq6zwCnHchh7Ty1Kq tLhg/aNYcVqLcX7lwn3Sco6h3N+T8TQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-491-UwJOoxh0MgGEPpPinRbVgg-1; Fri, 13 Nov 2020 14:39:22 -0500 X-MC-Unique: UwJOoxh0MgGEPpPinRbVgg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 260CC192FDA4; Fri, 13 Nov 2020 19:39:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-113.ams2.redhat.com [10.36.112.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9990F5BBCE; Fri, 13 Nov 2020 19:39:07 +0000 (UTC) Subject: Re: [PATCH] OvmfPkg/Bhyve: Update Bhyve following changes to OVMF To: Rebecca Cran Cc: devel@edk2.groups.io, Jordan Justen , Ard Biesheuvel , Peter Grehan , Tom Lendacky References: <20201111031006.33564-1-rebecca@bsdio.com> <28151b00-7744-ff98-ddd0-52ec527c6f1c@redhat.com> From: "Laszlo Ersek" Message-ID: <64f33e72-e334-8223-fabb-acd6d2a057b3@redhat.com> Date: Fri, 13 Nov 2020 20:39:06 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/12/20 06:41, Rebecca Cran wrote: > On 11/11/20 12:57 PM, Laszlo Ersek wrote: > >> >> Optimally, these changes should have been part of the SEV-ES feature >> series, but we didn't realize. Sorry about the regression! > > I didn't expect people to take on the work of updating Bhyve when making > incompatible changes to OvmfPkg, but that would be nice if they could! > > It's why I have a task to set up a Jenkins CI server, so I can catch > regressions earlier. Being a lower priority platform, I suspect it's not > something that should go into the existing Azure/Github based CI system. Well, I'm torn. I'd really like the Bhyve platform to be covered with the other OVMF DSC files, in the same CI system. On the other hand, I'm aware that keeping OvmfPkg in the main edk2 repository is not universally welcomed. If Bhyve required additional work (beyond the usual OVMF DSC files) for merging a core package series (such as for MdeModulePkg), *I* personally wouldn't be annoyed in the least ("just do it"), but other contributors -- not as convinced about the benefits of having Bhyve in-tree -- could be. If you don't mind catching Bhyve build issues "slightly after the fact", then I suggest sticking with the status quo. If you have more time to spend, you can still catch regressions early -- watch out for OvmfPkg patches, and whenever something is posted for OvmfPkg, push it through your own CI, and report back *on the list at once* if your build breaks. I guess you could even script this somehow. Thanks! Laszlo