Spell check corrections, package by package

Spell check corrections, package by package

[brbarkel]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

When we added the SpellCheck to CI, we intended to move through package by package and turn on the PR gate checks (right now they're all in "audit only"). To do this, we must first fix all the existing spelling errors and/or update the ignore lists and dictionaries with expected terms.

I would like to start this process so that we can get enforcement on in the next couple of months. To pick a random package, I was going to start with NetworkPkg. Before starting, I wanted to ask what the community would like to see in terms of the number of patches and/or associated bugs. I'm comfortable with whatever because I will likely automate the bug opening and patch association (so beware if you want one bug per fix... there will be a LOT of bugs).

Thoughts?

[-- Attachment #2: Type: text/html, Size: 782 bytes --]

Re: [edk2-devel] Spell check corrections, package by package

[Laszlo Ersek]

On 01/27/21 01:24, brbarkel via groups.io wrote:
> When we added the SpellCheck to CI, we intended to move through package by package and turn on the PR gate checks (right now they're all in "audit only"). To do this, we must first fix all the existing spelling errors and/or update the ignore lists and dictionaries with expected terms.
> 
> I would like to start this process so that we can get enforcement on in the next couple of months. To pick a random package, I was going to start with NetworkPkg. Before starting, I wanted to ask what the community would like to see in terms of the number of patches and/or associated bugs. I'm comfortable with whatever because I will likely automate the bug opening and patch association (so beware if you want one bug per fix... there will be a LOT of bugs).
> 
> Thoughts?

One BZ for OvmfPkg should work, with one associated patch series for
OvmfPkg. Each patch in the OvmfPkg series should fix typos in a given
module (library or driver or application) in OvmfPkg.

Duplicate all of the above for ArmVirtPkg (one BZ, one series, one patch
per module).

Thanks!
Laszlo

Re: [EXTERNAL] Re: [edk2-devel] Spell check corrections, package by package

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

Noted. I’ll see what that looks like. Thanks!

- Bret

From: Laszlo Ersek<mailto:lersek@redhat.com>
Sent: Wednesday, January 27, 2021 1:42 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] Re: [edk2-devel] Spell check corrections, package by package

On 01/27/21 01:24, brbarkel via groups.io wrote:
> When we added the SpellCheck to CI, we intended to move through package by package and turn on the PR gate checks (right now they're all in "audit only"). To do this, we must first fix all the existing spelling errors and/or update the ignore lists and dictionaries with expected terms.
>
> I would like to start this process so that we can get enforcement on in the next couple of months. To pick a random package, I was going to start with NetworkPkg. Before starting, I wanted to ask what the community would like to see in terms of the number of patches and/or associated bugs. I'm comfortable with whatever because I will likely automate the bug opening and patch association (so beware if you want one bug per fix... there will be a LOT of bugs).
>
> Thoughts?

One BZ for OvmfPkg should work, with one associated patch series for
OvmfPkg. Each patch in the OvmfPkg series should fix typos in a given
module (library or driver or application) in OvmfPkg.

Duplicate all of the above for ArmVirtPkg (one BZ, one series, one patch
per module).

Thanks!
Laszlo


[-- Attachment #2: Type: text/html, Size: 3358 bytes --]

回复: [EXTERNAL] Re: [edk2-devel] Spell check corrections, package by package

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 1995 bytes --]

One BZ is for one package. If few change is made for single module, I would
like to create one combined patch for one package. 

 

Thanks

Liming

发件人: bounce+27952+70825+4905953+8761045@groups.io
<bounce+27952+70825+4905953+8761045@groups.io> 代表 Bret Barkelew via
groups.io
发送时间: 2021年1月27日 18:20
收件人: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io
主题: Re: [EXTERNAL] Re: [edk2-devel] Spell check corrections, package by
package

 

Noted. I’ll see what that looks like. Thanks!

 

- Bret 

 

From: Laszlo Ersek <mailto:lersek@redhat.com> 
Sent: Wednesday, January 27, 2021 1:42 AM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Bret Barkelew
<mailto:Bret.Barkelew@microsoft.com> 
Subject: [EXTERNAL] Re: [edk2-devel] Spell check corrections, package by
package

 

On 01/27/21 01:24, brbarkel via groups.io wrote:
> When we added the SpellCheck to CI, we intended to move through package by
package and turn on the PR gate checks (right now they're all in "audit
only"). To do this, we must first fix all the existing spelling errors
and/or update the ignore lists and dictionaries with expected terms.
> 
> I would like to start this process so that we can get enforcement on in
the next couple of months. To pick a random package, I was going to start
with NetworkPkg. Before starting, I wanted to ask what the community would
like to see in terms of the number of patches and/or associated bugs. I'm
comfortable with whatever because I will likely automate the bug opening and
patch association (so beware if you want one bug per fix... there will be a
LOT of bugs).
> 
> Thoughts?

One BZ for OvmfPkg should work, with one associated patch series for
OvmfPkg. Each patch in the OvmfPkg series should fix typos in a given
module (library or driver or application) in OvmfPkg.

Duplicate all of the above for ArmVirtPkg (one BZ, one series, one patch
per module).

Thanks!
Laszlo

 




[-- Attachment #2: Type: text/html, Size: 5648 bytes --]