Hi Leif,

Please find my response inline.

On Thu, Dec 3, 2020 at 06:46 PM, Leif Lindholm wrote:

On Thu, Dec 03, 2020 at 11:03:59 +0700, Nhi Pham wrote:

This short patch series introduces the support for Ampere Computing's
Arm64 hardware platforms,
Well, it doesn't really, does it?
It adds a Maintainers.txt entry, a Readme.md describing a fork
somewhere, and links that Readme into the top-level one.

I think it's great you've posted it here for people to see, but can
you clarify your intent somewhat?
Is this a precursor to a full upstreaming effort?

Yes, this patch series works as bootstrap that we will push all Mt. Jade code in one shot (about 35 commits) to the edk2-platforms for review after this is approved and merged. This series provides Maintainers and Reviewers in the Maintainer.txt who are responsible for giving code review feedback (Reviewed-by tag) if stewards can not review a large patch series.

Thanks,
Nhi

I don't see a point in merging just this, although I can (and will)
provide some feedback on the documentation.

Best Regards,

Leif

specifically the Mt. Jade platform based on
Ampere's Altra Family processor at this moment.

A public fork of EDK2 for supporting Mt. Jade is currently available at
https://github.com/AmpereComputing/edk2-platforms

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Nhi Pham (1):
Maintainers.txt: Update for Ampere platforms

Phong Vo (2):
Platform/Ampere: Add Readme.md
Update Readme.md

Maintainers.txt | 6 +
Platform/Ampere/Readme.md | 167 ++++++++++++++++++++
Readme.md | 3 +
3 files changed, 176 insertions(+)
create mode 100644 Platform/Ampere/Readme.md

--
2.17.1