From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.groups.io with SMTP id smtpd.web10.22.1570725141686396787 for ; Thu, 10 Oct 2019 09:32:21 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2C4371DA3; Thu, 10 Oct 2019 16:32:21 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-48.rdu2.redhat.com [10.10.120.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 50DC560852; Thu, 10 Oct 2019 16:32:20 +0000 (UTC) Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions To: devel@edk2.groups.io, liming.gao@intel.com, "afish@apple.com" References: <1569570395-11240-1-git-send-email-liming.gao@intel.com> <1569570395-11240-6-git-send-email-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E5124C6@SHSMSX104.ccr.corp.intel.com> <39dad92d-917a-c6a4-05ff-8e32afd05533@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E515758@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <652367a4-4ebc-ae98-1c6c-d3feb04d1463@redhat.com> Date: Thu, 10 Oct 2019 18:32:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E515758@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Thu, 10 Oct 2019 16:32:21 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Liming, Andrew, On 10/10/19 14:32, Liming Gao wrote: > Laszlo: >=20 >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Wednesday, October 9, 2019 4:22 AM >> To: Gao, Liming ; devel@edk2.groups.io; afish@ap= ple.com >> Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Rem= ove __inline__ attribute for IO functions >> >> On 10/08/19 16:47, Gao, Liming wrote: >> >>> [Liming] I verify GCC5 tool chain. I will verify GCC48/GCC49 and >>> XCODE5. >>> >>> I don=E2=80=99t know the specific reason about __inline__. If the= re is no >>> impact on >>> >>> other GCC tool chain, I prefer to remove them. >> >>> [Liming] This seems the remaining clean up task. So, I prefer to remo= ve >>> __inline__ if no impact on GCC tool chain. >> >> OK. Given your testing with GCC48, I'm fine. >> > With this patch set, I verify GCC48/GCC49/GCC5 on Ovmf3264. They can al= l boot to Shell.=20 > Are they enough? Would you guys agree with the following commit message, on this patch? """ __inline__ has no discernible effect with the GCC48 / GCC49 / GCC5 toolchains, but it breaks the build with CLANG9. Remove __inline__. """ If you can update the commit message like that, then you can add: Acked-by: Laszlo Ersek Thanks! Laszlo