From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.6149.1582714083206765178 for ; Wed, 26 Feb 2020 02:48:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=L8TUFR8Q; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582714082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fpT8eEaeBhBCGor0BJ9h7Kc+tGjt+qafAqHHnjI5xBY=; b=L8TUFR8Qm1EMUfVyFoOV4Wmsj6/SmrtOLfJ5T3XSGXl7V4eHHOVCsO0EhdI0U4RKLBXmON qr9KfOGulHp6d9IaKf/93uHgAPTASW22OOgFOC8NAzd2aKAjj5ENKhRgKLkV2PccHzEouO N9MsWZUFz+mNrBCHggwpmWS/uxqDuhA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-LsWL6zdqOieG6t7--yXnMw-1; Wed, 26 Feb 2020 05:48:00 -0500 X-MC-Unique: LsWL6zdqOieG6t7--yXnMw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DFD5F107ACC7; Wed, 26 Feb 2020 10:47:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-185.ams2.redhat.com [10.36.116.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F2DA5C54A; Wed, 26 Feb 2020 10:47:55 +0000 (UTC) Subject: Re: [PATCH v3 0/6] Ovmf: enable TPM 1.2 To: marcandre.lureau@redhat.com, devel@edk2.groups.io Cc: simon.hardy@itdev.co.uk, stefanb@linux.ibm.com References: <20200226093459.1131530-1-marcandre.lureau@redhat.com> From: "Laszlo Ersek" Message-ID: <6525c251-a85b-26c6-4e2e-9b24a1860ed0@redhat.com> Date: Wed, 26 Feb 2020 11:47:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200226093459.1131530-1-marcandre.lureau@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/26/20 10:34, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Hi, >=20 > The following patches add basic TPM 1.2 support for Ovmf/QEMU. >=20 > Tested successfully Win10 with TIS/TPM 1.2 & CRB/TPM 2.0 passthrough, > and emulated CRB/TPM 2.0. >=20 > v3: > - send a TPM 1.2 command to test TPM version > - split the "Ovmf: enable TPM 1.2 support" patch, mirroring the TPM > 2.0 commits >=20 > Marc-Andr=C3=A9 Lureau (6): > OvmfPkg: rename TPM2 config prefix to TPM > OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei > OvmfPkg: include TcgPei module > OvmfPkg: include TcgDxe module > OvmfPkg: plug DxeTpmMeasureBootLib into SecurityStubDxe > OvmfPkg: add TCG Configuration menu to the Device Manager menu >=20 > OvmfPkg/OvmfPkgIa32.dsc | 39 ++++++++---- > OvmfPkg/OvmfPkgIa32.fdf | 10 +-- > OvmfPkg/OvmfPkgIa32X64.dsc | 39 ++++++++---- > OvmfPkg/OvmfPkgIa32X64.fdf | 10 +-- > OvmfPkg/OvmfPkgX64.dsc | 39 ++++++++---- > OvmfPkg/OvmfPkgX64.fdf | 10 +-- > OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf | 3 + > OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c | 81 +++++++++++++++++++----- > 8 files changed, 168 insertions(+), 63 deletions(-) >=20 I'm very happy with this series. I'd suggest posting v4 quickly (the updates should be minimal), so that Simon's testing can concentrate on v4. With Simon's feedback in place, I could merge v4 soon after edk2-stable202002 is tagged . Thank you, Marc-Andr=C3=A9! Laszlo