public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [PATCH v2 2/5] MdeModulePkg/DxeCapsuleLibFmp: permit ProcessCapsules () to be called once
Date: Fri, 8 Jun 2018 14:37:42 +0200	[thread overview]
Message-ID: <6534F306-C3E7-40D2-84F4-D409BF1F7B68@linaro.org> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AC3515B@shsmsx102.ccr.corp.intel.com>



> On 8 Jun 2018, at 14:34, Yao, Jiewen <jiewen.yao@intel.com> wrote:
> 
> Hi Ard
> We don't allow platform to update system firmware *after* EndOfDxe.
> 
> According to PI spec, after EndOfDxe, 3rd part code start running. It brings security risk if we allow system firmware after EndOfDxe.
> 
> In our X86 system design, we lock flash part *before* EndOfDxe in any boot mode.
> Even in CapsuleUpdate boot mode, we also lock flash part at EndOfDxe, just in case the capsule update does not indicate a reset.
> 
> Would you please share the info, why your platform need update system firmware after EndOfDxe?
> Is that possible to make it earlier?
> 
> 

Because we need some kind of console to report progress to the user.

The secure platform execution context is completely separate from UEFI on Arm, so for us the distinction does not make sense.

> Thank you
> Yao Jiewen
> 
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard
>> Biesheuvel
>> Sent: Friday, June 8, 2018 2:58 AM
>> To: edk2-devel@lists.01.org
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Yao, Jiewen
>> <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>;
>> leif.lindholm@linaro.org; Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Subject: [edk2] [PATCH v2 2/5] MdeModulePkg/DxeCapsuleLibFmp: permit
>> ProcessCapsules () to be called once
>> 
>> Permit ProcessCapsules () to be called only a single time, after
>> EndOfDxe. This allows platforms that are able to update system
>> firmware after EndOfDxe (e.g., because the flash ROM is not locked
>> down) to do so at a time when a non-trusted console is up and running,
>> and progress can be reported to the user.
>> 
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 18
>> ++++++++++++------
>> 1 file changed, 12 insertions(+), 6 deletions(-)
>> 
>> diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
>> b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
>> index 26ca4e295f20..ad83660f1737 100644
>> --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
>> +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
>> @@ -100,6 +100,7 @@ IsValidCapsuleHeader (
>> 
>> extern BOOLEAN                   mDxeCapsuleLibEndOfDxe;
>> BOOLEAN                          mNeedReset;
>> +BOOLEAN                          mFirstRound = TRUE;
>> 
>> VOID                        **mCapsulePtr;
>> EFI_STATUS                  *mCapsuleStatusArray;
>> @@ -364,8 +365,11 @@ PopulateCapsuleInConfigurationTable (
>> 
>>   Each individual capsule result is recorded in capsule record variable.
>> 
>> -  @param[in]  FirstRound         TRUE:  First round. Need skip the FMP
>> capsules with non zero EmbeddedDriverCount.
>> -                                 FALSE: Process rest FMP capsules.
>> +  @param[in]  FirstRound         Whether this is the first invocation
>> +  @param[in]  LastRound          Whether this is the last invocation
>> +                                 FALSE:  First of 2 rounds. Need skip the
>> FMP
>> +                                         capsules with non zero
>> EmbeddedDriverCount.
>> +                                 TRUE:   Process rest FMP capsules.
>> 
>>   @retval EFI_SUCCESS             There is no error when processing
>> capsules.
>>   @retval EFI_OUT_OF_RESOURCES    No enough resource to process
>> capsules.
>> @@ -373,7 +377,8 @@ PopulateCapsuleInConfigurationTable (
>> **/
>> EFI_STATUS
>> ProcessTheseCapsules (
>> -  IN BOOLEAN  FirstRound
>> +  IN BOOLEAN  FirstRound,
>> +  IN BOOLEAN  LastRound
>>   )
>> {
>>   EFI_STATUS                  Status;
>> @@ -453,7 +458,7 @@ ProcessTheseCapsules (
>>         continue;
>>       }
>> 
>> -      if ((!FirstRound) || (EmbeddedDriverCount == 0)) {
>> +      if (LastRound || (EmbeddedDriverCount == 0)) {
>>         DEBUG((DEBUG_INFO, "ProcessCapsuleImage - 0x%x\n",
>> CapsuleHeader));
>>         Status = ProcessCapsuleImage (CapsuleHeader);
>>         mCapsuleStatusArray [Index] = Status;
>> @@ -546,7 +551,7 @@ ProcessCapsules (
>>   EFI_STATUS                    Status;
>> 
>>   if (!mDxeCapsuleLibEndOfDxe) {
>> -    Status = ProcessTheseCapsules(TRUE);
>> +    Status = ProcessTheseCapsules(TRUE, FALSE);
>> 
>>     //
>>     // Reboot System if and only if all capsule processed.
>> @@ -555,8 +560,9 @@ ProcessCapsules (
>>     if (mNeedReset && AreAllImagesProcessed()) {
>>       DoResetSystem();
>>     }
>> +    mFirstRound = FALSE;
>>   } else {
>> -    Status = ProcessTheseCapsules(FALSE);
>> +    Status = ProcessTheseCapsules(mFirstRound, TRUE);
>>     //
>>     // Reboot System if required after all capsule processed
>>     //
>> --
>> 2.17.0
>> 
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-06-08 12:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08  6:58 [PATCH v2 0/5] MdeModulePkg ArmPkg: support for persistent capsules and progress reporting Ard Biesheuvel
2018-06-08  6:58 ` [PATCH v2 1/5] MdeModulePkg/CapsulePei: clean Dcache before consuming capsule data Ard Biesheuvel
2018-06-11 21:24   ` Ard Biesheuvel
2018-06-11 21:27     ` Yao, Jiewen
2018-06-11 21:28       ` Ard Biesheuvel
2018-06-11 21:40         ` Kinney, Michael D
2018-06-11 22:01           ` Ard Biesheuvel
2018-06-12  0:54             ` Kinney, Michael D
2018-06-12  9:01               ` Ard Biesheuvel
2018-06-12 10:31                 ` Ard Biesheuvel
2018-06-12 15:02                   ` Kinney, Michael D
2018-06-08  6:58 ` [PATCH v2 2/5] MdeModulePkg/DxeCapsuleLibFmp: permit ProcessCapsules () to be called once Ard Biesheuvel
2018-06-08 12:34   ` Yao, Jiewen
2018-06-08 12:37     ` Ard Biesheuvel [this message]
2018-06-10  5:38       ` Yao, Jiewen
2018-06-10  5:41         ` Ard Biesheuvel
2018-06-10 15:57           ` Kinney, Michael D
2018-06-10 19:01             ` Yao, Jiewen
2018-06-10 19:21               ` Yao, Jiewen
2018-06-11  7:27                 ` Ard Biesheuvel
2018-06-11 12:37                   ` Yao, Jiewen
2018-06-11 12:40                     ` Ard Biesheuvel
2018-06-11 13:55                       ` Yao, Jiewen
2018-06-11 14:06                         ` Ard Biesheuvel
2018-06-11 15:12                           ` Yao, Jiewen
2018-06-12  9:41                             ` Zeng, Star
2018-06-11 15:12                         ` Kinney, Michael D
2018-06-18 10:35     ` Udit Kumar
2018-06-18 14:59       ` Yao, Jiewen
2018-06-08  6:58 ` [PATCH v2 3/5] MdeModulePkg/DxeCapsuleLibFmp: pass progress callback only if it works Ard Biesheuvel
2018-06-08  6:58 ` [PATCH v2 4/5] ArmPkg/PlatformBootManagerLib: call ProcessCapsules() only once Ard Biesheuvel
2018-06-08  6:58 ` [PATCH v2 5/5] ArmPkg/ArmSmcPsciResetSystemLib: implement fallback for warm reboot Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6534F306-C3E7-40D2-84F4-D409BF1F7B68@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox