From: "Rebecca Cran" <rebecca@bsdio.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
devel@edk2.groups.io, "Jordan Justen" <jordan.l.justen@intel.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Ard Biesheuvel" <ard.biesheuvel@arm.com>,
"Andrew Fish" <afish@apple.com>,
"Leif Lindholm" <leif@nuviainc.com>,
"Michael D Kinney" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull
Date: Mon, 27 Apr 2020 11:33:06 -0600 [thread overview]
Message-ID: <654ce10b-e878-64df-9778-122d3454cc89@bsdio.com> (raw)
In-Reply-To: <d6ce2d28-6b02-b583-430f-655625fd1ae1@redhat.com>
On 4/27/20 3:03 AM, Philippe Mathieu-Daudé wrote:
>
>> +#include <Uefi.h>
>> +#include <Library/DebugLib.h>
>> +#include <IndustryStandard/QemuFwCfg.h>
>
> Don't you need <Library/QemuFwCfgLib.h>?
Hmm, you're right. I'm not sure where I got
"IndustryStandard/QemuFwCfg.h" from, though I noticed QemuFwCfg.h itself
includes a nonexistent version in IndustryStandard!
#ifndef __FW_CFG_LIB__
#define __FW_CFG_LIB__
#include <IndustryStandard/QemuFwCfg.h>
I'll fix this if/when I need to send a v5 series out, or since it
doesn't seem to do any harm in a later patch.
--
Rebecca Cran
next prev parent reply other threads:[~2020-04-27 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 18:29 [PATCH v4 0/6] Add BhyvePkg, to support the bhyve hypervisor Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 1/6] OvmfPkg: Add bhyve support into AcpiTimerLib Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull Rebecca Cran
2020-04-27 9:03 ` [edk2-devel] " Philippe Mathieu-Daudé
2020-04-27 17:33 ` Rebecca Cran [this message]
2020-04-28 11:27 ` Philippe Mathieu-Daudé
2020-04-28 16:12 ` Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 3/6] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 4/6] Add BhyvePkg, to support the bhyve hypervisor Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 5/6] BhyvePkg: Add PlatformPei Rebecca Cran
2020-04-24 18:29 ` [PATCH v4 6/6] BhyvePkg: Add AcpiPlatformDxe Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=654ce10b-e878-64df-9778-122d3454cc89@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox