From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by mx.groups.io with SMTP id smtpd.web12.236.1588008789773288561 for ; Mon, 27 Apr 2020 10:33:10 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: bsdio.com, ip: 166.70.13.232, mailfrom: rebecca@bsdio.com) Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jT7cy-0002C7-4P; Mon, 27 Apr 2020 11:33:08 -0600 Received: from mta3.zcs.xmission.com ([166.70.13.67]) by in01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jT7cx-00081V-Hq; Mon, 27 Apr 2020 11:33:07 -0600 Received: from localhost (localhost [127.0.0.1]) by mta3.zcs.xmission.com (Postfix) with ESMTP id 5AF94160AF8; Mon, 27 Apr 2020 11:33:07 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta3.zcs.xmission.com Received: from mta3.zcs.xmission.com ([127.0.0.1]) by localhost (mta3.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mpn5Qe7wbp7H; Mon, 27 Apr 2020 11:33:07 -0600 (MDT) Received: from [10.0.10.120] (muon.bluestop.org [65.103.231.193]) (Authenticated sender: rebecca@bsdio.com) by mta3.zcs.xmission.com (Postfix) with ESMTPSA id DFD71160CD0; Mon, 27 Apr 2020 11:33:06 -0600 (MDT) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io, Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Andrew Fish , Leif Lindholm , Michael D Kinney References: <20200424182914.138915-1-rebecca@bsdio.com> <20200424182914.138915-3-rebecca@bsdio.com> From: "Rebecca Cran" Message-ID: <654ce10b-e878-64df-9778-122d3454cc89@bsdio.com> Date: Mon, 27 Apr 2020 11:33:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: X-XM-SPF: eid=1jT7cx-00081V-Hq;;;mid=<654ce10b-e878-64df-9778-122d3454cc89@bsdio.com>;;;hst=in01.mta.xmission.com;;;ip=166.70.13.67;;;frm=rebecca@bsdio.com;;;spf=pass X-SA-Exim-Connect-IP: 166.70.13.67 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa04.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01,TooManyTo_001, TooManyTo_002,TooManyTo_003,TooManyTo_004,TooManyTo_005,XMSubLong, XM_B_Unicode autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5079] * 0.7 XMSubLong Long Subject * 0.5 TooManyTo_002 Multiple "To" Header Recipients 3x (uncommon) * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 0.6 TooManyTo_003 Multiple "To" Header Recipients 4x (uncommon) * 0.5 TooManyTo_004 Multiple "To" Header Recipients 5x (uncommon) * 0.4 TooManyTo_005 Multiple "To" Header Recipients 6x (uncommon) * 0.0 XM_B_Unicode BODY: Testing for specific types of unicode * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa04 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: =?ISO-8859-1?Q?**;Philippe Mathieu-Daud=c3=a9 , devel@edk2.groups.io, Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Andrew Fish , Leif Lindholm , Michael D Kinney ?= X-Spam-Relay-Country: X-Spam-Timing: total 303 ms - load_scoreonly_sql: 0.07 (0.0%), signal_user_changed: 11 (3.5%), b_tie_ro: 9 (3.0%), parse: 1.62 (0.5%), extract_message_metadata: 4.2 (1.4%), get_uri_detail_list: 0.51 (0.2%), tests_pri_-1000: 2.9 (1.0%), tests_pri_-950: 1.36 (0.4%), tests_pri_-900: 1.09 (0.4%), tests_pri_-90: 66 (21.6%), check_bayes: 64 (21.1%), b_tokenize: 6 (2.0%), b_tok_get_all: 5 (1.7%), b_comp_prob: 1.85 (0.6%), b_tok_touch_all: 49 (16.0%), b_finish: 0.77 (0.3%), tests_pri_0: 204 (67.4%), check_dkim_signature: 0.72 (0.2%), check_dkim_adsp: 30 (9.9%), poll_dns_idle: 23 (7.5%), tests_pri_10: 2.1 (0.7%), tests_pri_500: 6 (2.1%), rewrite_mail: 0.00 (0.0%) Subject: Re: [edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 4/27/20 3:03 AM, Philippe Mathieu-Daudé wrote: > >> +#include >> +#include >> +#include > > Don't you need ? Hmm, you're right. I'm not sure where I got "IndustryStandard/QemuFwCfg.h" from, though I noticed QemuFwCfg.h itself includes a nonexistent version in IndustryStandard! #ifndef __FW_CFG_LIB__ #define __FW_CFG_LIB__ #include I'll fix this if/when I need to send a v5 series out, or since it doesn't seem to do any harm in a later patch. -- Rebecca Cran