public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "IanX Kuo" <ianx.kuo@intel.com>
To: devel@edk2.groups.io
Cc: james.lu@intel.com, chandana.c.kumar@intel.com,
	varalakshmi.a.prabhala@intel.com, liming.gao@intel.com,
	IanX Kuo <ianx.kuo@intel.com>,
	Sai Chaganty <rangasai.v.chaganty@intel.com>,
	Chasel Chiu <chasel.chiu@intel.com>
Subject: [edk2-platforms] [PATCH v8 1/6] Platform/Intel/MinPlatformPkg: Fix build error
Date: Tue, 21 Jul 2020 15:29:19 +0800	[thread overview]
Message-ID: <6572feadeac4247cb1e6c0f679358000760c9ba2.1595315589.git.ianx.kuo@intel.com> (raw)
In-Reply-To: <cover.1595315589.git.ianx.kuo@intel.com>

1. Fix ReportCpuHobLib build error
2. Change MODULE from BASE to PEIM

Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overridden by Library instance in Platform.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674

Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
---
 .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c     | 3 ++-
 .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf   | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c
index aa2565343c..7eb29152f8 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c
@@ -6,7 +6,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
 
-#include <Base.h>
+#include <PiPei.h>
+#include <Library/BaseLib.h>
 #include <Library/HobLib.h>
 
 VOID
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
index a1830d4320..df1d780ece 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
@@ -12,7 +12,7 @@
   BASE_NAME                      = ReportCpuHobLib
   FILE_GUID                      = F19AA754-CE24-448D-B755-1F939B00C25D
   VERSION_STRING                 = 1.0
-  MODULE_TYPE                    = BASE
+  MODULE_TYPE                    = PEIM
   LIBRARY_CLASS                  = ReportCpuHobLib
 
 [LibraryClasses]
-- 
2.27.0.windows.1


  reply	other threads:[~2020-07-21  7:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21  7:28 [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
2020-07-21  7:29 ` IanX Kuo [this message]
2020-07-21  7:29 ` [edk2-platforms] [PATCH v8 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib IanX Kuo
2020-07-21  7:29 ` [edk2-platforms] [PATCH v8 3/6] Platform/Intel/KabylakeOpenBoardPkg: " IanX Kuo
2020-07-21  7:30 ` [edk2-platforms] [PATCH v8 4/6] Platform/Intel/SimicsOpenBoardPkg: " IanX Kuo
2020-07-21  7:30 ` [edk2-platforms] [PATCH v8 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: " IanX Kuo
2020-07-21  7:30 ` [edk2-platforms] [PATCH v8 6/6] Platform/Intel/MinPlatformPkg: " IanX Kuo
2020-07-21  9:11 ` [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib Liming Gao
2020-07-21 12:41 ` Chiu, Chasel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6572feadeac4247cb1e6c0f679358000760c9ba2.1595315589.git.ianx.kuo@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox