public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Joe L" <jlotwo@gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations
Date: Wed, 01 Nov 2023 13:17:27 -0700	[thread overview]
Message-ID: <6575.1698869847229215662@groups.io> (raw)
In-Reply-To: <CAMj1kXFow3Rp7hBFFVdtqR==ZEiXzcL1mWSr8SuwrNKS07Gw6w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

Thanks for the discussion,

Are we saying that DataSynchronizationBarrier () before the return from RootBridgeIoPciAccess() is not strong enough to determine that the final ECAM write would have completed? According to Learn the architecture - ARMv8-A memory systems ( https://developer.arm.com/documentation/100941/0101/Barriers ) the DSB should block "execution of any further instructions, not just loads or stores, until synchronization is complete". To me this means that for Arm the DSB will stall any subsequent instructions until the completion for the ECAM write is received by the processor.

Though if an architecture-agnostic solution is desired the readback before returning from RootBridgeIoPciAccess() does make sense. If the access spanned multiple DWORDs then should a read from the final aligned DWORD in the "buffer" be sufficient?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110489): https://edk2.groups.io/g/devel/message/110489
Mute This Topic: https://groups.io/mt/102310377/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1851 bytes --]

  reply	other threads:[~2023-11-01 20:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31 23:24 [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations Joe L
2023-11-01  2:09 ` Pedro Falcato
2023-11-01  9:56   ` Ard Biesheuvel
2023-11-01 12:25     ` Michael Brown
2023-11-01 12:51       ` Ard Biesheuvel
2023-11-01 13:23         ` Michael Brown
2023-11-01 16:41           ` Ard Biesheuvel
2023-11-01 20:17             ` Joe L [this message]
2023-11-01 21:51               ` Michael Brown
2023-11-01 23:07                 ` Pedro Falcato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6575.1698869847229215662@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox