Re: [PATCH 0/4] SataSiI3132Dxe fixes

[Jeremy Linton <jeremy.linton@arm.com>]

Hi,

On 10/27/2017 12:33 AM, Daniil Egranov wrote:
> This set of patches fixes an issue with 64-bit DMA and implements
> the missing exit boot event and driver stop functionality including
> memory/protocols cleanup procedure.
> 
> Daniil Egranov (4):
>    Drivers/SataSiI3132Dxe: Fixed PCI IO read and write operations
>    Drivers/SataSiI3132Dxe: Allow 64-bit DMA transfer
>    Drivers/SataSiI3132Dxe: Enable multi-controller support
>    Drivers/SataSiI3132Dxe: Fixed startup and shutdown procedures
> 
>   EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c   | 301 ++++++++++++++++-----
>   EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h   |  17 ++
>   .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c    |   4 +-
>   3 files changed, 252 insertions(+), 70 deletions(-)

This is generally good, but there remain quite a number of "errors" in 
the command submission path as well as the completely unnecessary 4k IO 
alignment requirement which has been known to break older grubs/etc. A 
few of those "errors" were fixed in this patch set (1) as well, so might 
be worthwhile if you are looking at this driver to integrate those fixes 
as well.

(1) https://lists.01.org/pipermail/edk2-devel/2017-March/008277.html

Thanks,