From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=jeremy.linton@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id A00D521F3B3F5 for ; Fri, 27 Oct 2017 09:53:23 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C32D1529; Fri, 27 Oct 2017 09:57:10 -0700 (PDT) Received: from [192.168.229.136] (unknown [10.118.28.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB1BD3F3E1; Fri, 27 Oct 2017 09:57:09 -0700 (PDT) To: Daniil Egranov , edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org References: <20171027053326.48815-1-daniil.egranov@arm.com> From: Jeremy Linton Message-ID: <658a30f2-d5f0-6022-988c-1071290bc76d@arm.com> Date: Fri, 27 Oct 2017 11:57:09 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171027053326.48815-1-daniil.egranov@arm.com> Subject: Re: [PATCH 0/4] SataSiI3132Dxe fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 16:53:23 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 10/27/2017 12:33 AM, Daniil Egranov wrote: > This set of patches fixes an issue with 64-bit DMA and implements > the missing exit boot event and driver stop functionality including > memory/protocols cleanup procedure. > > Daniil Egranov (4): > Drivers/SataSiI3132Dxe: Fixed PCI IO read and write operations > Drivers/SataSiI3132Dxe: Allow 64-bit DMA transfer > Drivers/SataSiI3132Dxe: Enable multi-controller support > Drivers/SataSiI3132Dxe: Fixed startup and shutdown procedures > > EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 301 ++++++++++++++++----- > EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 17 ++ > .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 4 +- > 3 files changed, 252 insertions(+), 70 deletions(-) This is generally good, but there remain quite a number of "errors" in the command submission path as well as the completely unnecessary 4k IO alignment requirement which has been known to break older grubs/etc. A few of those "errors" were fixed in this patch set (1) as well, so might be worthwhile if you are looking at this driver to integrate those fixes as well. (1) https://lists.01.org/pipermail/edk2-devel/2017-March/008277.html Thanks,