From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mx.groups.io with SMTP id smtpd.web11.5318.1681423482945309036 for ; Thu, 13 Apr 2023 15:04:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=VfBYcLON; spf=pass (domain: bsdio.com, ip: 64.147.123.20, mailfrom: rebecca@bsdio.com) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C5FA23200911; Thu, 13 Apr 2023 18:04:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 13 Apr 2023 18:04:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681423479; x=1681509879; bh=kuwTN7+3OWLrQcIas97zjM5O/3FtpFWyP8v xe53Q8oM=; b=VfBYcLONT/lWDZLVrGilfhAbNqVB5VdGQbiXQjjoWkGarQ/qcgW lx8wde2HIfNRvLO8uFGJjgp8P6WsEM2l8KXMGMOYIY+O2hlHk7wC7+GxeDlm6d+J dQ/VXqrx/N1LkN4uRWIbxbiqE/wBD5A4VNIKyw0SXffDMgw72vdFJorrvkyIV8aS UXnV6UjxcHfqziNOlJasg3pY+tWpukMFZMA5Mm2ic82YLuMpSLiYzl4AAy4sePpr XuLg67cqNQc53lsRMVSSnYCf0L+4jNKzG+I4DV/Mnj9oSCPB8jtzsqK3yBC/h6uF XvG39AewtOhEc0wsoCUtT3bgKVmtHhwiCjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681423479; x=1681509879; bh=kuwTN7+3OWLrQcIas97zjM5O/3FtpFWyP8v xe53Q8oM=; b=Tp36l0xl78Txxlnu6Vbjxj4Ym3Y0erAkHCdBEmI8hLqlLiq9En2 tpxhzgGvSScmx4cmWxscaPfRyCLoPWXzexdI9XqoivxzEFiUIXLbc++rF3zkXqNN YrE+P3JgYISD1yH3KRZbW6CKgYpLuuXYr4TC1Guo2wgYpCcEBVP2ob1F/Z/Kbx0B djZlrk7XhqYvfOY1nkMkrRM2ZIPw1/t/ordiJR38c7i//FFlVayUiYeyzTNgr+m8 2gHQwc+lMiQyjB6fUnNTc5MhaZcGap+gBcbHd+l7aV/bQJKEKXV+fF0ZpOredNo7 TGxdksKzmud+z/3B3Chf6jRsBZnpDl5FmvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekledgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Apr 2023 18:04:38 -0400 (EDT) Message-ID: <658b65fd-ea8b-bb91-c72a-5c0642623887@bsdio.com> Date: Thu, 13 Apr 2023 16:04:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH 1/1] Platform/ARM/JunoPkg: Don't setup PCIe root bridge for Juno-r0 To: devel@edk2.groups.io, pierre.gondois@arm.com Cc: Thomas Abraham , Ard Biesheuvel , Sami Mujawar , Fabien Ficheau References: <20230413131448.70329-1-Pierre.Gondois@arm.com> From: "Rebecca Cran" In-Reply-To: <20230413131448.70329-1-Pierre.Gondois@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/13/23 07:14, PierreGondois wrote: > diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c > index 0755dc155616..583efd0efb16 100644 > --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c > +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c > @@ -69,6 +69,13 @@ HWPciRbInit ( > UINTN TranslationTable; > EFI_CPU_IO2_PROTOCOL *CpuIo; > EFI_STATUS Status; > + UINT32 JunoRevision; > + > + GetJunoRevision (JunoRevision); > + DEBUG ((DEBUG_ERROR, "Juno rev=%d\n", JunoRevision)); Should that be DEBUG_INFO? Or is it DEBUG_ERROR because of the value of PcdDebugPrintErrorLevel which doesn't include INFO messages? I was just wondering a few days ago whether it should be 0x8000004F instead of 0x8000000F? -- Rebecca Cran