* [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility
@ 2020-05-19 12:36 Ard Biesheuvel
2020-05-19 13:18 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2020-05-19 12:36 UTC (permalink / raw)
To: devel; +Cc: leif, Ard Biesheuvel
Operator precedence is funny in DEPEX expressions, so let's add some
parentheses to make it self explanatory. The resulting truth value
is the same.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf b/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf
index 7e0d6bf21a35..3d9ca559e60b 100644
--- a/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf
+++ b/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf
@@ -43,4 +43,6 @@ [FixedPcd]
g96BoardsTokenSpaceGuid.PcdI2c1BusFrequencyHz
[Depex]
- g96BoardsMezzanineProtocolGuid AND g96BoardsI2c0MasterGuid OR g96BoardsI2c1MasterGuid
+ g96BoardsMezzanineProtocolGuid AND (
+ g96BoardsI2c0MasterGuid OR g96BoardsI2c1MasterGuid
+ )
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility
2020-05-19 12:36 [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility Ard Biesheuvel
@ 2020-05-19 13:18 ` Leif Lindholm
2020-05-19 13:26 ` [edk2-devel] " Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2020-05-19 13:18 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel
On Tue, May 19, 2020 at 14:36:58 +0200, Ard Biesheuvel wrote:
> Operator precedence is funny in DEPEX expressions, so let's add some
> parentheses to make it self explanatory. The resulting truth value
> is the same.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Thanks!
> ---
> Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf b/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf
> index 7e0d6bf21a35..3d9ca559e60b 100644
> --- a/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf
> +++ b/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf
> @@ -43,4 +43,6 @@ [FixedPcd]
> g96BoardsTokenSpaceGuid.PcdI2c1BusFrequencyHz
>
> [Depex]
> - g96BoardsMezzanineProtocolGuid AND g96BoardsI2c0MasterGuid OR g96BoardsI2c1MasterGuid
> + g96BoardsMezzanineProtocolGuid AND (
> + g96BoardsI2c0MasterGuid OR g96BoardsI2c1MasterGuid
> + )
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility
2020-05-19 13:18 ` Leif Lindholm
@ 2020-05-19 13:26 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2020-05-19 13:26 UTC (permalink / raw)
To: devel, leif
On 5/19/20 3:18 PM, Leif Lindholm via groups.io wrote:
> On Tue, May 19, 2020 at 14:36:58 +0200, Ard Biesheuvel wrote:
>> Operator precedence is funny in DEPEX expressions, so let's add some
>> parentheses to make it self explanatory. The resulting truth value
>> is the same.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-19 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-19 12:36 [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility Ard Biesheuvel
2020-05-19 13:18 ` Leif Lindholm
2020-05-19 13:26 ` [edk2-devel] " Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox