From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.11512.1589894791499643982 for ; Tue, 19 May 2020 06:26:31 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3179A30E; Tue, 19 May 2020 06:26:31 -0700 (PDT) Received: from [192.168.1.81] (unknown [10.37.8.132]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0EF1D3F52E; Tue, 19 May 2020 06:26:29 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility To: devel@edk2.groups.io, leif@nuviainc.com References: <20200519123658.21501-1-ard.biesheuvel@arm.com> <20200519131837.GA1923@vanye> From: "Ard Biesheuvel" Message-ID: <65c182cc-59f8-c34e-57a5-7fc7a6c1ea90@arm.com> Date: Tue, 19 May 2020 15:26:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200519131837.GA1923@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/19/20 3:18 PM, Leif Lindholm via groups.io wrote: > On Tue, May 19, 2020 at 14:36:58 +0200, Ard Biesheuvel wrote: >> Operator precedence is funny in DEPEX expressions, so let's add some >> parentheses to make it self explanatory. The resulting truth value >> is the same. >> >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm Pushed, thanks.