public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Daniel Schaefer" <daniel.schaefer@hpe.com>
To: "Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>,
	Barton Gao <gaojie@byosoft.com.cn>,
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
	Eric Jin <eric.jin@intel.com>, Arvin Chen <arvinx.chen@intel.com>,
	Leif Lindholm <leif@nuviainc.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: Re: [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms
Date: Thu, 4 Mar 2021 11:01:30 +0800	[thread overview]
Message-ID: <65ccc5d3-8af0-df5d-587c-c63e19cb4aee@hpe.com> (raw)
In-Reply-To: <CS1PR8401MB1144E37E5B5FB1599BAFFDBDFF9E9@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM>

On 2/25/21 2:56 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
> We unify build options to GCC:*_*_*_CC_FLAGS, but some options were added or removed to the specific arch
> e.g. for GCC:*_*_IA32_CC_FLAGS, -ffreestanding, -nostdinc, -nostdlib are added additionally because of GCC:*_*_*_CC_FLAGS?

As far as I can see GCC:*_*_IA32_CC_FLAGS had -ffreestanding, -nostdinc, -nostdlib even before. See below. Hence, no change with this patch.

> For GCC:*_*_AARCH64_CC_FLAGS,  some options were removed.

Yes, -Wno-error=unused-function -Wno-error=unused-but-set-variable were removed for some platforms.
But since all of the platforms already had -Wno-error (ignoring all errors), the build process shouldn't be affected.

> Are those option changes affect the original build process? Are this the necessary changes?

None of this is necessary but Leif requested me to clean up the flags in the last series of these patches.
I don't see any changes to the build process for other platforms.
Everything should be the same if I didn't make a mistake.

> Abner
> 
>> -----Original Message-----
>> From: Schaefer, Daniel
>> Sent: Tuesday, February 9, 2021 11:44 PM
>> To: devel@edk2.groups.io
>> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao
>> <gaojie@byosoft.com.cn>; Samer El-Haj-Mahmoud <Samer.El-Haj-
>> Mahmoud@arm.com>; Eric Jin <eric.jin@intel.com>; Arvin Chen
>> <arvinx.chen@intel.com>; Leif Lindholm <leif@nuviainc.com>; Heinrich
>> Schuchardt <xypron.glpk@gmx.de>; Chang, Abner (HPS SW/FW Technologist)
>> <abner.chang@hpe.com>
>> Subject: [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC
>> platforms
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
>>
>> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
>> Cc: Barton Gao <gaojie@byosoft.com.cn>
>> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>> Cc: Eric Jin <eric.jin@intel.com>
>> Cc: Arvin Chen <arvinx.chen@intel.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> Cc: Abner Chang <abner.chang@hpe.com>
>> Signed-off-by: Daniel Schaefer <daniel.schaefer@hpe.com>
>> ---
>>   uefi-sct/SctPkg/UEFI/IHV_SCT.dsc  | 15 ++++++++-------  uefi-
>> sct/SctPkg/UEFI/UEFI_SCT.dsc | 15 ++++++++-------
>>   2 files changed, 16 insertions(+), 14 deletions(-)
>>
>> diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-
>> sct/SctPkg/UEFI/IHV_SCT.dsc
>> index 94bb5c36..91116ca7 100644
>> --- a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
>> +++ b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
>> @@ -69,15 +69,16 @@
>>     MSFT:*_*_X64_APP_FLAGS   = /D EFIX64
>>     MSFT:*_*_X64_PP_FLAGS    = /D EFIX64
>>   -#  GCC:*_*_IA32_CC_FLAGS     = -D EFI32 $(GCC_VER_MACRO) -
>> ffreestanding -nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -
>> mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -

-ffreestanding, -nostdinc, -nostdlib already present.
However it's commented out before and after, so either way it doesn't make a difference.

>> D MDE_CPU_X32
>> -   GCC:*_*_IA32_CC_FLAGS     = -D EFIX64 $(GCC_VER_MACRO) -Wno-error
>> +   GCC:*_*_*_CC_FLAGS        = -ffreestanding -nostdinc -nostdlib -Wno-
>> error+#  GCC:*_*_IA32_CC_FLAGS     = -D EFI32 $(GCC_VER_MACRO) -mno-
>> red-zone -Wno-address -mno-stack-arg-probe "-
>> DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -D MDE_CPU_X32+
>> GCC:*_*_IA32_CC_FLAGS     = -D EFIX64 $(GCC_VER_MACRO) #
>> GCC:*_*_IA32_VFRPP_FLAGS  = -D EFI32 $(GCC_VER_MACRO) #
>> GCC:*_*_IA32_APP_FLAGS    = -D EFI32 $(GCC_VER_MACRO) #
>> GCC:*_*_IA32_PP_FLAGS     = -D EFI32 $(GCC_VER_MACRO) -#
>> GCC:*_*_X64_CC_FLAGS     = -D EFIX64 $(GCC_VER_MACRO) -ffreestanding
>> -nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-
>> arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -
>> mabi=ms -D MDE_CPU_X64
>> +#  GCC:*_*_X64_CC_FLAGS     = -D EFIX64 $(GCC_VER_MACRO) -mno-red-
>> zone -Wno-address -mno-stack-arg-probe "-
>> DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -mabi=ms -D
>> MDE_CPU_X64 -   GCC:*_*_X64_CC_FLAGS     = -D EFIX64
>> $(GCC_VER_MACRO) -Wno-error +   GCC:*_*_X64_CC_FLAGS     = -D EFIX64
>> $(GCC_VER_MACRO) #  GCC:*_*_X64_VFRPP_FLAGS  = -D EFIX64
>> $(GCC_VER_MACRO) #  GCC:*_*_X64_APP_FLAGS    = -D EFIX64
>> $(GCC_VER_MACRO) #  GCC:*_*_X64_PP_FLAGS     = -D EFIX64
>> $(GCC_VER_MACRO)@@ -85,7 +86,7 @@
>>      #TODO: OM - fixme RVCT:*_*_ARM_CC_FLAGS = -D EFIARM
>> $(GCC_VER_MACRO)   *_*_ARM_CC_FLAGS = -D EFIARM-
>> GCC:*_*_ARM_CC_FLAGS  = -D EFIARM $(GCC_VER_MACRO) -fno-stack-
>> protector -ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -
>> Wno-error=unused-but-set-variable -Wno-error=implicit-function-
>> declaration -Wno-error+  GCC:*_*_ARM_CC_FLAGS  = -D EFIARM
>> $(GCC_VER_MACRO) -fno-stack-protector   *_*_ARM_VFRPP_FLAGS   = -D
>> EFIARM $(GCC_VER_MACRO)   *_*_ARM_APP_FLAGS     = -D EFIARM
>> $(GCC_VER_MACRO)   *_*_ARM_PP_FLAGS      = -D EFIARM
>> $(GCC_VER_MACRO)@@ -104,14 +105,14 @@
>>     RVCT:*_*_ARM_CC_FLAGS    = --diag_remark=167 --
>> diag_suppress=167,1295,188,550,1,68,111,177    *_*_AARCH64_CC_FLAGS
>> = -D EFIAARCH64 $(GCC_VER_MACRO)-  GCC:*_*_AARCH64_CC_FLAGS     = -
>> D EFIAARCH64 $(GCC_VER_MACRO) -ffreestanding -nostdinc -nostdlib -
>> Wno-error=unused-function -Wno-error=unused-but-set-variable -Wno-
>> error+  GCC:*_*_AARCH64_CC_FLAGS     = -D EFIAARCH64
>> $(GCC_VER_MACRO)   *_*_AARCH64_VFRPP_FLAGS      = -D EFIAARCH64
>> $(GCC_VER_MACRO)   *_*_AARCH64_APP_FLAGS        = -D EFIAARCH64
>> $(GCC_VER_MACRO)   *_*_AARCH64_PP_FLAGS         = -D EFIAARCH64
>> $(GCC_VER_MACRO)   RVCT:*_*_AARCH64_DLINK_FLAGS = --muldefweak
>> *_*_RISCV64_CC_FLAGS         = -D EFIRISCV64 $(GCC_VER_MACRO)-
>> GCC:*_*_RISCV64_CC_FLAGS  = -D EFIRISCV64 $(GCC_VER_MACRO) -
>> ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -Wno-
>> error=unused-but-set-variable -Wno-error+  GCC:*_*_RISCV64_CC_FLAGS
>> = -D EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_VFRPP_FLAGS      = -D
>> EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_APP_FLAGS        = -D
>> EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_PP_FLAGS         = -D
>> EFIRISCV64 $(GCC_VER_MACRO)diff --git a/uefi-
>> sct/SctPkg/UEFI/UEFI_SCT.dsc b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
>> index e13e40e4..3bb57d26 100644
>> --- a/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
>> +++ b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
>> @@ -72,14 +72,15 @@
>>     MSFT:*_*_X64_APP_FLAGS   = /D EFIX64
>>     MSFT:*_*_X64_PP_FLAGS    = /D EFIX64
>>   -#  GCC:*_*_IA32_CC_FLAGS     = -D EFI32 $(GCC_VER_MACRO) -
>> ffreestanding -nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -
>> mno-stack-arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -
>> D MDE_CPU_X32
>> -  GCC:*_*_IA32_CC_FLAGS     = -D EFIX64 $(GCC_VER_MACRO) -Wno-error
>> +   GCC:*_*_*_CC_FLAGS        = -ffreestanding -nostdinc -nostdlib -Wno-
>> error+#  GCC:*_*_IA32_CC_FLAGS     = -D EFI32 $(GCC_VER_MACRO) -mno-
>> red-zone -Wno-address -mno-stack-arg-probe "-
>> DEFIAPI=__attribute__((ms_abi))" -m32 -mabi=ms -D MDE_CPU_X32
>> +  GCC:*_*_IA32_CC_FLAGS     = -D EFIX64 $(GCC_VER_MACRO) #
>> GCC:*_*_IA32_VFRPP_FLAGS  = -D EFI32 $(GCC_VER_MACRO) #
>> GCC:*_*_IA32_APP_FLAGS    = -D EFI32 $(GCC_VER_MACRO) #
>> GCC:*_*_IA32_PP_FLAGS     = -D EFI32 $(GCC_VER_MACRO) -#
>> GCC:*_*_X64_CC_FLAGS     = -D EFIX64 $(GCC_VER_MACRO) -ffreestanding
>> -nostdinc -nostdlib -Wno-error -mno-red-zone -Wno-address -mno-stack-
>> arg-probe "-DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -
>> mabi=ms -D MDE_CPU_X64
>> -   GCC:*_*_X64_CC_FLAGS     = -D EFIX64 $(GCC_VER_MACRO) -Wno-error
>> +#  GCC:*_*_X64_CC_FLAGS     = -D EFIX64 $(GCC_VER_MACRO) -mno-red-
>> zone -Wno-address -mno-stack-arg-probe "-
>> DEFIAPI=__attribute__((ms_abi))" -m64 -mcmodel=large -mabi=ms -D
>> MDE_CPU_X64
>> +   GCC:*_*_X64_CC_FLAGS     = -D EFIX64 $(GCC_VER_MACRO) #
>> GCC:*_*_X64_VFRPP_FLAGS  = -D EFIX64 $(GCC_VER_MACRO) #
>> GCC:*_*_X64_APP_FLAGS    = -D EFIX64 $(GCC_VER_MACRO) #
>> GCC:*_*_X64_PP_FLAGS     = -D EFIX64 $(GCC_VER_MACRO)@@ -87,7 +88,7
>> @@
>>      #TODO: OM - fixme RVCT:*_*_ARM_CC_FLAGS = -D EFIARM
>> $(GCC_VER_MACRO)   *_*_ARM_CC_FLAGS = -D EFIARM-
>> GCC:*_*_ARM_CC_FLAGS  = -D EFIARM $(GCC_VER_MACRO) -fno-stack-
>> protector -ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -
>> Wno-error=unused-but-set-variable -Wno-error=implicit-function-
>> declaration -Wno-error+  GCC:*_*_ARM_CC_FLAGS  = -D EFIARM
>> $(GCC_VER_MACRO) -fno-stack-protector   *_*_ARM_VFRPP_FLAGS   = -D
>> EFIARM $(GCC_VER_MACRO)   *_*_ARM_APP_FLAGS     = -D EFIARM
>> $(GCC_VER_MACRO)   *_*_ARM_PP_FLAGS      = -D EFIARM
>> $(GCC_VER_MACRO)@@ -106,14 +107,14 @@
>>     RVCT:*_*_ARM_CC_FLAGS    = --diag_remark=167 --
>> diag_suppress=167,1295,188,550,1,68,111,177    *_*_AARCH64_CC_FLAGS
>> = -D EFIAARCH64 $(GCC_VER_MACRO)-  GCC:*_*_AARCH64_CC_FLAGS     = -
>> D EFIAARCH64 $(GCC_VER_MACRO) -ffreestanding -nostdinc -nostdlib -
>> Wno-error=unused-function -Wno-error=unused-but-set-variable -Wno-
>> error+  GCC:*_*_AARCH64_CC_FLAGS     = -D EFIAARCH64
>> $(GCC_VER_MACRO)   *_*_AARCH64_VFRPP_FLAGS      = -D EFIAARCH64
>> $(GCC_VER_MACRO)   *_*_AARCH64_APP_FLAGS        = -D EFIAARCH64
>> $(GCC_VER_MACRO)   *_*_AARCH64_PP_FLAGS         = -D EFIAARCH64
>> $(GCC_VER_MACRO)   RVCT:*_*_AARCH64_DLINK_FLAGS = --muldefweak
>> *_*_RISCV64_CC_FLAGS         = -D EFIRISCV64 $(GCC_VER_MACRO)-
>> GCC:*_*_RISCV64_CC_FLAGS     = -D EFIRISCV64 $(GCC_VER_MACRO) -
>> ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -Wno-
>> error=unused-but-set-variable -Wno-error+  GCC:*_*_RISCV64_CC_FLAGS
>> = -D EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_VFRPP_FLAGS      = -D
>> EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_APP_FLAGS        = -D
>> EFIRISCV64 $(GCC_VER_MACRO)   *_*_RISCV64_PP_FLAGS         = -D
>> EFIRISCV64 $(GCC_VER_MACRO)--
>> 2.30.0
> 

  reply	other threads:[~2021-03-04  3:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 15:43 [edk2-test PATCHv2 0/5] Port SCT to RISCV64 Daniel Schaefer
2021-02-09 15:43 ` [edk2-test PATCHv2 1/5] SctPkg: Add RISCV64 support by using Aarch64 sources Daniel Schaefer
2021-02-25  2:44   ` Abner Chang
2021-02-09 15:43 ` [edk2-test PATCHv2 2/5] SctPkg: Adapt Aarch64 sources for Riscv64 Daniel Schaefer
2021-02-25  2:47   ` Abner Chang
2021-02-09 15:43 ` [edk2-test PATCHv2 3/5] SctPkg: Add RISCV64 build support Daniel Schaefer
2021-02-25  5:47   ` Abner Chang
2021-02-09 15:43 ` [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms Daniel Schaefer
2021-02-25  6:56   ` Abner Chang
2021-03-04  3:01     ` Daniel Schaefer [this message]
2021-02-09 15:43 ` [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace Daniel Schaefer
2021-02-20 16:04   ` Samer El-Haj-Mahmoud
2021-02-24  9:02   ` G Edhaya Chandran
2021-02-25  3:07     ` Abner Chang
2021-03-04  3:08       ` Daniel Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65ccc5d3-8af0-df5d-587c-c63e19cb4aee@hpe.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox