From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web12.9345.1601547840556367185 for ; Thu, 01 Oct 2020 03:24:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=L/YGzpp6; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601547839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B2Q2OaR05yJ5gYOIO7jX5qRBjZmjxO3WJOC/UlnmF8Y=; b=L/YGzpp6cZu4ApSbDympTZx2ZSbv7U1mRiZ/eQdjy7uo0ZKEJVwMkKguDtKoq8cY4XuTsO mQEdxxxLbnEYMn1XUuPjLZEbnKFVuZGlnziBG4H/rw20QFDFbRjL/8yq8W3WOfoO8z2qMB lRpHXbSahU+IGK51M/33d9U8KrqfvtU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-vgiA86-3O9mP5pqOUH39_g-1; Thu, 01 Oct 2020 06:23:55 -0400 X-MC-Unique: vgiA86-3O9mP5pqOUH39_g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0DD4F80B71B; Thu, 1 Oct 2020 10:23:54 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-110.ams2.redhat.com [10.36.113.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 72F4468431; Thu, 1 Oct 2020 10:23:52 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 1/1] UefipayloadPkg: Protect coreboot tables To: devel@edk2.groups.io, guo.dong@intel.com, Marcello Sylvester Bauer Cc: "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" References: <20200708120125.24344-1-marcello.bauer@9elements.com> <20200708120125.24344-2-marcello.bauer@9elements.com> From: "Laszlo Ersek" Message-ID: <65d39699-fc22-8362-ddb3-8c04e7129f5a@redhat.com> Date: Thu, 1 Oct 2020 12:23:51 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09/14/20 19:32, Guo Dong wrote: > > OK. Let me merge this patch firstly. /Guo The PR at failed 17 days ago and there have been no updates since, as far as I can tell. I've closed the PR for now. Thanks Laszlo > > From: Marcello Sylvester Bauer > Sent: Monday, September 14, 2020 2:00 AM > To: Dong, Guo > Cc: devel@edk2.groups.io; Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star > Subject: Re: [edk2-devel] [PATCH v1 1/1] UefipayloadPkg: Protect coreboot tables > > Hi Guo, > > Sounds like a good proposal, but it would be great to merge this change temporarily. > In some cases of the current implementation edk2 does override the memory area, where the coreboot table pointer is located. > Therefore the kernel and cbmem tool is not able to locate the tables anymore. > > Thanks, > Marcello > > On Tue, Sep 8, 2020 at 11:40 PM Dong, Guo > wrote: > > Hi Marcello, > > In the UEFI payload, we should not hardcoded any memory usage. It means UEFI payload should use the memory map whatever reported from the bootloader. I plan to remove this hardcoded memory usage soon. > Before that, it is OK for me to merge this change if you want. > BTW, did you see any issue with current implement? > > Thanks, > Guo > >> -----Original Message----- >> From: devel@edk2.groups.io > On Behalf Of Marcello >> Sylvester Bauer >> Sent: Wednesday, July 8, 2020 5:01 AM >> To: devel@edk2.groups.io >> Cc: Ma, Maurice >; Desimone, Nathaniel L >> >; Zeng, Star > >> Subject: [edk2-devel] [PATCH v1 1/1] UefipayloadPkg: Protect coreboot tables >> >> From: Patrick Rudolph > >> >> Signed-off-by: Patrick Rudolph > >> Signed-off-by: Marcello Sylvester Bauer > >> Cc: Maurice Ma > >> Cc: Nate DeSimone > >> Cc: Star Zeng > >> --- >> UefiPayloadPkg/BlSupportPei/BlSupportPei.c | 26 ++++++++++++++------ >> 1 file changed, 19 insertions(+), 7 deletions(-) >> >> diff --git a/UefiPayloadPkg/BlSupportPei/BlSupportPei.c >> b/UefiPayloadPkg/BlSupportPei/BlSupportPei.c >> index 22972453117a..b3ff065a537e 100644 >> --- a/UefiPayloadPkg/BlSupportPei/BlSupportPei.c >> +++ b/UefiPayloadPkg/BlSupportPei/BlSupportPei.c >> @@ -390,24 +390,36 @@ BlPeiEntryPoint ( >> EFI_PEI_GRAPHICS_DEVICE_INFO_HOB GfxDeviceInfo; >> >> EFI_PEI_GRAPHICS_DEVICE_INFO_HOB *NewGfxDeviceInfo; >> >> >> >> - >> >> - // >> >> - // Report lower 640KB of RAM. Attribute EFI_RESOURCE_ATTRIBUTE_TESTED >> >> - // is intentionally omitted to prevent erasing of the coreboot header >> >> - // record before it is processed by ParseMemoryInfo. >> >> + // Report lower 640KB of RAM. >> >> + // Mark memory as reserved to keep coreboot header in place. >> >> // >> >> BuildResourceDescriptorHob ( >> >> - EFI_RESOURCE_SYSTEM_MEMORY, >> >> + EFI_RESOURCE_MEMORY_RESERVED, >> >> ( >> >> EFI_RESOURCE_ATTRIBUTE_PRESENT | >> >> EFI_RESOURCE_ATTRIBUTE_INITIALIZED | >> >> + EFI_RESOURCE_ATTRIBUTE_TESTED | >> >> EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE | >> >> EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE | >> >> EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | >> >> EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE >> >> ), >> >> (EFI_PHYSICAL_ADDRESS)(0), >> >> - (UINT64)(0xA0000) >> >> + (UINT64)(0x1000) >> >> + ); >> >> + >> >> + BuildResourceDescriptorHob ( >> >> + EFI_RESOURCE_SYSTEM_MEMORY, >> >> + ( >> >> + EFI_RESOURCE_ATTRIBUTE_PRESENT | >> >> + EFI_RESOURCE_ATTRIBUTE_INITIALIZED | >> >> + EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE | >> >> + EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE | >> >> + EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | >> >> + EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE >> >> + ), >> >> + (EFI_PHYSICAL_ADDRESS)(0x1000), >> >> + (UINT64)(0x9F000) >> >> ); >> >> >> >> BuildResourceDescriptorHob ( >> >> -- >> 2.27.0 >> >> >> -=-=-=-=-=-= >> Groups.io Links: You receive all messages sent to this group. >> >> View/Reply Online (#62229): https://edk2.groups.io/g/devel/message/62229 >> Mute This Topic: https://groups.io/mt/75374752/1781375 >> Group Owner: devel+owner@edk2.groups.io >> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] >> -=-=-=-=-=-= > > > -- > [Marcello Sylvester Bauer] > > [http://static.9elements.com/logo-signature.png] > 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany > Email: [DEINE EMAIL ADDRESSE] > Phone: +49 234 68 94 188 > Mobile: +49 1722847618 > > Sitz der Gesellschaft: Bochum > Handelsregister: Amtsgericht Bochum, HRB 17519 > Geschäftsführung: Sebastian Deutsch, Eray Basar > > Datenschutzhinweise nach Art. 13 DSGVO > > >