public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre.Gondois@arm.com, devel@edk2.groups.io,
	Alexei.Fedorov@arm.com, Joey Gouly <joey.gouly@arm.com>,
	nd <nd@arm.com>
Subject: Re: [PATCH v2 00/10] Various DynamicTablesPkg modifications
Date: Fri, 1 Oct 2021 13:04:22 +0100	[thread overview]
Message-ID: <65eadf4f-a21b-11e2-9c4c-51d644007bb6@arm.com> (raw)
In-Reply-To: <20210930074821.12546-1-Pierre.Gondois@arm.com>

Merged as 422e5d2f7f1a..22873f58c40c

Regards,

Sami Mujawar


On 30/09/2021 08:48 AM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> This patch-set aggregates various modifications in the
> DynamicTablesPkg:
>   - Extract an AcpiTableHelperLib from TableHelperLib to remove
>     the dependency of some utility functions over configuration
>     manager definitions
>   - Add a HexFromAscii() function
>   - Add a AmlGetEisaIdFromString() function
>   - Add a configuration manager object parser
>   - Use %a instead of %s in when printing AmlLib
>   - Update the .ci.yaml once to prepare for other incoming patches
>   - Modify the generic prototype of the AmlResourceDataCodeGen
>     functions. This also means deprecating some functions.
>
> The modifications can be seen at: https://github.com/PierreARM/edk2/tree/1718_Various_DynamicTablesPkg_modifications_v2
>
> v2:
> - Corrections in commit messages. [Sami]
> - Document returned error code for some functions. [Sami]
> - Correct wrong field name in Configuration Manager Object parser.
>    [Joey]
>
> Pierre Gondois (9):
>    DynamicTablesPkg: Extract AcpiHelperLib from TableHelperLib
>    DynamicTablesPkg: Update TableHelperLib.inf
>    DynamicTablesPkg: Rename single char input parameter
>    DynamicTablesPkg: Add HexFromAscii() to AcpiHelperLib
>    DynamicTablesPkg: Add AmlGetEisaIdFromString() to AcpiHelperLib
>    DynamicTablesPkg: Use %a formatter in AmlDbgPrint
>    DynamicTablesPkg: Update DynamicTablesPkg.ci.yaml
>    DynamicTablesPkg: Deprecate Crs specific methods in AmlLib
>    DynamicTablesPkg: Rework AmlResourceDataCodegen.c/h
>
> Sami Mujawar (1):
>    DynamicTablesPkg: Add Configuration Manager Object parser
>
>   DynamicTablesPkg/DynamicTables.dsc.inc        |   3 +-
>   DynamicTablesPkg/DynamicTablesPkg.ci.yaml     |  29 +
>   DynamicTablesPkg/DynamicTablesPkg.dec         |   4 +
>   DynamicTablesPkg/DynamicTablesPkg.dsc         |   1 +
>   .../Include/Library/AcpiHelperLib.h           |  93 +++
>   .../Include/Library/AmlLib/AmlLib.h           | 225 ++++--
>   .../Include/Library/TableHelperLib.h          |  49 +-
>   .../SsdtCmn600Generator.c                     |  14 +-
>   .../AcpiSsdtCmn600LibArm/SsdtCmn600LibArm.inf |   3 +-
>   .../SsdtSerialPortGenerator.c                 |   3 +-
>   .../SsdtSerialPortLibArm.inf                  |   4 +-
>   .../Library/Common/AcpiHelperLib/AcpiHelper.c | 210 ++++++
>   .../Common/AcpiHelperLib/AcpiHelperLib.inf    |  25 +
>   .../Common/AmlLib/AmlDbgPrint/AmlDbgPrint.c   |  16 +-
>   .../Library/Common/AmlLib/AmlLib.inf          |   3 +-
>   .../Library/Common/AmlLib/Api/AmlApi.c        | 147 +++-
>   .../AmlLib/CodeGen/AmlResourceDataCodeGen.c   | 194 ++---
>   .../AmlLib/CodeGen/AmlResourceDataCodeGen.h   |  67 +-
>   .../SsdtSerialPortFixupLib.c                  |   6 +-
>   .../SsdtSerialPortFixupLib.inf                |   1 +
>   .../ConfigurationManagerObjectParser.c        | 678 ++++++++++++++++++
>   .../ConfigurationManagerObjectParser.h        |  73 ++
>   .../Common/TableHelperLib/TableHelper.c       |  96 ---
>   .../Common/TableHelperLib/TableHelperLib.inf  |  13 +-
>   24 files changed, 1579 insertions(+), 378 deletions(-)
>   create mode 100644 DynamicTablesPkg/Include/Library/AcpiHelperLib.h
>   create mode 100644 DynamicTablesPkg/Library/Common/AcpiHelperLib/AcpiHelper.c
>   create mode 100644 DynamicTablesPkg/Library/Common/AcpiHelperLib/AcpiHelperLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
>   create mode 100644 DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.h
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

      parent reply	other threads:[~2021-10-01 12:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30  7:48 [PATCH v2 00/10] Various DynamicTablesPkg modifications PierreGondois
2021-09-30  7:48 ` [PATCH v2 01/10] DynamicTablesPkg: Extract AcpiHelperLib from TableHelperLib PierreGondois
2021-09-30  7:48 ` [PATCH v2 02/10] DynamicTablesPkg: Update TableHelperLib.inf PierreGondois
2021-09-30  7:48 ` [PATCH v2 03/10] DynamicTablesPkg: Rename single char input parameter PierreGondois
2021-09-30  7:48 ` [PATCH v2 04/10] DynamicTablesPkg: Add HexFromAscii() to AcpiHelperLib PierreGondois
2021-09-30  7:48 ` [PATCH v2 05/10] DynamicTablesPkg: Add AmlGetEisaIdFromString() " PierreGondois
2021-09-30  7:48 ` [PATCH v2 06/10] DynamicTablesPkg: Add Configuration Manager Object parser PierreGondois
2021-09-30  7:48 ` [PATCH v2 07/10] DynamicTablesPkg: Use %a formatter in AmlDbgPrint PierreGondois
2021-09-30  7:48 ` [PATCH v2 08/10] DynamicTablesPkg: Update DynamicTablesPkg.ci.yaml PierreGondois
2021-09-30  7:48 ` [PATCH v2 09/10] DynamicTablesPkg: Deprecate Crs specific methods in AmlLib PierreGondois
2021-09-30  7:48 ` [PATCH v2 10/10] DynamicTablesPkg: Rework AmlResourceDataCodegen.c/h PierreGondois
2021-10-01 12:04 ` Sami Mujawar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65eadf4f-a21b-11e2-9c4c-51d644007bb6@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox