From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.79]) by mx.groups.io with SMTP id smtpd.web08.6877.1633089876969339030 for ; Fri, 01 Oct 2021 05:04:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=q9gC9zie; spf=pass (domain: arm.com, ip: 40.107.21.79, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FykBMXYEEQtSzjAvEuL2EpVfL0gv6L/O1ZeIZZSqUeY=; b=q9gC9ziepDBDuw3cYrdU4t5KWCdCHv14+p0O4+8+E1rc9TN7FlumgGQj1Mn5bfgT8XKEuZOw6dF9IFtcyKBuriuDqtJIoAdA46CHa/aK07pASYNsFI7rYsnbCk0OVND7iK0Or66RUBDzFfA+iI3KkmIBz0PDbOe6l2e7+Y5SBv4= Received: from AS8PR04CA0072.eurprd04.prod.outlook.com (2603:10a6:20b:313::17) by DB9PR08MB6362.eurprd08.prod.outlook.com (2603:10a6:10:25a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Fri, 1 Oct 2021 12:04:34 +0000 Received: from AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::ab) by AS8PR04CA0072.outlook.office365.com (2603:10a6:20b:313::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19 via Frontend Transport; Fri, 1 Oct 2021 12:04:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT029.mail.protection.outlook.com (10.152.16.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 12:04:33 +0000 Received: ("Tessian outbound a77cafe56b47:v103"); Fri, 01 Oct 2021 12:04:33 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6cece754c69ac06d X-CR-MTA-TID: 64aa7808 Received: from 6c5044d015c9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FD882F02-3F93-47F6-B3A7-3D9A098ADF81.1; Fri, 01 Oct 2021 12:04:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6c5044d015c9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 01 Oct 2021 12:04:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mw8qhtfTPN83Pb3woS/SgyZHoQ2+pQ29DIFl4Rf63Eu5evPEwKqlww38lzsJ+FQ3KqzoBvHNI1/eOJuVJg7RKIql6otnabrn5UkMeGQPpFxwkKvLCcu/dEYHggDdegOf1zWAnf6xPS6iXbcCUZE1ERmiufybhhhnSAq7QOjRQSZIX1PQ+ShvYsdf29WUUmh/ByR82/nLZgdpUAJ8XtZY+sDHQDWMFY+BncGMf9qlJTlg2p1s4KoC3CRjjVRj+btUsNsBungmJBYUNrr71nZ6po9BdhYjyzX5Ut1+Mdlf8Z5h6C2NlRFSDN+i5y8kiHDdDF6K6h9isUO2SmuZZolEIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FykBMXYEEQtSzjAvEuL2EpVfL0gv6L/O1ZeIZZSqUeY=; b=WldtLpHw9NZj6BmNd4p0hVmpvr4hvRuN8at12YuwBBcc3Jc5GJ9ghNSXh18O75iqqZYQSC/Q0/9YHhsZtFV9Go7JN1poDCZZbX1FjFCOPwJDbEh6hlEFnytpn0J1otk7n6TqW9PjN55J+vIQYc3QphMnfjTWITARg+V00CP3dd8fwDziLMO6fdvo+BAl2JS35c3Ysc2Ag3CJjupjgyosQZBNjIJeDhn4pIfxjFEEP0cCbL3aQi67kO2JB+OXs/Mzeer8aKaXmnC+I2EDfzk+heZMjIiTCP5aJudXf2P/3tuQ8pUY0IhgWO86RxzND9KDZoW/4JFP2aDo9aJ/QteM0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FykBMXYEEQtSzjAvEuL2EpVfL0gv6L/O1ZeIZZSqUeY=; b=q9gC9ziepDBDuw3cYrdU4t5KWCdCHv14+p0O4+8+E1rc9TN7FlumgGQj1Mn5bfgT8XKEuZOw6dF9IFtcyKBuriuDqtJIoAdA46CHa/aK07pASYNsFI7rYsnbCk0OVND7iK0Or66RUBDzFfA+iI3KkmIBz0PDbOe6l2e7+Y5SBv4= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4167.eurprd08.prod.outlook.com (2603:10a6:20b:ad::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Fri, 1 Oct 2021 12:04:19 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::c8a5:672a:9ff2:e554]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::c8a5:672a:9ff2:e554%6]) with mapi id 15.20.4566.019; Fri, 1 Oct 2021 12:04:19 +0000 Subject: Re: [PATCH v2 00/10] Various DynamicTablesPkg modifications To: Pierre.Gondois@arm.com, devel@edk2.groups.io, Alexei.Fedorov@arm.com, Joey Gouly , nd References: <20210930074821.12546-1-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: <65eadf4f-a21b-11e2-9c4c-51d644007bb6@arm.com> Date: Fri, 1 Oct 2021 13:04:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210930074821.12546-1-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0238.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::9) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO4P123CA0238.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19 via Frontend Transport; Fri, 1 Oct 2021 12:04:19 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb7d5a23-6b0f-4874-d7b1-08d984d3a1bc X-MS-TrafficTypeDiagnostic: AM6PR08MB4167:|DB9PR08MB6362: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:849;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: y9v0osAFZH11bXQ1rYgNhAP3pPCKXSoBowcmY7sCMioFA0Dqk4VehIb5wQtTMt1EsY6q2B8Ar5BQHDNex1+334IcYKk1ol4Ionsb4fidzzBLDVSTeZxB2nC811waimbatfWvy+ZTjGK21R7qRpSIZdnK29JX0sbXGFMl6XhD/IPM5UiC/tRgxWna0sF6XNh6cpTvHIJY2ffgHccPOO2fIrs7qguHEA7mQmegYHGw4cLzhn4eXZNvFlVb8L1kH5Ptnb8l52wYoWxsS1EgdawLHJR3cDPh2Ryr4JON3ev8gYXBKEXNN1jvDrcxG3p2fP3933qxL/Bv+sfh09c37zSKSG65umM4ylLVAnQS8ypOi4nDGATyYNhDrp8O+HqEPqUuAJoty0yMvKJnbgf8dVdDF9FvSeYLvA4L8JdQ9zRKVQTvy8BNcPRPhlMaTZWeAmynTfMti5F69642i4TXBMqQZWANswyij9nHfBLnANzjpx+3CmsE0wkcAEC/V3n4bZOeKVE791RaWgFd5r1PK9GMXjqAGYMG/RnLAfoJ/n/ZrWjNhOV8QaYuriTvMpAcgcqFYCMVonz9dn3TfqURtTG0MJZt7/j8W5J2mWSFvhZnRc7EDPiY4X1N1HqVl8GbqapsEp7DG/KCpQ/wk6pE34+Lyb15rbAfyOAWGNbuJDCHifGTa0PTRgi2d102EenxmhnSpCiH2usvKlYea/K5X5fZE5tFqycO8Whpbav4FFmmrf1vqiq2syChPQCypPGysLSpzMhElPnHEsLMkzILX34CNB0VZSAWwPIfUFbra77jtrOpXQbVw+Tye11LWaVPbXO4RmkYKaJnx2N8ASeUA4UWwW8iGS+HtVaAzfwdbYm111A= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(966005)(186003)(86362001)(2616005)(52116002)(5660300002)(53546011)(26005)(31696002)(316002)(66476007)(66946007)(38100700002)(38350700002)(66556008)(110136005)(956004)(16576012)(44832011)(36756003)(31686004)(6636002)(83380400001)(6486002)(8676002)(508600001)(19627235002)(2906002)(6666004)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4167 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: cd19558e-33d4-401c-b5a4-08d984d3995c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZNweVUv/HU+HvN6YqWd5lBflpJxbMrMVKgDK86WGUcKv2eA0OICBbK7zEQOD0CJ09a/iF1WUSDP0z+MXry08rh+gTMv/SjS5v7eIuCqWba15t9xNCapUs9wSSV89jC6opyWRnIeFZHLnA876yigwZG8VcN0/LHg1L6ZEHeBCT0US7JrNlxBAqkLyTPnabmXKIBVo+J1yWREf0zUcdZeOyV48YhqVfAYf6eq5/N5bxh7IxqKHENmYf/wX2ONO6K0nzhnaYecGrTWpyMSff9cf5AD9ksaWgNI9Vcaprvw3O8AYpUGcLQNZP+1Sc0Dy6zGQgHwCyrF/vlyRYtNGpL/QnMa+eaqX+oYknDh+i85ELUkqJm7gY7K77w7DCmg2S5YM3t+Hv0HqXexV7WsrmJaFyXXUQBlGkH7KTK1BzDXEg6yoaSRrLhNrRVkrInPt69k4OmcVrE3eHHK1OZjZG9LICd0gTy/feTGZHjNOPBEf9fht+T6inwfBXR2s+WyhsYPCqFJN0TzBYiykd7+MHjpq0/bz5SiOiD5GXJ0DMJwVVImzzpNKVKaE+9aZwvhdOnU8RMsvR+pUDwAgetJWL5dBN0JjVWAq4NAT8/Z1r+liuJVb5cWwPy7yKa4rB/3CwoRyF36rR/dbOwQytpU3/nSuPMbMKVmca/Mgiy3Lm8Q4E/hF+5AHJWlM/URkH/htYfoYdSnjGX4qYWQfuN4fh29i+388yIGPe3ql6hd8M5Xpq/+MlagZScbnKceUr5W0/glyojFFkxhu2zwCbczmpDaFqX1m2HW2I30qROYe+oz+fdWHTEGTe3jbhlGrEc53oKmu X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(31696002)(70586007)(2906002)(53546011)(8936002)(6636002)(19627235002)(26005)(31686004)(70206006)(966005)(356005)(6666004)(36756003)(81166007)(16576012)(508600001)(110136005)(2616005)(5660300002)(316002)(186003)(8676002)(82310400003)(956004)(83380400001)(44832011)(36860700001)(47076005)(6486002)(336012)(86362001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 12:04:33.5509 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fb7d5a23-6b0f-4874-d7b1-08d984d3a1bc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6362 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Merged as 422e5d2f7f1a..22873f58c40c Regards, Sami Mujawar On 30/09/2021 08:48 AM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > This patch-set aggregates various modifications in the > DynamicTablesPkg: > - Extract an AcpiTableHelperLib from TableHelperLib to remove > the dependency of some utility functions over configuration > manager definitions > - Add a HexFromAscii() function > - Add a AmlGetEisaIdFromString() function > - Add a configuration manager object parser > - Use %a instead of %s in when printing AmlLib > - Update the .ci.yaml once to prepare for other incoming patches > - Modify the generic prototype of the AmlResourceDataCodeGen > functions. This also means deprecating some functions. > > The modifications can be seen at: https://github.com/PierreARM/edk2/tree/= 1718_Various_DynamicTablesPkg_modifications_v2 > > v2: > - Corrections in commit messages. [Sami] > - Document returned error code for some functions. [Sami] > - Correct wrong field name in Configuration Manager Object parser. > [Joey] > > Pierre Gondois (9): > DynamicTablesPkg: Extract AcpiHelperLib from TableHelperLib > DynamicTablesPkg: Update TableHelperLib.inf > DynamicTablesPkg: Rename single char input parameter > DynamicTablesPkg: Add HexFromAscii() to AcpiHelperLib > DynamicTablesPkg: Add AmlGetEisaIdFromString() to AcpiHelperLib > DynamicTablesPkg: Use %a formatter in AmlDbgPrint > DynamicTablesPkg: Update DynamicTablesPkg.ci.yaml > DynamicTablesPkg: Deprecate Crs specific methods in AmlLib > DynamicTablesPkg: Rework AmlResourceDataCodegen.c/h > > Sami Mujawar (1): > DynamicTablesPkg: Add Configuration Manager Object parser > > DynamicTablesPkg/DynamicTables.dsc.inc | 3 +- > DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 29 + > DynamicTablesPkg/DynamicTablesPkg.dec | 4 + > DynamicTablesPkg/DynamicTablesPkg.dsc | 1 + > .../Include/Library/AcpiHelperLib.h | 93 +++ > .../Include/Library/AmlLib/AmlLib.h | 225 ++++-- > .../Include/Library/TableHelperLib.h | 49 +- > .../SsdtCmn600Generator.c | 14 +- > .../AcpiSsdtCmn600LibArm/SsdtCmn600LibArm.inf | 3 +- > .../SsdtSerialPortGenerator.c | 3 +- > .../SsdtSerialPortLibArm.inf | 4 +- > .../Library/Common/AcpiHelperLib/AcpiHelper.c | 210 ++++++ > .../Common/AcpiHelperLib/AcpiHelperLib.inf | 25 + > .../Common/AmlLib/AmlDbgPrint/AmlDbgPrint.c | 16 +- > .../Library/Common/AmlLib/AmlLib.inf | 3 +- > .../Library/Common/AmlLib/Api/AmlApi.c | 147 +++- > .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 194 ++--- > .../AmlLib/CodeGen/AmlResourceDataCodeGen.h | 67 +- > .../SsdtSerialPortFixupLib.c | 6 +- > .../SsdtSerialPortFixupLib.inf | 1 + > .../ConfigurationManagerObjectParser.c | 678 ++++++++++++++++++ > .../ConfigurationManagerObjectParser.h | 73 ++ > .../Common/TableHelperLib/TableHelper.c | 96 --- > .../Common/TableHelperLib/TableHelperLib.inf | 13 +- > 24 files changed, 1579 insertions(+), 378 deletions(-) > create mode 100644 DynamicTablesPkg/Include/Library/AcpiHelperLib.h > create mode 100644 DynamicTablesPkg/Library/Common/AcpiHelperLib/AcpiHe= lper.c > create mode 100644 DynamicTablesPkg/Library/Common/AcpiHelperLib/AcpiHe= lperLib.inf > create mode 100644 DynamicTablesPkg/Library/Common/TableHelperLib/Confi= gurationManagerObjectParser.c > create mode 100644 DynamicTablesPkg/Library/Common/TableHelperLib/Confi= gurationManagerObjectParser.h > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.