From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by mx.groups.io with SMTP id smtpd.web12.5783.1620692073229543167 for ; Mon, 10 May 2021 17:14:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=xmission header.b=YvwDdDry; spf=none, err=SPF record not found (domain: bsdio.com, ip: 166.70.13.231, mailfrom: rebecca@bsdio.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=kGsqkqlGRn+JGALt43rFiIsTixFCvAgNCRnoqkRi+k0=; b=YvwDdDryfa0s+iGq6h0HZD9XIW hs8tjYIJRbUkS5OJTnzrZxXhIV0Z2TEFG6LGbLJG+P8RfdRuT+dhrUM3+sFGulfz/5fxGxX/W4pUW MQblExaUuU8stzsD1aFv+/XcgF5YileT/bPp299APgLGHaR2N3/5OWW/yW5P/WMMWpAs=; Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lgG2g-00DgOc-71; Mon, 10 May 2021 18:14:30 -0600 Received: from mta5.zcs.xmission.com ([166.70.13.69]) by in02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lgG2e-007blk-7D; Mon, 10 May 2021 18:14:29 -0600 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id DA683128103D; Mon, 10 May 2021 18:14:27 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rt95CzHcm33U; Mon, 10 May 2021 18:14:27 -0600 (MDT) Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id 7C81E1280CC7; Mon, 10 May 2021 18:14:27 -0600 (MDT) To: devel@edk2.groups.io, michael.d.kinney@intel.com, Rebecca Cran , "lersek@redhat.com" Cc: Tom Lendacky , Bret Barkelew , Sean Brogan References: <298de55b-7cbd-22be-b584-9b83ccfe2b06@bsdio.com> <0ef244cf-7100-4f1b-29f5-607e9e243061@redhat.com> From: "Rebecca Cran" Message-ID: <65fd952b-e75e-0361-58e5-11596391b58e@bsdio.com> Date: Mon, 10 May 2021 18:14:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: X-XM-SPF: eid=1lgG2e-007blk-7D;;;mid=<65fd952b-e75e-0361-58e5-11596391b58e@bsdio.com>;;;hst=in02.mta.xmission.com;;;ip=166.70.13.69;;;frm=rebecca@bsdio.com;;;spf=none X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa05.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.2 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,NICE_REPLY_A,T_TM2_M_HEADER_IN_MSG,TooManyTo_001, TooManyTo_002,TooManyTo_003,TooManyTo_004,XM_B_Unsub autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.5 TooManyTo_002 Multiple "To" Header Recipients 3x (uncommon) * 0.5 TooManyTo_004 Multiple "To" Header Recipients 5x (uncommon) * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 0.6 TooManyTo_003 Multiple "To" Header Recipients 4x (uncommon) * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa05 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] * 0.5 XM_B_Unsub Unsubscribe in body of email but missing unsubscribe * header * -0.0 NICE_REPLY_A Looks like a legit reply (A) X-Spam-DCC: XMission; sa05 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;devel@edk2.groups.io, michael.d.kinney@intel.com, Rebecca Cran , "lersek@redhat.com" X-Spam-Relay-Country: X-Spam-Timing: total 1477 ms - load_scoreonly_sql: 0.13 (0.0%), signal_user_changed: 13 (0.9%), b_tie_ro: 11 (0.7%), parse: 2.2 (0.1%), extract_message_metadata: 50 (3.4%), get_uri_detail_list: 7 (0.5%), tests_pri_-1000: 37 (2.5%), tests_pri_-950: 1.43 (0.1%), tests_pri_-900: 1.19 (0.1%), tests_pri_-90: 163 (11.0%), check_bayes: 129 (8.7%), b_tokenize: 14 (0.9%), b_tok_get_all: 13 (0.9%), b_comp_prob: 4.1 (0.3%), b_tok_touch_all: 93 (6.3%), b_finish: 1.21 (0.1%), tests_pri_0: 642 (43.5%), check_dkim_signature: 0.94 (0.1%), check_dkim_adsp: 34 (2.3%), poll_dns_idle: 579 (39.2%), tests_pri_10: 2.0 (0.1%), tests_pri_500: 562 (38.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [edk2-devel] Build fails with VS2012 X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Thanks. The obvious toolchains that are missing from ReadMe.rst are any versions of XCODE and CLANG. Also, it might be nice to specify _which_ GCC5 versions are supported, since that covers gcc 5 through 11 and gcc 5.x currently causes a build error. We maybe only care about gcc 7 and newer these days? I just tried building with VS2015 and VS2013, and there was a build error because it seems the location of rc.exe has changed. After fixing that they successfully built OVMF. But it sounds like we possibly only want to make sure that VS2017 and VS2019 are kept working now. I've cc'd Bret and Sean because I'm wondering if there are plans to add more toolchain/OS combinations into the GitHub/Azure solution? For example adding macOS with XCODE5? Also, how about post-commit or nightly builds that run more extensive tests, possibly generating binaries for OVMF that people can try without building it themselves? Or would that be something that might be useful for me to implement as a third-party solution? -- Rebecca Cran On 5/10/21 5:31 PM, Michael D Kinney wrote: > I think there a few categories of tool chains: > > 1) Tool chains that are in tools_def.txt and are used by EDK II CI to perform pre-commit and post-commit changes. These are documented in Readme.rst > 2) Tool chains that are in tools_def.txt that are fully supported by the EDK II community. Should be documented in Readme.rst. > 3) Tool chains that are in tools_def.txt, but are not supported by the EDK II community, but some downstream consumers use the tool chain are willing to fix issues that impact them. > 4) Tool chains that are in tools_def.txt, but are not used by anyone. > > We need to make sure we document (1), (2), and (3) so we can identify and delete (4) from tools_def.txt. > > Thanks, > > Mike > > >> -----Original Message----- >> From: Rebecca Cran >> Sent: Monday, May 10, 2021 6:21 AM >> To: devel@edk2.groups.io; lersek@redhat.com; rebecca@bsdio.com >> Cc: Kinney, Michael D ; Tom Lendacky >> Subject: Re: [edk2-devel] Build fails with VS2012 >> >> On 5/10/21 5:56 AM, Laszlo Ersek wrote: >>> Hi Rebecca >>> >>> +Tom >>> >>> On 05/08/21 21:47, Rebecca Cran wrote: >>>> I'm setting up a new Jenkins server to do Bhyve builds and run on >>>> platforms that aren't currently tested with the GitHub/Azure system. >>>> >>>> Since VS2012 appears to be a supported toolchain, I tried building >>>> OvmfPkgX64 with it (I'm also planning on testing VS2013, VS2015, VS2017 >>>> and VS2019), but it fails with: >>>> >>>> >>>> Building ... >>>> c:\users\administrator\src\edk2\NetworkPkg\Library\DxeUdpIoLib\DxeUdpIoLib.inf >>>> [X64] >>>> c:\users\administrator\src\edk2\UefiCpuPkg\Library\MpInitLib\MpLib.c(1268) >>>> : error C2220: warning treated as error - no 'object' file generated >>>> c:\users\administrator\src\edk2\UefiCpuPkg\Library\MpInitLib\MpLib.c(1268) >>>> : warning C4306: 'type cast' : conversion from 'int' to >>>> 'SEV_ES_AP_JMP_FAR *' of greater size >>> >>> I think the compiler is justified to complain here: >>> >>> 7b7508ad784d1 (Tom Lendacky 2020-08-12 15:21:42 -0500 1268) JmpFar = (SEV_ES_AP_JMP_FAR *) FixedPcdGet32 >> (PcdSevEsWorkAreaBase); >>> >>> The proper way to spell such casts is with (UINTN) in the middle. >>> >>> Can you please file a new BZ? >> >> I've created https://bugzilla.tianocore.org/show_bug.cgi?id=3385 >> >>>> I know the GitHub/Azure system only tests with VS2017 and VS2019: are >>>> there plans to drop the older VS versions, or should they still work? >>>> And would it be considered useful to _check_ that they still work, or >>>> should they be considered unsupported? >>> >>> I'd suggest dropping them. >>> >>> Earlier, Ard raised a similar question for gcc too -- IIRC, Ard suggested that GCC4* be removed. I agree with the idea. >> >> Thanks. If we're ready to go ahead, should I create a patch to remove them? >> >> Do you know what the new minimum version of gcc should then be? I'd like >> to run builds with it so we can catch any issues. >> >> Would we remove all VS versions except VS2017 and VS2019, or would we >> keep others like VS2015 for now? >> >> -- >> Rebecca Cran > > > > >