* [PATCH 0/2] Fix an issue in SmbiosMiscDxe module
@ 2023-05-16 7:08 Minh Nguyen
2023-05-16 7:08 ` [PATCH 1/2] ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records Minh Nguyen
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Minh Nguyen @ 2023-05-16 7:08 UTC (permalink / raw)
To: devel
Cc: quic_llindhol, ardb+tianocore, sami.mujawar, khanh.pham, nhi,
tinhnguyen, Minh Nguyen
These patches help to fix an issue in SmbiosMiscDxe and remove redundant asign for SmbiosHandle.
Minh Nguyen (2):
ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records
ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle
ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.39.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records
2023-05-16 7:08 [PATCH 0/2] Fix an issue in SmbiosMiscDxe module Minh Nguyen
@ 2023-05-16 7:08 ` Minh Nguyen
2023-05-16 8:27 ` Sami Mujawar
2023-05-16 7:08 ` [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle Minh Nguyen
2023-05-23 9:23 ` [PATCH 0/2] Fix an issue in SmbiosMiscDxe module Nhi Pham
2 siblings, 1 reply; 6+ messages in thread
From: Minh Nguyen @ 2023-05-16 7:08 UTC (permalink / raw)
To: devel
Cc: quic_llindhol, ardb+tianocore, sami.mujawar, khanh.pham, nhi,
tinhnguyen, Minh Nguyen
To iterate entire SMBIOS table records for searching specific records,
"SmbiosHandle" input need to be as "SMBIOS_HANDLE_PI_RESERVED". This
patch helps to fix that.
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
---
ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
index 3a5626b50c0d..7250da02b3ac 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
@@ -8,6 +8,7 @@
Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2015, Hisilicon Limited. All rights reserved.<BR>
Copyright (c) 2015, Linaro Limited. All rights reserved.<BR>
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -159,6 +160,7 @@ GetHandleCount (
EFI_SMBIOS_TABLE_HEADER *Record;
HandleCount = 0;
+ SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
// Iterate through entries to get the number
do {
--
2.39.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle
2023-05-16 7:08 [PATCH 0/2] Fix an issue in SmbiosMiscDxe module Minh Nguyen
2023-05-16 7:08 ` [PATCH 1/2] ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records Minh Nguyen
@ 2023-05-16 7:08 ` Minh Nguyen
2023-05-16 8:28 ` Sami Mujawar
2023-05-23 9:23 ` [PATCH 0/2] Fix an issue in SmbiosMiscDxe module Nhi Pham
2 siblings, 1 reply; 6+ messages in thread
From: Minh Nguyen @ 2023-05-16 7:08 UTC (permalink / raw)
To: devel
Cc: quic_llindhol, ardb+tianocore, sami.mujawar, khanh.pham, nhi,
tinhnguyen, Minh Nguyen
This helps to remove redundant assign for SmbiosHandle.
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
---
ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
index 7250da02b3ac..313129460d9c 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
@@ -213,8 +213,6 @@ SmbiosMiscGetLinkTypeHandle (
return;
}
- SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
-
for (Index = 0; Index < (*HandleCount); Index++) {
Status = mSmbiosMiscSmbios->GetNext (
mSmbiosMiscSmbios,
--
2.39.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records
2023-05-16 7:08 ` [PATCH 1/2] ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records Minh Nguyen
@ 2023-05-16 8:27 ` Sami Mujawar
0 siblings, 0 replies; 6+ messages in thread
From: Sami Mujawar @ 2023-05-16 8:27 UTC (permalink / raw)
To: Minh Nguyen, devel
Cc: quic_llindhol, ardb+tianocore, khanh.pham, nhi, tinhnguyen,
nd@arm.com
Hi Minh,
Thank you for this fix.
This change looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 16/05/2023 08:08 am, Minh Nguyen wrote:
> To iterate entire SMBIOS table records for searching specific records,
> "SmbiosHandle" input need to be as "SMBIOS_HANDLE_PI_RESERVED". This
> patch helps to fix that.
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
> ---
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> index 3a5626b50c0d..7250da02b3ac 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> @@ -8,6 +8,7 @@
> Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
> Copyright (c) 2015, Hisilicon Limited. All rights reserved.<BR>
> Copyright (c) 2015, Linaro Limited. All rights reserved.<BR>
> + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -159,6 +160,7 @@ GetHandleCount (
> EFI_SMBIOS_TABLE_HEADER *Record;
>
> HandleCount = 0;
> + SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
>
> // Iterate through entries to get the number
> do {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle
2023-05-16 7:08 ` [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle Minh Nguyen
@ 2023-05-16 8:28 ` Sami Mujawar
0 siblings, 0 replies; 6+ messages in thread
From: Sami Mujawar @ 2023-05-16 8:28 UTC (permalink / raw)
To: Minh Nguyen, devel
Cc: quic_llindhol, ardb+tianocore, khanh.pham, nhi, tinhnguyen,
nd@arm.com
Hi Minh,
Thank you for this patch.
This fix looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 16/05/2023 08:08 am, Minh Nguyen wrote:
> This helps to remove redundant assign for SmbiosHandle.
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
> ---
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> index 7250da02b3ac..313129460d9c 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> @@ -213,8 +213,6 @@ SmbiosMiscGetLinkTypeHandle (
> return;
> }
>
> - SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
> -
> for (Index = 0; Index < (*HandleCount); Index++) {
> Status = mSmbiosMiscSmbios->GetNext (
> mSmbiosMiscSmbios,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Fix an issue in SmbiosMiscDxe module
2023-05-16 7:08 [PATCH 0/2] Fix an issue in SmbiosMiscDxe module Minh Nguyen
2023-05-16 7:08 ` [PATCH 1/2] ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records Minh Nguyen
2023-05-16 7:08 ` [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle Minh Nguyen
@ 2023-05-23 9:23 ` Nhi Pham
2 siblings, 0 replies; 6+ messages in thread
From: Nhi Pham @ 2023-05-23 9:23 UTC (permalink / raw)
To: Minh Nguyen, devel, ardb+tianocore, quic_llindhol, sami.mujawar
Cc: khanh.pham, nhi, tinhnguyen
This patch series looks good to me.
Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
Thanks,
Nhi
On 5/16/2023 2:08 PM, Minh Nguyen wrote:
> These patches help to fix an issue in SmbiosMiscDxe and remove redundant asign for SmbiosHandle.
>
> Minh Nguyen (2):
> ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records
> ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle
>
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-23 9:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 7:08 [PATCH 0/2] Fix an issue in SmbiosMiscDxe module Minh Nguyen
2023-05-16 7:08 ` [PATCH 1/2] ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records Minh Nguyen
2023-05-16 8:27 ` Sami Mujawar
2023-05-16 7:08 ` [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle Minh Nguyen
2023-05-16 8:28 ` Sami Mujawar
2023-05-23 9:23 ` [PATCH 0/2] Fix an issue in SmbiosMiscDxe module Nhi Pham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox