From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (EUR03-DBA-obe.outbound.protection.outlook.com [40.107.104.56]) by mx.groups.io with SMTP id smtpd.web10.16981.1684225682378529529 for ; Tue, 16 May 2023 01:28:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=alLY1Ply; spf=pass (domain: arm.com, ip: 40.107.104.56, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0+IG0o0ZJeCiSS4w6rkbKZNHSg9yEz97Ib5S664+OsI=; b=alLY1Ply7xvJiA5shxgdB9/4awoLDF7ZYyg7W4+iRfzEdhoJlfLxa5GICOK6qjOsyzEOxrBJ1EnKiM0VEU02z2UAsZ0FWpRXplcXKsDOw0Tcsvpq+S4auwPh8DA8IsycO36WcXp2JCbjjYVT1VmFtyotD0sD+XHMD3vNS5KHqtU= Received: from AS8P251CA0007.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::7) by GV1PR08MB8330.eurprd08.prod.outlook.com (2603:10a6:150:85::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 08:27:55 +0000 Received: from AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::c2) by AS8P251CA0007.outlook.office365.com (2603:10a6:20b:2f2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33 via Frontend Transport; Tue, 16 May 2023 08:27:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT026.mail.protection.outlook.com (100.127.140.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 08:27:55 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Tue, 16 May 2023 08:27:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4b5ea8039e1a2e99 X-CR-MTA-TID: 64aa7808 Received: from 0b856474cd34.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9D132046-AADC-4189-AA0A-182FFCE5F4C4.1; Tue, 16 May 2023 08:27:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0b856474cd34.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 May 2023 08:27:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DqStSwEJcSUpk8alqrow8i+mCawMdC8VVU+MV7XWRkmHi6Jw+n2GRNOpy1NkeeIi3SXmpXwSJGIZIUit1yEYqVdr5e0mYqucjnIiXowBHdgLdYMNxjXd5W+HcmZCFLWXu5ULR+Y+FbFqDEj4qdcBfN8ou4dpXBFVz48nQWl/U4I7JnPPcpGZ+Rh9pLdeJO67Gaj3J8w88FeR/gtOREDo4WhzNRhege54Wa+vhV5JHs33REluaDZCORmKcEnoK0k5WH4nt/FOD6+YsCtuMNpcHDWf8CMFYwhWxgNKKzM4VK9wX2cBMOW9+sJjmi40H2AS4G0/6iLkn8yQTs2YkdwUwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0+IG0o0ZJeCiSS4w6rkbKZNHSg9yEz97Ib5S664+OsI=; b=cKC77nMMBG9Zcv++fcf3RqthjdWvP1j8WwgWaG6I2p51NVWXVrLtwJ5f0e5Dx1tIoTjYj6Rv28G+u45IVLAbLbxyQKQpt0I8f1qA18bHg/W7fz7yu6zOi7VB+eM0VOL0LXiAsFGJRdkTvLg9LJR0WvjdL+pGUYAnP5+jTy4XuN53ZVTaky+TBOlipJhlf7j8eemwFJS0rLbUs4hbmUOXUwJNA/Lw7a7pDabydeQyNhuzJ/cu9CY9ZtKjDepqLM5ZfrfVWV9YntldjWvUCvzRdtnrXUefAtyVb1Zrk2dpQYK8nmmOiy2+IY7nRcZ50Ei0xKpixBsi0z+yQlNIT+v3Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0+IG0o0ZJeCiSS4w6rkbKZNHSg9yEz97Ib5S664+OsI=; b=alLY1Ply7xvJiA5shxgdB9/4awoLDF7ZYyg7W4+iRfzEdhoJlfLxa5GICOK6qjOsyzEOxrBJ1EnKiM0VEU02z2UAsZ0FWpRXplcXKsDOw0Tcsvpq+S4auwPh8DA8IsycO36WcXp2JCbjjYVT1VmFtyotD0sD+XHMD3vNS5KHqtU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by GV2PR08MB9349.eurprd08.prod.outlook.com (2603:10a6:150:da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.32; Tue, 16 May 2023 08:27:44 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c%6]) with mapi id 15.20.6387.032; Tue, 16 May 2023 08:27:44 +0000 Message-ID: <661e80d1-fada-bc1f-bfbd-ca00d917147e@arm.com> Date: Tue, 16 May 2023 09:27:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/2] ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records To: Minh Nguyen , devel@edk2.groups.io Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, khanh.pham@os.amperecomputing.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, "nd@arm.com" References: <20230516070812.3606476-1-minhnguyen1@os.amperecomputing.com> <20230516070812.3606476-2-minhnguyen1@os.amperecomputing.com> From: "Sami Mujawar" In-Reply-To: <20230516070812.3606476-2-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: LO4P265CA0152.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::15) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|GV2PR08MB9349:EE_|AM7EUR03FT026:EE_|GV1PR08MB8330:EE_ X-MS-Office365-Filtering-Correlation-Id: 2869585e-993f-4660-46be-08db55e772d9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vCyHYkfA84SIJizzLQ61SWbyv1HJdeYR8I6ift4fGgnuODosos/uw4kq0Sp0kI6BaAOjtFGR2ONciNigY9BvFChgsEtlpn3ht1umTyhj0Dk3it49zmF3AVsdF8hqLoEs7AiwI7RFVq7KtAT2Es3aEpFxR4m1nCGb2XE7o1UgeNcKx82DYiN3oxMUoed8k4+S6TCe6YP7ss4QWZB/rLFfmTewBjo04OIuVpEw40bjzGhTaCLuatRLzKIZLdtVEktjQyqFFyNaLW7ZqUveU8Of4L5v6/XLk6NUoNAouZt76i2xXuX5kMtvLsnsgZoI+qsAoZa5+9UJowht7/8I251XfUFYVlk4cn8QLyRohlRdjhZMEtvo83uyPBrCk5hxA6Z2MKDuhBlk42Wi6jRBuYlXB45DBkwEHZB4oqyUXQDIvxiu3fBsfa/AJOygPzn5U0+qgHfxN0HeVQ7nyCa+pxtCDZAshjcyjw3e6Ihx91wxx3FxAUXZK4L8AjJ9xnsDVHRgphmO5gwdzIbb9KAyaA3jF+KtvBp9irdrOBsB0q55gpPnoJtpJTPpI81t0ZxMaOjlWvoNEO1KduqAtezriYTYRfc85hhW1AFMnxB9PSLKQp2l+sGLWj9mVVxR+CtBg594bLn37ea9Z3hCGilFPlIxQQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(451199021)(6666004)(6486002)(53546011)(83380400001)(36756003)(26005)(186003)(6506007)(2616005)(38100700002)(31696002)(86362001)(6512007)(44832011)(8936002)(8676002)(5660300002)(66556008)(41300700001)(66476007)(66946007)(4326008)(316002)(2906002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9349 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ed823d86-65e7-4d90-be08-08db55e76bdb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +gDQu/gYGXjxeah4wSqo/AlXAL8f2mB7uIWd9KdwLJUccKNYz0ruZ7i5GCX+5gSq80Stmn3dd+LpIdFnL9PLERX+qaFGO+XjtXca44WTgW8z4/nUqukj+9CbkKy+WKQWgbhGbxln1gS1/7HjJQID+BteGZHlXd1tTsi4DEOrP5aZldSJrCrAS6TC8dh15Ab/9e/uIKNVkwRko9SO3/2LWZ/rcDDQ+u2n35rJ1rs9tJclMd0+oe1ZAojE81zqBlvsxTEmf5Kl4QGe2nKd6GXSFfp9V7YqA0pc4iLmnxAkD17MRxLL3VN8OBpGloHxkXkY82xwpXvkXQjiT9tXdpTie/VgSAKxkK9ccl8LiwvGEMnxhwEVzBvd9ZCTARlK6nRDP3wricWL0Mxz1oMqkBRp/v2RLSNmKhWXVvUPVgZy/F4cE/Y/3Hp3SQOg1lkhzbBErcfHSwkxIs1JxA32CgyJnQNhaaGPQV4GOb+HRq4F+buMhaFMHJ8kBLj+MV5geam8+aCzC2/2SlZFoXgKwqP0DHFalEVbFScUqWJbrID42tjMXblip7XwGkWIjBYDurgVWI/omgL6hNlUie13YEF7miDJYKBWieUhXUAhwVXWNnZBoMTpLt6k+cAqREJGrsc+t8KASdIYrnYJNeV8yI6m0CFGrmoizSLsNuLv7949kQogerIaSRunpI208o8qBFVT50Rr+6RJAs6S5blbSVD0dxjuH+dgTOHFpcpzny4AsqVSk0bjeXyAUb3ervpXU9KD8Yppxcd7699WbOTZAuskJQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199021)(46966006)(40470700004)(36840700001)(83380400001)(36860700001)(336012)(47076005)(70586007)(70206006)(2616005)(40480700001)(6512007)(26005)(6486002)(478600001)(6666004)(186003)(40460700003)(8676002)(31696002)(44832011)(86362001)(8936002)(2906002)(5660300002)(41300700001)(36756003)(4326008)(82740400003)(316002)(53546011)(6506007)(81166007)(356005)(31686004)(82310400005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 08:27:55.5080 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2869585e-993f-4660-46be-08db55e772d9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8330 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Minh, Thank you for this fix. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2023 08:08 am, Minh Nguyen wrote: > To iterate entire SMBIOS table records for searching specific records, > "SmbiosHandle" input need to be as "SMBIOS_HANDLE_PI_RESERVED". This > patch helps to fix that. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Signed-off-by: Minh Nguyen > --- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c > index 3a5626b50c0d..7250da02b3ac 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c > @@ -8,6 +8,7 @@ > Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.
> Copyright (c) 2015, Hisilicon Limited. All rights reserved.
> Copyright (c) 2015, Linaro Limited. All rights reserved.
> + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -159,6 +160,7 @@ GetHandleCount ( > EFI_SMBIOS_TABLE_HEADER *Record; > > HandleCount = 0; > + SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED; > > // Iterate through entries to get the number > do {