From: "PierreGondois" <pierre.gondois@arm.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>, "nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH 06/14] DynamicTablesPkg: Fix wrong/missing fields in CmObjParser
Date: Fri, 28 Oct 2022 12:05:19 +0200 [thread overview]
Message-ID: <666fb7c1-1cc9-3f26-2aa8-22c729af9562@arm.com> (raw)
In-Reply-To: <f3e8288d-9587-4ec0-d2d0-3f03fb9fa3e9@arm.com>
Hi Sami,
On 10/26/22 14:34, Sami Mujawar wrote:
> Hi Pierre,
>
> I have one comment marked inline as [SAMI].
>
> I believe other than that change this patch should be good.
Yes indeed, thanks for spotting it and for making the modification,
Regards,
Pierre
>
> Regards,
>
> Sami Mujawar
>
> On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote:
>> From: Pierre Gondois <pierre.gondois@arm.com>
>>
>> Add missing fields to the following CmObjParser objects:
>> - EArmObjGicDInfo
>> - EArmObjCacheInfo
>> and fix wrong formatting of:
>> - EArmObjLpiInfo
>>
>> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
>> ---
>> .../ConfigurationManagerObjectParser.c | 24 ++++++++++---------
>> 1 file changed, 13 insertions(+), 11 deletions(-)
>>
>> diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
>> index 040aaa4cbb17..2126beba8b9f 100644
>> --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
>> +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
>> @@ -303,7 +303,8 @@ STATIC CONST CM_OBJ_PARSER CmArmProcHierarchyInfoParser[] = {
>> { "ParentToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
>> { "GicCToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
>> { "NoOfPrivateResources", 4, "0x%x", NULL },
>> - { "PrivateResourcesArrayToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }
>> + { "PrivateResourcesArrayToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
>> + { "LpiToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
>> };
>>
>> /** A parser for EArmObjCacheInfo.
>> @@ -315,7 +316,8 @@ STATIC CONST CM_OBJ_PARSER CmArmCacheInfoParser[] = {
>> { "NumberOfSets", 4, "0x%x", NULL },
>> { "Associativity", 4, "0x%x", NULL },
>> { "Attributes", 1, "0x%x", NULL },
>> - { "LineSize", 2, "0x%x", NULL }
>> + { "LineSize", 2, "0x%x", NULL },
>> + { "CacheId", 4, "0x%x", NULL },
>> };
>>
>> /** A parser for EArmObjProcNodeIdInfo.
>> @@ -400,14 +402,14 @@ STATIC CONST CM_OBJ_PARSER AcpiGenericAddressParser[] = {
>> /** A parser for EArmObjLpiInfo.
>> */
>> STATIC CONST CM_OBJ_PARSER CmArmLpiInfoParser[] = {
>> - { "MinResidency", 4, "0x%x", NULL },
>> - { "WorstCaseWakeLatency", 4, "0x%x", NULL },
>> - { "Flags", 4, "0x%x", NULL },
>> - { "ArchFlags", 4, "0x%x", NULL },
>> - { "ResCntFreq", 4, "0x%x", NULL },
>> - { "EnableParentState", 4, "0x%x", NULL },
>> - { "IsInteger", 1, "%d", NULL },
>> - { "IntegerEntryMethod", 8, "0x%llx", NULL },
>> + { "MinResidency", 4, "0x%x", NULL },
>> + { "WorstCaseWakeLatency", 4, "0x%x", NULL },
>> + { "Flags", 4, "0x%x", NULL },
>> + { "ArchFlags", 4, "0x%x", NULL },
>> + { "ResCntFreq", 4, "0x%x", NULL },
>> + { "EnableParentState", 4, "0x%x", NULL },
>> + { "IsInteger", 1, "%d", NULL },
>> + { "IntegerEntryMethod", 8, "0x%llx", NULL },
>> { "RegisterEntryMethod", sizeof (EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE),
>> NULL, NULL, AcpiGenericAddressParser,
>> ARRAY_SIZE (AcpiGenericAddressParser) },
>> @@ -417,7 +419,7 @@ STATIC CONST CM_OBJ_PARSER CmArmLpiInfoParser[] = {
>> { "UsageCounterRegister", sizeof (EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE),
>> NULL, NULL, AcpiGenericAddressParser,
>> ARRAY_SIZE (AcpiGenericAddressParser) },
>> - { "StateName", 16, "0x%a", NULL },
>> + { "StateName", 16, "NULL", PrintString },
> [SAMI] I think the format specifier should be NULL and not enclosed in
> quotes. If you agree I will fix this before merging.
>> };
>>
>> /** A parser for EArmObjPciAddressMapInfo.
next prev parent reply other threads:[~2022-10-28 10:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 9:20 [PATCH 00/14] Add PCCT generator and various fixes PierreGondois
2022-10-10 9:20 ` [PATCH 01/14] DynamicTablesPkg: Use correct print formatter PierreGondois
2022-10-26 12:36 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 02/14] DynamicTablesPkg: Add PrintString to CmObjParser PierreGondois
2022-10-26 12:36 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 03/14] DynamicTablesPkg: Update CmObjParser for IORT Rev E.d PierreGondois
2022-10-26 12:34 ` Sami Mujawar
2022-10-28 10:05 ` PierreGondois
2022-10-10 9:20 ` [PATCH 04/14] DynamicTablesPkg: Update CmObjParser for MinorRevision PierreGondois
2022-10-26 12:36 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 05/14] DynamicTablesPkg: Fix GTBlock and GTBlockTimerFrame CmObjParsers PierreGondois
2022-10-26 12:37 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 06/14] DynamicTablesPkg: Fix wrong/missing fields in CmObjParser PierreGondois
2022-10-26 12:34 ` Sami Mujawar
2022-10-28 10:05 ` PierreGondois [this message]
2022-10-10 9:20 ` [PATCH 07/14] DynamicTablesPkg: Remove deprecated APIs PierreGondois
2022-10-26 12:37 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 08/14] DynamicTablesPkg: FdtHwInfoParserLib: Remove wrong comment PierreGondois
2022-10-26 12:37 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 09/14] DynamicTablesPkg: Fix Ssdt PCI generation comments PierreGondois
2022-10-26 12:37 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 10/14] DynamicTablesPkg: Add PCCT related objects PierreGondois
2022-10-26 12:34 ` Sami Mujawar
2022-10-28 10:04 ` PierreGondois
2022-10-10 9:20 ` [PATCH 11/14] DynamicTablesPkg: Add PCCT Generator PierreGondois
2022-10-26 12:35 ` Sami Mujawar
2022-10-28 10:02 ` PierreGondois
2022-10-10 9:20 ` [PATCH 12/14] DynamicTablesPkg/AmlLib: Allow larger AccessSize for Pcc address space PierreGondois
2022-10-26 12:34 ` Sami Mujawar
2022-10-28 10:04 ` PierreGondois
2022-10-10 9:20 ` [PATCH 13/14] DynamicTablesPkg: Readme.md: Update available tables for generation PierreGondois
2022-10-26 12:07 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5 PierreGondois
2022-10-26 12:06 ` Sami Mujawar
[not found] ` <171CAABD595C9750.32766@groups.io>
2022-10-10 9:48 ` [edk2-devel] " PierreGondois
2022-10-11 1:41 ` Ni, Ray
2022-10-31 13:34 ` [edk2-devel] [PATCH 00/14] Add PCCT generator and various fixes Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=666fb7c1-1cc9-3f26-2aa8-22c729af9562@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox