From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.1868.1584404185202714855 for ; Mon, 16 Mar 2020 17:16:25 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) IronPort-SDR: x5tdkGRK7VHvAXZ++2rCHDc3n95Ws719K1okClMdYrS7c08yC2MGy2LrZf6Q4RIBKTYCFVmmVS doXkF38vS+bA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 17:16:25 -0700 IronPort-SDR: zNVNonyOn/3+Os1+ZD6DktRvCYnwrIzcoYY4sq0vN7YFTHRGgvaWj0vdRh+zZIJQZ+7LQl2ltJ L+WspSETKskQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,562,1574150400"; d="scan'208";a="290849931" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 16 Mar 2020 17:16:25 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 17:16:24 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Mar 2020 08:16:22 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Tue, 17 Mar 2020 08:16:22 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Zhang, Shenglei" , "newexplorerj@gmail.com" CC: "Wang, Jian J" , "Lu, XiaoyuX" Subject: Re: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib Thread-Topic: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib Thread-Index: AQHV8rlAo+x59fIlF0WRLCWyjhPh9ahD+YGAgAgDfSA= Date: Tue, 17 Mar 2020 00:16:22 +0000 Message-ID: <66955dfdb4f24289ae28feeb33d254c2@intel.com> References: <2731dd841ca22bf605f0c115ff779cb1e6f7b926.1583390439.git.newexplorerj@gmail.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable @Jian, Xiaoyu: can you review this change? Good catch. Reviewed-by: Liming Gao -----Original Message----- From: devel@edk2.groups.io On Behalf Of Zhang, Shen= glei Sent: 2020=1B$BG/=1B(B3=1B$B7n=1B(B12=1B$BF|=1B(B 13:53 To: devel@edk2.groups.io; newexplorerj@gmail.com Cc: Wang, Jian J ; Lu, XiaoyuX Subject: Re: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename = BaseHashApiLib by HashApiLib Reviewed-by: Shenglei Zhang > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of=20 > GuoMinJ > Sent: Thursday, March 5, 2020 2:41 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Wang, Jian J=20 > ; Lu, XiaoyuX > Subject: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename=20 > BaseHashApiLib by HashApiLib >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2552 >=20 > According to CryptoPkg.dsc, the library class only have HashApiLib, so= =20 > i think the BaseHashApiLib should be considered as base name rather=20 > than library class. >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu > Signed-off-by: GuoMinJ > --- > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > index b4d8675ddd..046320353b 100644 > --- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > +++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > @@ -17,7 +17,7 @@ > FILE_GUID =3D B1E566DD-DE7C-4F04-BDA0-B1295D3BE9= 27 > MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D BaseHashApiLib > + LIBRARY_CLASS =3D HashApiLib >=20 > # > # The following information is for reference only and not required by= =20 > the build tools. > -- > 2.17.1 >=20 >=20 >=20