From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E58CA2095896F for ; Wed, 5 Jul 2017 10:53:34 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 05931C056861; Wed, 5 Jul 2017 17:55:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 05931C056861 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 05931C056861 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-25.phx2.redhat.com [10.3.116.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B00F5C7A9; Wed, 5 Jul 2017 17:55:12 +0000 (UTC) To: Jordan Justen , "Gao, Liming" , edk2-devel-01 Cc: Ard Biesheuvel References: <20170628220645.26413-1-lersek@redhat.com> <20170628220645.26413-2-lersek@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D74FBA1@shsmsx102.ccr.corp.intel.com> <149927689598.638.6499247930051801274@jljusten-skl> From: Laszlo Ersek Message-ID: <669b6033-7914-4d20-66cd-04ed29b76f2b@redhat.com> Date: Wed, 5 Jul 2017 19:55:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <149927689598.638.6499247930051801274@jljusten-skl> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 05 Jul 2017 17:55:14 +0000 (UTC) Subject: Re: [PATCH 1/2] OvmfPkg: disable build-time relocation for DXEFV modules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 17:53:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/05/17 19:48, Jordan Justen wrote: > On 2017-06-28 20:32:54, Gao, Liming wrote: >> Laszlo: >> LMFA feature doesn't do PE image rebase at build time. Only XIP >> module needs to be rebased at build time. LMFA feature will >> specify the loaded memory address for each PE image. At build >> time, build tool records the memory address into the one field of >> PE image. It doesn't rebase PE image. At boot time, >> PeiCore/DxeCore/SmmCore will parse PE image, and try to load it at >> the preferred memory address. If the preferred memory address is >> not available, PE image will be loaded to other memory address. >> LMFA feature only supports the source build EFI image, not support >> the binary EFI image. This is a debug feature. >> >> For this case, OvmfPkg DXEFV doesn't require to run as XIP. So, it >> doesn't require rebase. I agree this change. >> > > Liming, > > With this flag set to FALSE, do we attempt to rebase the images, but > just not fail if we can't rebase one of the modules? Or, will this > disable rebasing of all modules in the FV? > > I don't think we really make use of this debug feature in OVMF today, > but I was wondering what potential impact it might have. I thought in > some cases by loading the modules at a fixed address it can help with > loading symbols for debug, right? > > Laszlo, > > I don't think you need to hold off on the patches for this answer, so > you can add an Acked-by from me for your v2. Thanks, will do. Laszlo