From: Paulo Alcantara <pcacjr@zytor.com>
To: Dandan Bi <dandan.bi@intel.com>, edk2-devel@lists.01.org
Subject: Re: [patch 0/3] MdeModulePkg/Udf: Fix VS tool chain build failures
Date: Mon, 11 Sep 2017 22:46:24 -0300 [thread overview]
Message-ID: <669d41f3-ae2f-c98a-7b67-d9dc772c1177@zytor.com> (raw)
In-Reply-To: <1505108680-375928-1-git-send-email-dandan.bi@intel.com>
Dandan,
On 11/09/2017 02:44, Dandan Bi wrote:
>
> Dandan Bi (3):
> MdeModulePkg/PartitionDxe: Don't use non-constant expression in array
> initialization
> MdeModulePkg/UdfDxe: Don't use non-constant expression in array
> initialization
> MdeModulePkg/UdfDxe: Add type cast to fix build failure in VS tools
>
> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 93 +++++++++++++----
> .../Universal/Disk/UdfDxe/FileSystemOperations.c | 111 +++++++++++++++------
> 2 files changed, 153 insertions(+), 51 deletions(-)
>
Looks good to me. Thanks!
Reviewed-by: Paulo Alcantara <pcacjr@zytor.com>
Paulo
prev parent reply other threads:[~2017-09-12 1:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 5:44 [patch 0/3] MdeModulePkg/Udf: Fix VS tool chain build failures Dandan Bi
2017-09-11 5:44 ` [patch 1/3] MdeModulePkg/PartitionDxe: Don't use non-constant expression in array Dandan Bi
2017-09-11 6:08 ` Ni, Ruiyu
2017-09-11 5:44 ` [patch 2/3] MdeModulePkg/UdfDxe: " Dandan Bi
2017-09-11 5:44 ` [patch 3/3] MdeModulePkg/UdfDxe: Add type cast to fix build failure in VS tools Dandan Bi
2017-09-12 1:46 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=669d41f3-ae2f-c98a-7b67-d9dc772c1177@zytor.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox