From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.zytor.com (terminus.zytor.com [65.50.211.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2CBC221E87979 for ; Mon, 11 Sep 2017 18:45:43 -0700 (PDT) Received: from [IPv6:2804:7f4:c480:d1ee::2] ([IPv6:2804:7f4:c480:d1ee:0:0:0:2]) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id v8C1kQbO016258 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 11 Sep 2017 18:46:29 -0700 To: Dandan Bi , edk2-devel@lists.01.org References: <1505108680-375928-1-git-send-email-dandan.bi@intel.com> From: Paulo Alcantara Message-ID: <669d41f3-ae2f-c98a-7b67-d9dc772c1177@zytor.com> Date: Mon, 11 Sep 2017 22:46:24 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1505108680-375928-1-git-send-email-dandan.bi@intel.com> Subject: Re: [patch 0/3] MdeModulePkg/Udf: Fix VS tool chain build failures X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 01:45:43 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Dandan, On 11/09/2017 02:44, Dandan Bi wrote: > > Dandan Bi (3): > MdeModulePkg/PartitionDxe: Don't use non-constant expression in array > initialization > MdeModulePkg/UdfDxe: Don't use non-constant expression in array > initialization > MdeModulePkg/UdfDxe: Add type cast to fix build failure in VS tools > > MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 93 +++++++++++++---- > .../Universal/Disk/UdfDxe/FileSystemOperations.c | 111 +++++++++++++++------ > 2 files changed, 153 insertions(+), 51 deletions(-) > Looks good to me. Thanks! Reviewed-by: Paulo Alcantara Paulo