From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3C375208AE364 for ; Fri, 15 Feb 2019 05:23:40 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5E2B315D4C; Fri, 15 Feb 2019 13:23:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-122-135.rdu2.redhat.com [10.10.122.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80CCE26350; Fri, 15 Feb 2019 13:23:37 +0000 (UTC) To: Hao Wu , edk2-devel@lists.01.org Cc: Jian J Wang , Ray Ni , Eric Dong , Star Zeng , Chao Zhang , Jiewen Yao References: <20190215062338.19412-1-hao.a.wu@intel.com> From: Laszlo Ersek Message-ID: <66af50ad-b5f7-5967-3f58-9bfbc0c0dceb@redhat.com> Date: Fri, 15 Feb 2019 14:23:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190215062338.19412-1-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 15 Feb 2019 13:23:40 +0000 (UTC) Subject: Re: [PATCH v5 00/13] Split the S3 PEI phase HW init codes from Opal driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 13:23:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/15/19 07:23, Hao Wu wrote: > The series is also available at: > https://github.com/hwu25/edk2/tree/opal_remodel_v5 > > V5 changes: > For patch 11, as suggested by Star: > * Refine the UpdateLockBox() API description comment to be more precise; > * Ensure the parameter for macro 'EFI_SIZE_TO_PAGES' is of type 'UINTN'; > > Since the changes are minor, I still keep the origin 'Reviewed-by' from > Ray and the 'Acked-by' tag from Laszlo. > > For patch 12, sync the UpdateLockBox() API description comment with the > change made in patch 11. > > Since the changes are minor, I still keep the origin 'Reviewed-by' from > Laszlo an Ray. OK with me, thanks. Laszlo