From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.10368.1588692584959191759 for ; Tue, 05 May 2020 08:29:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C39qP9I8; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588692584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7M1JvDKEe0U6+Lelu8Bg+gVT7gt1ghI9TYUsKWf5o4I=; b=C39qP9I8RKjWO3W4dmth5vlZyeGfXlzGA1fe3MiUURIj1y17phC/FCzXwlb27uInGbSGkB QZTnGkH60NiDcAn2OMjHpp5XuPnSILX7lFnplm3L8PC70KxqxBhtt2uEIAAJRC11GT2Qxd aSGLh9/xetoh/zQcs51ihE7eAberhzI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-Z4dyUCZ7ONaipfJs5LrTrA-1; Tue, 05 May 2020 11:29:41 -0400 X-MC-Unique: Z4dyUCZ7ONaipfJs5LrTrA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 60696800D24; Tue, 5 May 2020 15:29:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-134.ams2.redhat.com [10.36.114.134]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBC8363F90; Tue, 5 May 2020 15:29:36 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES To: Tom Lendacky , "Dong, Eric" , "devel@edk2.groups.io" Cc: "Justen, Jordan L" , Ard Biesheuvel , "Kinney, Michael D" , "Gao, Liming" , "Ni, Ray" , Brijesh Singh , "Wang, Jian J" , "Wu, Hao A" References: <3af2e4a8-fa4d-bb29-a282-c406ada7cf06@amd.com> From: "Laszlo Ersek" Message-ID: <66c3ab32-0b1c-676b-2924-f14214be5de6@redhat.com> Date: Tue, 5 May 2020 17:29:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 05/04/20 18:41, Tom Lendacky wrote: > Is there an easy way to run everything that this link points, too? Is it > just creating a pull request that does this? I don't want to take up a > lot of your time, so if there's some documentation on how to run an > integration test to find and fix issues like this, just point me to it. Just create a pull request; it will set off CI, and you can review VS build errors there (if any). Your PR will automatically be closed (rejected) regardless of whether CI succeeds or not. PRs are merged -- in fact, *auto*-merged, by the "mergify bot" -- if and only if (a) the CI run succeeds, and (b) the PR has the "push" label set. And only edk2 maintainers have permission to set the "push" label. Any PR without the "push" label qualifies as a "personal test build". So you can freely experiment with PRs, because you can't (even unwittingly) satisfy condition (b). https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Thanks, Laszlo