public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Zhang, Chao B" <chao.b.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Yao Jiewen <jiewen.yao@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.
Date: Fri, 8 Mar 2019 09:02:00 +0100	[thread overview]
Message-ID: <6704daca-ee4e-79c8-f68d-004ddea3345a@redhat.com> (raw)
In-Reply-To: <20190308025638.81892-1-chao.b.zhang@intel.com>

On 03/08/19 03:56, Zhang, Chao B wrote:
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
> ---
>  Maintainers.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7772926b2f..08a676b236 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -1,6 +1,6 @@
> -EDK II Maintainers
> +EDK II Maintainers
>  ==================

This hunk (which is now part of commit 6c05b958df53) is incorrect. It
adds a UTF-8 BOM to the beginning of the file.

Please remove the BOM urgently, before the stable tag.

Thanks
Laszlo

>  
>  This file provides information about the primary maintainers for
>  EDK II.
>  
> @@ -237,10 +237,11 @@ M: Kelly Steele <kelly.steele@intel.com>
>  
>  SecurityPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>  M: Chao Zhang <chao.b.zhang@intel.com>
>  M: Jiewen Yao <jiewen.yao@intel.com>
> +M: Jian Wang <jian.j.wang@intel.com>
>  
>  ShellBinPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>  M: Jaben Carsey <jaben.carsey@intel.com>      (Ia32/X64)
>  M: Ray Ni <ray.ni@intel.com>          (Ia32/X64)
> 



  parent reply	other threads:[~2019-03-08  8:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08  2:56 [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg Zhang, Chao B
2019-03-08  3:07 ` Wang, Jian J
2019-03-08  8:02 ` Laszlo Ersek [this message]
2019-03-08  8:53   ` Zhang, Chao B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6704daca-ee4e-79c8-f68d-004ddea3345a@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox